All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Hyun Kwon" <hyun.kwon@xilinx.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Oleg Vasilev" <oleg.vasilev@intel.com>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"Eryk Brol" <eryk.brol@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
	"Chris Park" <Chris.Park@amd.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Joe Perches" <joe@perches.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"Yuti Amonkar" <yamonkar@cadence.com>,
	"Jyri Sarha" <jsarha@ti.com>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Imre Deak" <imre.deak@intel.com>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<linux-arm-msm@vger.kernel.org>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	"open list:DRM DRIVERS FOR NVIDIA TEGRA"
	<linux-tegra@vger.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux
Date: Thu, 01 Apr 2021 16:31:05 +0300	[thread overview]
Message-ID: <87eefum8rq.fsf@intel.com> (raw)
In-Reply-To: <20210326203807.105754-6-lyude@redhat.com>

On Fri, 26 Mar 2021, Lyude Paul <lyude@redhat.com> wrote:
>   * The @dev field should be set to a pointer to the device that implements the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the &drm_device
> + * that will be using this AUX channel as early as possible. For many graphics
> + * drivers this should happen before drm_dp_aux_init(), however it's perfectly
> + * fine to set this field later so long as it's assigned before calling
> + * drm_dp_aux_register().

Perhaps add a follow-up patch to actually ensure this is the case in
drm_dp_aux_register()?

>   *
>   * The @name field may be used to specify the name of the I2C adapter. If set to
>   * %NULL, dev_name() of @dev will be used.
> @@ -1877,6 +1883,7 @@ struct drm_dp_aux {
>  	const char *name;
>  	struct i2c_adapter ddc;
>  	struct device *dev;
> +	struct drm_device *drm_dev;

Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Oleg Vasilev" <oleg.vasilev@intel.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Imre Deak" <imre.deak@intel.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Li" <sunpeng.li@amd.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Joe Perches" <joe@perches.com>,
	"Yuti Amonkar" <yamonkar@cadence.com>,
	"Jyri Sarha" <jsarha@ti.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"open list:DRM DRIVERS FOR NVIDIA TEGRA"
	<linux-tegra@vger.kernel.org>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"Sean Paul" <sean@poorly.run>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<linux-arm-msm@vger.kernel.org>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Chris Park" <Chris.Park@amd.com>,
	"Eryk Brol" <eryk.brol@amd.com>,
	"Hyun Kwon" <hyun.kwon@xilinx.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Rob Clark" <robdclark@gmail.com>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [Nouveau] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux
Date: Thu, 01 Apr 2021 16:31:05 +0300	[thread overview]
Message-ID: <87eefum8rq.fsf@intel.com> (raw)
In-Reply-To: <20210326203807.105754-6-lyude@redhat.com>

On Fri, 26 Mar 2021, Lyude Paul <lyude@redhat.com> wrote:
>   * The @dev field should be set to a pointer to the device that implements the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the &drm_device
> + * that will be using this AUX channel as early as possible. For many graphics
> + * drivers this should happen before drm_dp_aux_init(), however it's perfectly
> + * fine to set this field later so long as it's assigned before calling
> + * drm_dp_aux_register().

Perhaps add a follow-up patch to actually ensure this is the case in
drm_dp_aux_register()?

>   *
>   * The @name field may be used to specify the name of the I2C adapter. If set to
>   * %NULL, dev_name() of @dev will be used.
> @@ -1877,6 +1883,7 @@ struct drm_dp_aux {
>  	const char *name;
>  	struct i2c_adapter ddc;
>  	struct device *dev;
> +	struct drm_device *drm_dev;

Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Oleg Vasilev" <oleg.vasilev@intel.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Li" <sunpeng.li@amd.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Joe Perches" <joe@perches.com>,
	"Yuti Amonkar" <yamonkar@cadence.com>,
	"Jyri Sarha" <jsarha@ti.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"open list:DRM DRIVERS FOR NVIDIA TEGRA"
	<linux-tegra@vger.kernel.org>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"Sean Paul" <sean@poorly.run>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<linux-arm-msm@vger.kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Chris Park" <Chris.Park@amd.com>,
	"Eryk Brol" <eryk.brol@amd.com>,
	"Hyun Kwon" <hyun.kwon@xilinx.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux
Date: Thu, 01 Apr 2021 16:31:05 +0300	[thread overview]
Message-ID: <87eefum8rq.fsf@intel.com> (raw)
In-Reply-To: <20210326203807.105754-6-lyude@redhat.com>

On Fri, 26 Mar 2021, Lyude Paul <lyude@redhat.com> wrote:
>   * The @dev field should be set to a pointer to the device that implements the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the &drm_device
> + * that will be using this AUX channel as early as possible. For many graphics
> + * drivers this should happen before drm_dp_aux_init(), however it's perfectly
> + * fine to set this field later so long as it's assigned before calling
> + * drm_dp_aux_register().

Perhaps add a follow-up patch to actually ensure this is the case in
drm_dp_aux_register()?

>   *
>   * The @name field may be used to specify the name of the I2C adapter. If set to
>   * %NULL, dev_name() of @dev will be used.
> @@ -1877,6 +1883,7 @@ struct drm_dp_aux {
>  	const char *name;
>  	struct i2c_adapter ddc;
>  	struct device *dev;
> +	struct drm_device *drm_dev;

Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Oleg Vasilev" <oleg.vasilev@intel.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Li" <sunpeng.li@amd.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Joe Perches" <joe@perches.com>,
	"Yuti Amonkar" <yamonkar@cadence.com>,
	"Jyri Sarha" <jsarha@ti.com>,
	"open list:DRM DRIVERS FOR NVIDIA TEGRA"
	<linux-tegra@vger.kernel.org>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<linux-arm-msm@vger.kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Chris Park" <Chris.Park@amd.com>,
	"Eryk Brol" <eryk.brol@amd.com>,
	"Hyun Kwon" <hyun.kwon@xilinx.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [Intel-gfx] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux
Date: Thu, 01 Apr 2021 16:31:05 +0300	[thread overview]
Message-ID: <87eefum8rq.fsf@intel.com> (raw)
In-Reply-To: <20210326203807.105754-6-lyude@redhat.com>

On Fri, 26 Mar 2021, Lyude Paul <lyude@redhat.com> wrote:
>   * The @dev field should be set to a pointer to the device that implements the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the &drm_device
> + * that will be using this AUX channel as early as possible. For many graphics
> + * drivers this should happen before drm_dp_aux_init(), however it's perfectly
> + * fine to set this field later so long as it's assigned before calling
> + * drm_dp_aux_register().

Perhaps add a follow-up patch to actually ensure this is the case in
drm_dp_aux_register()?

>   *
>   * The @name field may be used to specify the name of the I2C adapter. If set to
>   * %NULL, dev_name() of @dev will be used.
> @@ -1877,6 +1883,7 @@ struct drm_dp_aux {
>  	const char *name;
>  	struct i2c_adapter ddc;
>  	struct device *dev;
> +	struct drm_device *drm_dev;

Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Oleg Vasilev" <oleg.vasilev@intel.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Imre Deak" <imre.deak@intel.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Li" <sunpeng.li@amd.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Joe Perches" <joe@perches.com>,
	"Yuti Amonkar" <yamonkar@cadence.com>,
	"Jyri Sarha" <jsarha@ti.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"open list:DRM DRIVERS FOR NVIDIA TEGRA"
	<linux-tegra@vger.kernel.org>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"Sean Paul" <sean@poorly.run>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<linux-arm-msm@vger.kernel.org>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Chris Park" <Chris.Park@amd.com>,
	"Eryk Brol" <eryk.brol@amd.com>,
	"Hyun Kwon" <hyun.kwon@xilinx.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Rob Clark" <robdclark@gmail.com>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux
Date: Thu, 01 Apr 2021 16:31:05 +0300	[thread overview]
Message-ID: <87eefum8rq.fsf@intel.com> (raw)
In-Reply-To: <20210326203807.105754-6-lyude@redhat.com>

On Fri, 26 Mar 2021, Lyude Paul <lyude@redhat.com> wrote:
>   * The @dev field should be set to a pointer to the device that implements the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the &drm_device
> + * that will be using this AUX channel as early as possible. For many graphics
> + * drivers this should happen before drm_dp_aux_init(), however it's perfectly
> + * fine to set this field later so long as it's assigned before calling
> + * drm_dp_aux_register().

Perhaps add a follow-up patch to actually ensure this is the case in
drm_dp_aux_register()?

>   *
>   * The @name field may be used to specify the name of the I2C adapter. If set to
>   * %NULL, dev_name() of @dev will be used.
> @@ -1877,6 +1883,7 @@ struct drm_dp_aux {
>  	const char *name;
>  	struct i2c_adapter ddc;
>  	struct device *dev;
> +	struct drm_device *drm_dev;

Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2021-04-01 17:58 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 20:37 [Nouveau] [PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers Lyude Paul
2021-03-26 20:37 ` Lyude Paul
2021-03-26 20:37 ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37 ` Lyude Paul
2021-03-26 20:37 ` [PATCH v2 01/20] drm/dp: Fixup kernel docs for struct drm_dp_aux Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 02/20] drm/tegra: Don't register DP AUX channels before connectors Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-29  6:51   ` Thierry Reding
2021-03-29  6:51     ` Thierry Reding
2021-03-29  6:51     ` [Intel-gfx] " Thierry Reding
2021-03-29  6:51     ` Thierry Reding
2021-03-29  6:51     ` [Nouveau] " Thierry Reding
2021-03-26 20:37 ` [PATCH v2 03/20] drm/bridge/cdns-mhdp8546: Register DP aux channel with userspace Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 04/20] drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late register/early unregister Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-29  7:08   ` Thierry Reding
2021-03-29  7:08     ` Thierry Reding
2021-03-29  7:08     ` [Intel-gfx] " Thierry Reding
2021-03-29  7:08     ` Thierry Reding
2021-03-29  7:08     ` [Nouveau] " Thierry Reding
2021-04-01 13:31   ` Jani Nikula [this message]
2021-04-01 13:31     ` Jani Nikula
2021-04-01 13:31     ` [Intel-gfx] " Jani Nikula
2021-04-01 13:31     ` Jani Nikula
2021-04-01 13:31     ` [Nouveau] " Jani Nikula
2021-03-26 20:37 ` [PATCH v2 06/20] drm/dp: Clarify DP AUX registration time Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 07/20] drm/print: Fixup DRM_DEBUG_KMS_RATELIMITED() Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-30 10:43   ` Robert Foss
2021-03-30 10:43     ` Robert Foss
2021-03-30 10:43     ` [Intel-gfx] " Robert Foss
2021-03-30 10:43     ` Robert Foss
2021-03-30 10:43     ` [Nouveau] " Robert Foss
2021-03-26 20:37 ` [PATCH v2 08/20] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay() Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 09/20] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay() Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 10/20] drm/dp: Always print aux channel name in logs Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 11/20] drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_detect() Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:37 ` [PATCH v2 12/20] drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_set_tmds_output() Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:37   ` Lyude Paul
2021-03-26 20:37   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 13/20] drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_max_tmds_clock() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 14/20] drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_get_tmds_output() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 15/20] drm/dp_dual_mode: Pass drm_device to drm_lspcon_(get|set)_mode() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 16/20] drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 17/20] drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-30 11:04   ` Robert Foss
2021-03-30 11:04     ` Robert Foss
2021-03-30 11:04     ` [Intel-gfx] " Robert Foss
2021-03-30 11:04     ` Robert Foss
2021-03-30 11:04     ` [Nouveau] " Robert Foss
2021-03-26 20:38 ` [PATCH v2 18/20] drm/dp_dual_mode: Convert drm_dp_dual_mode_helper.c to using drm_err/drm_dbg_kms() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-26 20:38 ` [PATCH v2 19/20] drm/dp_mst: Drop DRM_ERROR() on kzalloc() fail in drm_dp_mst_handle_up_req() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-30 11:06   ` Robert Foss
2021-03-30 11:06     ` Robert Foss
2021-03-30 11:06     ` [Intel-gfx] " Robert Foss
2021-03-30 11:06     ` Robert Foss
2021-03-30 11:06     ` [Nouveau] " Robert Foss
2021-03-26 20:38 ` [PATCH v2 20/20] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*() Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Intel-gfx] " Lyude Paul
2021-03-26 20:38   ` Lyude Paul
2021-03-26 20:38   ` [Nouveau] " Lyude Paul
2021-03-30 11:19   ` Robert Foss
2021-03-30 11:19     ` Robert Foss
2021-03-30 11:19     ` [Intel-gfx] " Robert Foss
2021-03-30 11:19     ` Robert Foss
2021-03-30 11:19     ` [Nouveau] " Robert Foss
2021-03-26 21:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev3) Patchwork
2021-03-26 21:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-26 21:10 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-26 21:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-03-26 22:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev4) Patchwork
2021-03-26 22:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-26 22:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-26 22:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-27  0:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-29 17:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) Patchwork
2021-03-29 17:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-29 17:10 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-29 17:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-29 19:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-01 13:40 ` [Nouveau] [Intel-gfx] [PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers Jani Nikula
2021-04-01 13:40   ` Jani Nikula
2021-04-01 13:40   ` Jani Nikula
2021-04-01 13:40   ` Jani Nikula
2021-04-08 10:49   ` [Nouveau] " Daniel Vetter
2021-04-08 10:49     ` Daniel Vetter
2021-04-08 10:49     ` Daniel Vetter
2021-04-08 10:49     ` Daniel Vetter
2021-04-08 11:13     ` [Nouveau] " Jani Nikula
2021-04-08 11:13       ` Jani Nikula
2021-04-08 11:13       ` Jani Nikula
2021-04-08 11:13       ` Jani Nikula
2021-04-08 18:51       ` [Nouveau] " Lyude Paul
2021-04-08 18:51         ` Lyude Paul
2021-04-08 18:51         ` Lyude Paul
2021-04-08 18:51         ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eefum8rq.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=Chris.Park@amd.com \
    --cc=Jerry.Zuo@amd.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=a.hajda@samsung.com \
    --cc=agx@sigxcpu.org \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=anarsoul@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=boris.brezillon@collabora.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eryk.brol@amd.com \
    --cc=freedreno@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=joe@perches.com \
    --cc=jonas@kwiboo.se \
    --cc=jonathanh@nvidia.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jsarha@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=lucas.demarchi@intel.com \
    --cc=lyude@redhat.com \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.simek@xilinx.com \
    --cc=mikita.lipski@amd.com \
    --cc=mripard@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=oleg.vasilev@intel.com \
    --cc=robdclark@gmail.com \
    --cc=robert.foss@linaro.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sam@ravnborg.org \
    --cc=sean@poorly.run \
    --cc=sjakhade@cadence.com \
    --cc=sunpeng.li@amd.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.