From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: fix CP110 ICU node size
Date: Thu, 05 Jul 2018 15:28:30 +0200 [thread overview]
Message-ID: <87fu0x24n5.fsf@bootlin.com> (raw)
In-Reply-To: <87k1q924qv.fsf@bootlin.com> (Gregory CLEMENT's message of "Thu, 05 Jul 2018 15:26:16 +0200")
Hi,
On jeu., juil. 05 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> Hi Miquel,
>
> On jeu., juil. 05 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>> commit 2f872ddcdb1e8e2186162616cea4581b8403849d upstream.
>>
>> ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
>> specification).
>>
>> Fixes: 6ef84a827c37 ("arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K")
>> Cc: stable@vger.kernel.org # 4.14.x
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>
> See
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2f872ddcdb1e8e2186162616cea4581b8403849d
>
> it is already in the linux kernel.
>
> Gregory
I missed the comment below and the fact it was for the stable branch.
Sorryt for the noise!
Gregory
>
>> ---
>>
>> Backport to 4.14 stable tree: the original patch did not applied
>> because of the effort of DT de-duplication that merged two files in one.
>>
>>
>> arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
>> arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> index 9a7b63cd63a3..7c19f32d0f44 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> @@ -169,7 +169,7 @@
>>
>> cpm_icu: interrupt-controller@1e0000 {
>> compatible = "marvell,cp110-icu";
>> - reg = <0x1e0000 0x10>;
>> + reg = <0x1e0000 0x440>;
>> #interrupt-cells = <3>;
>> interrupt-controller;
>> msi-parent = <&gicp>;
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> index faf28633a309..150e97a1dfea 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> @@ -169,7 +169,7 @@
>>
>> cps_icu: interrupt-controller@1e0000 {
>> compatible = "marvell,cp110-icu";
>> - reg = <0x1e0000 0x10>;
>> + reg = <0x1e0000 0x440>;
>> #interrupt-cells = <3>;
>> interrupt-controller;
>> msi-parent = <&gicp>;
>> --
>> 2.14.1
>>
>
> --
> Gregory Clement, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: marvell: fix CP110 ICU node size
Date: Thu, 05 Jul 2018 15:28:30 +0200 [thread overview]
Message-ID: <87fu0x24n5.fsf@bootlin.com> (raw)
In-Reply-To: <87k1q924qv.fsf@bootlin.com> (Gregory CLEMENT's message of "Thu, 05 Jul 2018 15:26:16 +0200")
Hi,
On jeu., juil. 05 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> Hi Miquel,
>
> On jeu., juil. 05 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>> commit 2f872ddcdb1e8e2186162616cea4581b8403849d upstream.
>>
>> ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
>> specification).
>>
>> Fixes: 6ef84a827c37 ("arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K")
>> Cc: stable at vger.kernel.org # 4.14.x
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>
> See
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2f872ddcdb1e8e2186162616cea4581b8403849d
>
> it is already in the linux kernel.
>
> Gregory
I missed the comment below and the fact it was for the stable branch.
Sorryt for the noise!
Gregory
>
>> ---
>>
>> Backport to 4.14 stable tree: the original patch did not applied
>> because of the effort of DT de-duplication that merged two files in one.
>>
>>
>> arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
>> arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> index 9a7b63cd63a3..7c19f32d0f44 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
>> @@ -169,7 +169,7 @@
>>
>> cpm_icu: interrupt-controller at 1e0000 {
>> compatible = "marvell,cp110-icu";
>> - reg = <0x1e0000 0x10>;
>> + reg = <0x1e0000 0x440>;
>> #interrupt-cells = <3>;
>> interrupt-controller;
>> msi-parent = <&gicp>;
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> index faf28633a309..150e97a1dfea 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> @@ -169,7 +169,7 @@
>>
>> cps_icu: interrupt-controller at 1e0000 {
>> compatible = "marvell,cp110-icu";
>> - reg = <0x1e0000 0x10>;
>> + reg = <0x1e0000 0x440>;
>> #interrupt-cells = <3>;
>> interrupt-controller;
>> msi-parent = <&gicp>;
>> --
>> 2.14.1
>>
>
> --
> Gregory Clement, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-07-05 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 12:34 [PATCH] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal
2018-07-05 12:34 ` Miquel Raynal
2018-07-05 13:26 ` Gregory CLEMENT
2018-07-05 13:26 ` Gregory CLEMENT
2018-07-05 13:28 ` Gregory CLEMENT [this message]
2018-07-05 13:28 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu0x24n5.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.