From: Takashi Iwai <tiwai@suse.de> To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com> Cc: Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski <cezary.rojewski@intel.com> Subject: Re: [RESEND][PATCH] ALSA: info: Fix llseek return value when using callback Date: Wed, 17 Aug 2022 15:15:19 +0200 [thread overview] Message-ID: <87h72bau54.wl-tiwai@suse.de> (raw) In-Reply-To: <20220817124924.3974577-1-amadeuszx.slawinski@linux.intel.com> On Wed, 17 Aug 2022 14:49:24 +0200, Amadeusz Sławiński wrote: > > When using callback there was a flow of > > ret = -EINVAL > if (callback) { > offset = callback(); > goto out; > } > ... > offset = some other value in case of no callback; > ret = offset; > out: > return ret; > > which causes the snd_info_entry_llseek() to return -EINVAL when there is > callback handler. Fix this by setting "ret" directly to callback return > value before jumping to "out". > > 73029e0ff18d ("ALSA: info - Implement common llseek for binary mode") Fixes tag seems missing. I corrected locally. > Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Applied now (with Cc to stable). thanks, Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com> Cc: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH] ALSA: info: Fix llseek return value when using callback Date: Wed, 17 Aug 2022 15:15:19 +0200 [thread overview] Message-ID: <87h72bau54.wl-tiwai@suse.de> (raw) In-Reply-To: <20220817124924.3974577-1-amadeuszx.slawinski@linux.intel.com> On Wed, 17 Aug 2022 14:49:24 +0200, Amadeusz Sławiński wrote: > > When using callback there was a flow of > > ret = -EINVAL > if (callback) { > offset = callback(); > goto out; > } > ... > offset = some other value in case of no callback; > ret = offset; > out: > return ret; > > which causes the snd_info_entry_llseek() to return -EINVAL when there is > callback handler. Fix this by setting "ret" directly to callback return > value before jumping to "out". > > 73029e0ff18d ("ALSA: info - Implement common llseek for binary mode") Fixes tag seems missing. I corrected locally. > Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Applied now (with Cc to stable). thanks, Takashi
next prev parent reply other threads:[~2022-08-17 13:16 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-17 12:49 [RESEND][PATCH] ALSA: info: Fix llseek return value when using callback Amadeusz Sławiński 2022-08-17 12:49 ` Amadeusz Sławiński 2022-08-17 12:56 ` Amadeusz Sławiński 2022-08-17 12:56 ` Amadeusz Sławiński 2022-08-17 13:12 ` Takashi Iwai 2022-08-17 13:12 ` Takashi Iwai 2022-08-17 13:38 ` Cezary Rojewski 2022-08-17 13:50 ` Jaroslav Kysela 2022-08-17 13:15 ` Takashi Iwai [this message] 2022-08-17 13:15 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h72bau54.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=amadeuszx.slawinski@linux.intel.com \ --cc=cezary.rojewski@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.