From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Robert Hancock <robert.hancock@calian.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, michal.simek@xilinx.com,
maruthi.srinivas.bayyavarapu@xilinx.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/6] ASoC: simple-card-utils: Set sysclk on all components
Date: Fri, 21 Jan 2022 00:24:41 +0000 [thread overview]
Message-ID: <87h79ylyv5.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20220120195832.1742271-5-robert.hancock@calian.com>
Hi
> If an mclk-fs value was provided in the device tree configuration, the
> calculated MCLK was fed into the downstream codec DAI and CPU DAI,
> however set_sysclk was not being called on the platform device. Some
> platform devices such as the Xilinx Audio Formatter need to know the MCLK
> as well.
>
> Call snd_soc_component_set_sysclk on each component in the stream to set
> the proper sysclk value in addition to the existing call of
> snd_soc_dai_set_sysclk on the codec DAI and CPU DAI. This may end up
> resulting in redundant calls if one of the snd_soc_dai_set_sysclk calls
> ends up calling snd_soc_component_set_sysclk itself, but that isn't
> expected to cause any significant harm.
>
> Fixes: f48dcbb6d47d ("ASoC: simple-card-utils: share asoc_simple_hw_param()")
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> ---
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Robert Hancock <robert.hancock@calian.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, maruthi.srinivas.bayyavarapu@xilinx.com,
michal.simek@xilinx.com
Subject: Re: [PATCH v3 4/6] ASoC: simple-card-utils: Set sysclk on all components
Date: Fri, 21 Jan 2022 00:24:41 +0000 [thread overview]
Message-ID: <87h79ylyv5.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20220120195832.1742271-5-robert.hancock@calian.com>
Hi
> If an mclk-fs value was provided in the device tree configuration, the
> calculated MCLK was fed into the downstream codec DAI and CPU DAI,
> however set_sysclk was not being called on the platform device. Some
> platform devices such as the Xilinx Audio Formatter need to know the MCLK
> as well.
>
> Call snd_soc_component_set_sysclk on each component in the stream to set
> the proper sysclk value in addition to the existing call of
> snd_soc_dai_set_sysclk on the codec DAI and CPU DAI. This may end up
> resulting in redundant calls if one of the snd_soc_dai_set_sysclk calls
> ends up calling snd_soc_component_set_sysclk itself, but that isn't
> expected to cause any significant harm.
>
> Fixes: f48dcbb6d47d ("ASoC: simple-card-utils: share asoc_simple_hw_param()")
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> ---
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2022-01-21 0:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 19:58 [PATCH v3 0/6] ASoC: Xilinx fixes Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-20 19:58 ` [PATCH v3 1/6] ASoC: xilinx: xlnx_formatter_pcm: Handle sysclk setting Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-20 19:58 ` [PATCH v3 2/6] ASoC: xilinx: xlnx_i2s: create drvdata structure Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-21 9:06 ` Amadeusz Sławiński
2022-01-21 9:06 ` Amadeusz Sławiński
2022-01-21 17:26 ` Robert Hancock
2022-01-21 17:26 ` Robert Hancock
2022-01-20 19:58 ` [PATCH v3 3/6] ASoC: xilinx: xlnx_i2s: Handle sysclk setting Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-20 19:58 ` [PATCH v3 4/6] ASoC: simple-card-utils: Set sysclk on all components Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-21 0:24 ` Kuninori Morimoto [this message]
2022-01-21 0:24 ` Kuninori Morimoto
2022-01-20 19:58 ` [PATCH v3 5/6] ASoC: dt-bindings: simple-card: document new system-clock-fixed flag Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-20 19:58 ` [PATCH v3 6/6] ASoC: simple-card-utils: Add " Robert Hancock
2022-01-20 19:58 ` Robert Hancock
2022-01-25 10:20 ` [PATCH v3 0/6] ASoC: Xilinx fixes Mark Brown
2022-01-25 10:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h79ylyv5.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=maruthi.srinivas.bayyavarapu@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=perex@perex.cz \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.