From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: David Airlie <airlied@linux.ie>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 01/10] driver core: Pull required checks into driver_probe_device()
Date: Tue, 15 Jun 2021 12:27:53 +0200 [thread overview]
Message-ID: <87h7hzxw0m.fsf@redhat.com> (raw)
In-Reply-To: <20210614150846.4111871-2-hch@lst.de>
On Mon, Jun 14 2021, Christoph Hellwig <hch@lst.de> wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> Checking if the dev is dead or if the dev is already bound is a required
> precondition to invoking driver_probe_device(). All the call chains
> leading here duplicate these checks.
>
> Add it directly to driver_probe_device() so the precondition is clear and
> remove the checks from device_driver_attach() and
> __driver_attach_async_helper().
>
> The other call chain going through __device_attach_driver() does have
> these same checks but they are inlined into logic higher up the call stack
> and can't be removed.
>
> The sysfs uAPI call chain starting at bind_store() is a bit confused
> because it reads dev->driver unlocked and returns -ENODEV if it is !NULL,
> otherwise it reads it again under lock and returns 0 if it is !NULL. Fix
> this to always return -EBUSY and always read dev->driver under its lock.
>
> Done in preparation for the next patches which will add additional
> callers to driver_probe_device() and will need these checks as well.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> [hch: drop the extra checks in device_driver_attach and bind_store]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/base/bus.c | 2 +-
> drivers/base/dd.c | 32 ++++++++++----------------------
> 2 files changed, 11 insertions(+), 23 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/10] driver core: Pull required checks into driver_probe_device()
Date: Tue, 15 Jun 2021 12:27:53 +0200 [thread overview]
Message-ID: <87h7hzxw0m.fsf@redhat.com> (raw)
In-Reply-To: <20210614150846.4111871-2-hch@lst.de>
On Mon, Jun 14 2021, Christoph Hellwig <hch@lst.de> wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> Checking if the dev is dead or if the dev is already bound is a required
> precondition to invoking driver_probe_device(). All the call chains
> leading here duplicate these checks.
>
> Add it directly to driver_probe_device() so the precondition is clear and
> remove the checks from device_driver_attach() and
> __driver_attach_async_helper().
>
> The other call chain going through __device_attach_driver() does have
> these same checks but they are inlined into logic higher up the call stack
> and can't be removed.
>
> The sysfs uAPI call chain starting at bind_store() is a bit confused
> because it reads dev->driver unlocked and returns -ENODEV if it is !NULL,
> otherwise it reads it again under lock and returns 0 if it is !NULL. Fix
> this to always return -EBUSY and always read dev->driver under its lock.
>
> Done in preparation for the next patches which will add additional
> callers to driver_probe_device() and will need these checks as well.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> [hch: drop the extra checks in device_driver_attach and bind_store]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/base/bus.c | 2 +-
> drivers/base/dd.c | 32 ++++++++++----------------------
> 2 files changed, 11 insertions(+), 23 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 01/10] driver core: Pull required checks into driver_probe_device()
Date: Tue, 15 Jun 2021 12:27:53 +0200 [thread overview]
Message-ID: <87h7hzxw0m.fsf@redhat.com> (raw)
In-Reply-To: <20210614150846.4111871-2-hch@lst.de>
On Mon, Jun 14 2021, Christoph Hellwig <hch@lst.de> wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> Checking if the dev is dead or if the dev is already bound is a required
> precondition to invoking driver_probe_device(). All the call chains
> leading here duplicate these checks.
>
> Add it directly to driver_probe_device() so the precondition is clear and
> remove the checks from device_driver_attach() and
> __driver_attach_async_helper().
>
> The other call chain going through __device_attach_driver() does have
> these same checks but they are inlined into logic higher up the call stack
> and can't be removed.
>
> The sysfs uAPI call chain starting at bind_store() is a bit confused
> because it reads dev->driver unlocked and returns -ENODEV if it is !NULL,
> otherwise it reads it again under lock and returns 0 if it is !NULL. Fix
> this to always return -EBUSY and always read dev->driver under its lock.
>
> Done in preparation for the next patches which will add additional
> callers to driver_probe_device() and will need these checks as well.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> [hch: drop the extra checks in device_driver_attach and bind_store]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/base/bus.c | 2 +-
> drivers/base/dd.c | 32 ++++++++++----------------------
> 2 files changed, 11 insertions(+), 23 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-15 10:29 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 15:08 Allow mdev drivers to directly create the vfio_device (v2 / alternative) Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 5:16 ` Greg Kroah-Hartman
2021-06-15 5:16 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 5:16 ` Greg Kroah-Hartman
2021-06-15 10:27 ` Cornelia Huck [this message]
2021-06-15 10:27 ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:27 ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 18:47 ` Kirti Wankhede
2021-06-14 18:47 ` [Intel-gfx] " Kirti Wankhede
2021-06-14 18:47 ` Kirti Wankhede
2021-06-15 5:17 ` Greg Kroah-Hartman
2021-06-15 5:17 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 5:17 ` Greg Kroah-Hartman
2021-06-15 5:48 ` Christoph Hellwig
2021-06-15 5:48 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 5:18 ` Greg Kroah-Hartman
2021-06-15 5:18 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 5:18 ` Greg Kroah-Hartman
2021-06-15 10:31 ` Cornelia Huck
2021-06-15 10:31 ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:31 ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 22:43 ` Jason Gunthorpe
2021-06-14 22:43 ` [Intel-gfx] " Jason Gunthorpe
2021-06-14 22:43 ` Jason Gunthorpe
2021-06-14 15:08 ` [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 5:20 ` Greg Kroah-Hartman
2021-06-15 5:20 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 5:20 ` Greg Kroah-Hartman
2021-06-15 10:49 ` Cornelia Huck
2021-06-15 10:49 ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:49 ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 10:50 ` Cornelia Huck
2021-06-15 10:50 ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:50 ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 10:54 ` Cornelia Huck
2021-06-15 10:54 ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:54 ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 09/10] vfio/mdpy: " Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 10/10] vfio/mbochs: " Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 0:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
2021-06-15 0:23 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-15 0:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-15 5:21 ` Allow mdev drivers to directly create the vfio_device (v2 / alternative) Greg Kroah-Hartman
2021-06-15 5:21 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 5:21 ` Greg Kroah-Hartman
2021-06-15 5:50 ` Christoph Hellwig
2021-06-15 5:50 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 15:27 ` Jason Gunthorpe
2021-06-15 15:27 ` [Intel-gfx] " Jason Gunthorpe
2021-06-15 15:27 ` Jason Gunthorpe
2021-06-15 9:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
2021-06-15 13:35 Allow mdev drivers to directly create the vfio_device (v3) Christoph Hellwig
2021-06-15 13:35 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig
2021-06-17 14:22 Allow mdev drivers to directly create the vfio_device (v4) Christoph Hellwig
2021-06-17 14:22 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7hzxw0m.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.