From: Thomas Gleixner <tglx@linutronix.de> To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org Cc: Paul Mackerras <paulus@samba.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>, linux-block@vger.kernel.org, "Michael S . Tsirkin" <mst@redhat.com>, Marc Zyngier <maz@kernel.org>, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Laurent Vivier <lvivier@redhat.com> Subject: Re: [PATCH 1/2] genirq: add an affinity parameter to irq_create_mapping() Date: Tue, 24 Nov 2020 23:19:47 +0100 [thread overview] Message-ID: <87h7pel7ng.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <20201124200308.1110744-2-lvivier@redhat.com> On Tue, Nov 24 2020 at 21:03, Laurent Vivier wrote: > This parameter is needed to pass it to irq_domain_alloc_descs(). > > This seems to have been missed by > o06ee6d571f0e ("genirq: Add affinity hint to irq allocation") No, this has not been missed at all. There was and is no reason to do this. > This is needed to implement proper support for multiqueue with > pseries. And because pseries needs this _all_ callers need to be changed? > 123 files changed, 171 insertions(+), 146 deletions(-) Lots of churn for nothing. 99% of the callers will never need that. What's wrong with simply adding an interface which takes that parameter, make the existing one an inline wrapper and and leave the rest alone? Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org Cc: Laurent Vivier <lvivier@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Marc Zyngier <maz@kernel.org>, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH 1/2] genirq: add an affinity parameter to irq_create_mapping() Date: Tue, 24 Nov 2020 23:19:47 +0100 [thread overview] Message-ID: <87h7pel7ng.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <20201124200308.1110744-2-lvivier@redhat.com> On Tue, Nov 24 2020 at 21:03, Laurent Vivier wrote: > This parameter is needed to pass it to irq_domain_alloc_descs(). > > This seems to have been missed by > o06ee6d571f0e ("genirq: Add affinity hint to irq allocation") No, this has not been missed at all. There was and is no reason to do this. > This is needed to implement proper support for multiqueue with > pseries. And because pseries needs this _all_ callers need to be changed? > 123 files changed, 171 insertions(+), 146 deletions(-) Lots of churn for nothing. 99% of the callers will never need that. What's wrong with simply adding an interface which takes that parameter, make the existing one an inline wrapper and and leave the rest alone? Thanks, tglx
next prev parent reply other threads:[~2020-11-24 22:19 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-24 20:03 [PATCH 0/2] powerpc/pseries: fix MSI/X IRQ affinity on pseries Laurent Vivier 2020-11-24 20:03 ` Laurent Vivier 2020-11-24 20:03 ` [PATCH 1/2] genirq: add an affinity parameter to irq_create_mapping() Laurent Vivier 2020-11-24 20:03 ` Laurent Vivier 2020-11-24 22:19 ` Thomas Gleixner [this message] 2020-11-24 22:19 ` Thomas Gleixner 2020-11-25 7:30 ` Laurent Vivier 2020-11-25 7:30 ` Laurent Vivier 2020-11-24 22:50 ` kernel test robot 2020-11-24 22:50 ` kernel test robot 2020-11-24 22:50 ` kernel test robot 2020-11-25 1:03 ` kernel test robot 2020-11-25 1:03 ` kernel test robot 2020-11-25 1:03 ` kernel test robot 2020-11-24 20:03 ` [PATCH 2/2] powerpc/pseries: pass MSI affinity " Laurent Vivier 2020-11-24 20:03 ` Laurent Vivier 2020-11-24 22:35 ` Thomas Gleixner 2020-11-24 22:35 ` Thomas Gleixner 2020-11-24 21:08 ` [PATCH 0/2] powerpc/pseries: fix MSI/X IRQ affinity on pseries Michael S. Tsirkin 2020-11-24 21:08 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h7pel7ng.fsf@nanos.tec.linutronix.de \ --to=tglx@linutronix.de \ --cc=benh@kernel.crashing.org \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lvivier@redhat.com \ --cc=maz@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=mst@redhat.com \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.