From: Arseny Solokha <asolokha@kb.kras.ru> To: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Arseny Solokha <asolokha@kb.kras.ru>, Michael Ellerman <mpe@ellerman.id.au>, Jason Yan <yanaijie@huawei.com>, <linuxppc-dev@lists.ozlabs.org>, Scott Wood <oss@buserror.net>, Christophe Leroy <christophe.leroy@c-s.fr>, <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org> Subject: Re: [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE Date: Sun, 14 Jun 2020 04:20:25 +0700 [thread overview] Message-ID: <87imfupsrq.fsf@himel> (raw) In-Reply-To: <754d31be-730b-8f18-4ead-ba2f303650d0@csgroup.eu> (Christophe Leroy's message of "Sat, 13 Jun 2020 19:28:19 +0200") > Le 13/06/2020 à 18:28, Arseny Solokha a écrit : >> Building the current 5.8 kernel for a e500 machine with >> CONFIG_RANDOMIZE_BASE set yields the following failure: >> >> arch/powerpc/mm/nohash/kaslr_booke.c: In function 'kaslr_early_init': >> arch/powerpc/mm/nohash/kaslr_booke.c:387:2: error: implicit declaration >> of function 'flush_icache_range'; did you mean 'flush_tlb_range'? >> [-Werror=implicit-function-declaration] >> >> Indeed, including asm/cacheflush.h into kaslr_booke.c fixes the build. >> >> The issue dates back to the introduction of that file and probably went >> unnoticed because there's no in-tree defconfig with CONFIG_RANDOMIZE_BASE >> set. > > I don't get this problem with mpc85xx_defconfig + RELOCATABLE + > RANDOMIZE_BASE. Ah, OK. So the critical difference between mpc85xx_defconfig and our custom config is that the former sets CONFIG_BLOCK while ours doesn't. Then we have the following dependence chain: arch/powerpc/mm/nohash/kaslr_booke.c include/linux/swap.h include/linux/memcontrol.h include/linux/writeback.h include/linux/blk-cgroup.h include/linux/blkdev.h #ifdef CONFIG_BLOCK #include <linux/pagemap.h> #endif include/linux/pagemap.h include/linux/highmem.h arch/powerpc/include/asm/cacheflush.h and that's how the latter doesn't get included in arch/powerpc/mm/nohash/kaslr_booke.c, because in our config CONFIG_BLOCK is not defined in the first place. Arseny > Christophe > >> >> Fixes: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure") >> Cc: stable@vger.kernel.org >> Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> >> --- >> arch/powerpc/mm/nohash/kaslr_booke.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kaslr_booke.c >> index 4a75f2d9bf0e..bce0e5349978 100644 >> --- a/arch/powerpc/mm/nohash/kaslr_booke.c >> +++ b/arch/powerpc/mm/nohash/kaslr_booke.c >> @@ -14,6 +14,7 @@ >> #include <linux/memblock.h> >> #include <linux/libfdt.h> >> #include <linux/crash_core.h> >> +#include <asm/cacheflush.h> >> #include <asm/pgalloc.h> >> #include <asm/prom.h> >> #include <asm/kdump.h> >>
WARNING: multiple messages have this Message-ID (diff)
From: Arseny Solokha <asolokha@kb.kras.ru> To: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Christophe Leroy <christophe.leroy@c-s.fr>, Jason Yan <yanaijie@huawei.com>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Scott Wood <oss@buserror.net>, Arseny Solokha <asolokha@kb.kras.ru>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE Date: Sun, 14 Jun 2020 04:20:25 +0700 [thread overview] Message-ID: <87imfupsrq.fsf@himel> (raw) In-Reply-To: <754d31be-730b-8f18-4ead-ba2f303650d0@csgroup.eu> (Christophe Leroy's message of "Sat, 13 Jun 2020 19:28:19 +0200") > Le 13/06/2020 à 18:28, Arseny Solokha a écrit : >> Building the current 5.8 kernel for a e500 machine with >> CONFIG_RANDOMIZE_BASE set yields the following failure: >> >> arch/powerpc/mm/nohash/kaslr_booke.c: In function 'kaslr_early_init': >> arch/powerpc/mm/nohash/kaslr_booke.c:387:2: error: implicit declaration >> of function 'flush_icache_range'; did you mean 'flush_tlb_range'? >> [-Werror=implicit-function-declaration] >> >> Indeed, including asm/cacheflush.h into kaslr_booke.c fixes the build. >> >> The issue dates back to the introduction of that file and probably went >> unnoticed because there's no in-tree defconfig with CONFIG_RANDOMIZE_BASE >> set. > > I don't get this problem with mpc85xx_defconfig + RELOCATABLE + > RANDOMIZE_BASE. Ah, OK. So the critical difference between mpc85xx_defconfig and our custom config is that the former sets CONFIG_BLOCK while ours doesn't. Then we have the following dependence chain: arch/powerpc/mm/nohash/kaslr_booke.c include/linux/swap.h include/linux/memcontrol.h include/linux/writeback.h include/linux/blk-cgroup.h include/linux/blkdev.h #ifdef CONFIG_BLOCK #include <linux/pagemap.h> #endif include/linux/pagemap.h include/linux/highmem.h arch/powerpc/include/asm/cacheflush.h and that's how the latter doesn't get included in arch/powerpc/mm/nohash/kaslr_booke.c, because in our config CONFIG_BLOCK is not defined in the first place. Arseny > Christophe > >> >> Fixes: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure") >> Cc: stable@vger.kernel.org >> Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> >> --- >> arch/powerpc/mm/nohash/kaslr_booke.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kaslr_booke.c >> index 4a75f2d9bf0e..bce0e5349978 100644 >> --- a/arch/powerpc/mm/nohash/kaslr_booke.c >> +++ b/arch/powerpc/mm/nohash/kaslr_booke.c >> @@ -14,6 +14,7 @@ >> #include <linux/memblock.h> >> #include <linux/libfdt.h> >> #include <linux/crash_core.h> >> +#include <asm/cacheflush.h> >> #include <asm/pgalloc.h> >> #include <asm/prom.h> >> #include <asm/kdump.h> >>
next prev parent reply other threads:[~2020-06-13 21:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-13 16:28 [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE Arseny Solokha 2020-06-13 16:28 ` Arseny Solokha 2020-06-13 17:28 ` Christophe Leroy 2020-06-13 21:20 ` Arseny Solokha [this message] 2020-06-13 21:20 ` Arseny Solokha 2020-06-15 1:19 ` Jason Yan 2020-06-15 1:19 ` Jason Yan 2020-06-15 14:53 ` Scott Wood 2020-06-15 14:53 ` Scott Wood 2020-06-26 4:44 ` Michael Ellerman 2020-06-26 4:44 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87imfupsrq.fsf@himel \ --to=asolokha@kb.kras.ru \ --cc=christophe.leroy@c-s.fr \ --cc=christophe.leroy@csgroup.eu \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=oss@buserror.net \ --cc=stable@vger.kernel.org \ --cc=yanaijie@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.