Re: [PATCH 2/2] nfsd: Change the default to enable all minor versions unless told otherwise

From: NeilBrown <neilb@suse.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>, steved@redhat.com
Cc: linux-nfs@vger.kernel.org, bfields@fieldses.org
Subject: Re: [PATCH 2/2] nfsd: Change the default to enable all minor versions unless told otherwise
Date: Fri, 24 Feb 2017 12:17:03 +1100	[thread overview]
Message-ID: <87ino0qtf4.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20170224003344.113724-3-trond.myklebust@primarydata.com>

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

On Thu, Feb 23 2017, Trond Myklebust wrote:

> Instead of letting the kernel decide, default to enabling all versions,
> and let the user be more specifc in /etc/nfs.conf or on the command line.

What is your rationale for this?
I think there is value in allowing the kernel to support a version while
disabling it by default.  This allows it to be used for experimentation,
without much risk of it being used in production until it is deemed to
be really ready.

I like the rest of the patch set, and withdraw my comments about the
earlier patch set which were due to a hasty misunderstanding.

Thanks,
NeilBrown

>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
> ---
>  utils/nfsd/nfsd.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
> index 1708521ab286..9735e65466fa 100644
> --- a/utils/nfsd/nfsd.c
> +++ b/utils/nfsd/nfsd.c
> @@ -107,13 +107,12 @@ main(int argc, char **argv)
>  	}
>  
>  	nfssvc_get_minormask(&minormask);
> -	/* We assume the kernel will default all minor versions to 'on',
> -	 * and allow the config file to disable some.
> +	/* We default all minor versions to 'on', and allow the config
> +	 * file to disable some.
>  	 */
> -	if (NFSCTL_VERISSET(versbits, 4)) {
> -		NFSCTL_MINORSET(minorversset, 0);
> -		NFSCTL_MINORSET(minorvers, 0);
> -	}
> +	if (NFSCTL_VERISSET(versbits, 4))
> +		minorversset = minorvers = minormask;
> +
>  	for (i = 1; i <= NFS4_MAXMINOR; i++) {
>  		char tag[20];
>  		sprintf(tag, "vers4.%d", i);
> -- 
> 2.9.3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]