From: Steve Dickson <SteveD@RedHat.com>
To: Trond Myklebust <trondmy@primarydata.com>
Cc: James Bruce Fields <bfields@fieldses.org>,
"neilb@suse.com" <neilb@suse.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfsd: Allow the caller to turn off NFSv4.0 without turning off NFSv4.x
Date: Wed, 5 Apr 2017 13:29:39 -0400 [thread overview]
Message-ID: <e132765d-8474-b9fb-9df1-2a296884d236@RedHat.com> (raw)
In-Reply-To: <4a409f78-9dfb-cfa4-67e7-6c67b8d263ac@RedHat.com>
On 04/04/2017 05:31 PM, Steve Dickson wrote:
>>> But I'm thinking the expectation of nfsd -N4.0 is to only
>>> turn off v4.0 and not work the same as -N4 which turns all of
>>> v4 off which is expected.
>>>
>>> When you say old kernel... How old?
>> Linux 4.10 or older.
> So what will happen when this is done
> nfsd -d -N4.0 -V4.1 -V4.2
> on an older kernel?
On an older kernel this turns off all v4 minor version.
Plus on older kernels you can turn v4.1 and v4.2 on
and off but as soon as v4 or v4.0 is turned off
all versions are off...
With newer kernels things work as expected.
Committed...
steved.
>
> Also looking at the code when -N4.0 is used
> it zero out the entire minorversset which means
> the -4.1 and -4.2 is not written out to the versions file
>
> nfsd -d -N4
> nfsd: Writing version string to kernel: -2 +3 -4 -4.1 -4.2
>
> nfsd -d -N4.0
> nfsd: Writing version string to kernel: -2 +3 -4
>
> I'm not sure if this matters or not... but it is different.
>
> steved.
prev parent reply other threads:[~2017-04-05 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 0:33 [PATCH 0/2] Patch rpc.nfsd to allow the caller to turn off NFSv4.0 Trond Myklebust
2017-02-24 0:33 ` [PATCH 1/2] nfsd: Allow the caller to turn off NFSv4.0 without turning off NFSv4.x Trond Myklebust
2017-02-24 0:33 ` [PATCH 2/2] nfsd: Change the default to enable all minor versions unless told otherwise Trond Myklebust
2017-02-24 1:17 ` NeilBrown
2017-02-24 1:42 ` Trond Myklebust
2017-02-24 2:27 ` NeilBrown
2017-02-24 20:32 ` bfields
2017-04-04 20:08 ` Steve Dickson
2017-04-04 20:07 ` [PATCH 1/2] nfsd: Allow the caller to turn off NFSv4.0 without turning off NFSv4.x Steve Dickson
2017-04-04 20:26 ` Trond Myklebust
2017-04-04 21:07 ` Steve Dickson
[not found] ` <4B984CF4-7D50-4B11-B26E-886845068329@primarydata.com>
2017-04-04 21:31 ` Steve Dickson
2017-04-05 17:29 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e132765d-8474-b9fb-9df1-2a296884d236@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.