All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	 ath11k@lists.infradead.org,
	 linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	 linux-wireless@vger.kernel.org,  regressions@lists.linux.dev
Subject: Re: [regression] mhi: ath11k resume fails on some devices
Date: Thu, 16 Sep 2021 19:42:02 +0300	[thread overview]
Message-ID: <87k0jgxyjp.fsf@codeaurora.org> (raw)
In-Reply-To: <20210916163529.GA9027@thinkpad> (Manivannan Sadhasivam's message of "Thu, 16 Sep 2021 22:05:29 +0530")

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:

> On Thu, Sep 16, 2021 at 01:18:22PM +0200, Loic Poulain wrote:
>> Le jeu. 16 sept. 2021 à 13:12, Manivannan Sadhasivam <
>> manivannan.sadhasivam@linaro.org> a écrit :
>> 
>
> [...]
>
>> > If things seems to work fine without that patch, then it implies that
>> > setting M0
>> > state works during resume. I think we should just revert that patch.
>> >
>> > Loic, did that patch fix any issue for you or it was a cosmetic fix only?
>> 
>> 
>> It fixes sdx modem resuming issue, without that we don’t know modem needs
>> to be reinitialized.
>> 
>
> Okay. Then in that case, the recovery mechanism has to be added to the ath11k
> MHI controller.

What does that mean in practise, do you have any pointers or examples? I
have no clue what you are proposing :)

> If that's too much of work for Kalle, then I'll look into it. But I might get
> time only after Plumbers.

I'm busy, as always, so not sure when I'm able to do it either. I think
we should seriously consider reverting 020d3b26c07a and adding it back
after ath11k is able to handle this new situation.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	ath11k@lists.infradead.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-wireless@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [regression] mhi: ath11k resume fails on some devices
Date: Thu, 16 Sep 2021 19:42:02 +0300	[thread overview]
Message-ID: <87k0jgxyjp.fsf@codeaurora.org> (raw)
In-Reply-To: <20210916163529.GA9027@thinkpad> (Manivannan Sadhasivam's message of "Thu, 16 Sep 2021 22:05:29 +0530")

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:

> On Thu, Sep 16, 2021 at 01:18:22PM +0200, Loic Poulain wrote:
>> Le jeu. 16 sept. 2021 à 13:12, Manivannan Sadhasivam <
>> manivannan.sadhasivam@linaro.org> a écrit :
>> 
>
> [...]
>
>> > If things seems to work fine without that patch, then it implies that
>> > setting M0
>> > state works during resume. I think we should just revert that patch.
>> >
>> > Loic, did that patch fix any issue for you or it was a cosmetic fix only?
>> 
>> 
>> It fixes sdx modem resuming issue, without that we don’t know modem needs
>> to be reinitialized.
>> 
>
> Okay. Then in that case, the recovery mechanism has to be added to the ath11k
> MHI controller.

What does that mean in practise, do you have any pointers or examples? I
have no clue what you are proposing :)

> If that's too much of work for Kalle, then I'll look into it. But I might get
> time only after Plumbers.

I'm busy, as always, so not sure when I'm able to do it either. I think
we should seriously consider reverting 020d3b26c07a and adding it back
after ath11k is able to handle this new situation.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-09-16 16:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  8:00 [regression] mhi: ath11k resume fails on some devices Kalle Valo
2021-09-16  8:00 ` Kalle Valo
2021-09-16 10:18 ` Loic Poulain
2021-09-16 10:18   ` Loic Poulain
2021-09-16 10:18   ` Loic Poulain
2021-09-16 11:12   ` Manivannan Sadhasivam
2021-09-16 11:12     ` Manivannan Sadhasivam
     [not found]     ` <CAMZdPi94607mZorp+Zmkw3seWXak6p9Jr05CQ5hhfgKQoG8n7Q@mail.gmail.com>
2021-09-16 16:35       ` Manivannan Sadhasivam
2021-09-16 16:35         ` Manivannan Sadhasivam
2021-09-16 16:42         ` Kalle Valo [this message]
2021-09-16 16:42           ` Kalle Valo
2021-09-16 16:42           ` Kalle Valo
2021-09-16 17:19           ` Manivannan Sadhasivam
2021-09-16 17:19             ` Manivannan Sadhasivam
2021-09-23  8:34             ` Carl Huang
2021-09-23  8:34               ` Carl Huang
2021-09-23  8:59               ` Manivannan Sadhasivam
2021-09-23  8:59                 ` Manivannan Sadhasivam
2021-09-23  9:26                 ` Carl Huang
2021-09-23  9:26                   ` Carl Huang
2021-09-23 10:50                   ` Loic Poulain
2021-09-23 10:50                     ` Loic Poulain
2021-09-23 10:50                     ` Loic Poulain
2021-09-24  9:07                 ` Kalle Valo
2021-09-24  9:07                   ` Kalle Valo
2021-09-24  9:07                   ` Kalle Valo
2021-09-24  9:57                   ` Manivannan Sadhasivam
2021-09-24  9:57                     ` Manivannan Sadhasivam
2021-10-07  9:55                     ` Kalle Valo
2021-10-07  9:55                       ` Kalle Valo
2021-10-21 10:01                       ` Manivannan Sadhasivam
2021-10-21 10:01                         ` Manivannan Sadhasivam
2021-09-24  8:36   ` Kalle Valo
2021-09-24  8:36     ` Kalle Valo
2021-09-24  8:36     ` Kalle Valo
2021-09-24  9:43     ` Loic Poulain
2021-09-24  9:43       ` Loic Poulain
2021-09-24  9:43       ` Loic Poulain
2021-09-24 10:00       ` Manivannan Sadhasivam
2021-09-24 10:00         ` Manivannan Sadhasivam
2021-10-07  9:48       ` Kalle Valo
2021-10-07  9:48         ` Kalle Valo
2021-10-19 12:12         ` Kalle Valo
2021-10-19 12:12           ` Kalle Valo
2021-10-21 10:03           ` Manivannan Sadhasivam
2021-10-21 10:03             ` Manivannan Sadhasivam
2021-11-12 11:36             ` Thorsten Leemhuis
2021-11-12 11:36               ` Thorsten Leemhuis
2021-11-18 17:41             ` Manivannan Sadhasivam
2021-11-18 17:41               ` Manivannan Sadhasivam
2021-12-01  7:34               ` Thorsten Leemhuis
2021-12-01  7:34                 ` Thorsten Leemhuis
2021-09-25 17:40 ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0jgxyjp.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.