From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
Date: Tue, 28 Apr 2020 12:33:54 +0300 [thread overview]
Message-ID: <87k120eyyl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200428091303.089AEC433D2@smtp.codeaurora.org> (Kalle Valo's message of "Tue, 28 Apr 2020 09:13:03 +0000 (UTC)")
Kalle Valo <kvalo@codeaurora.org> writes:
> Wen Gong <wgong@codeaurora.org> wrote:
>
>> For wmi tlv type, firmware disable peer stats info by default, after
>> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if
>> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
>>
>> Enable it will only set a flag in firmware, firmware will not report
>> it without receive request WMI command.
>>
>> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>>
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> 4 patches applied to ath-next branch of ath.git, thanks.
>
> 2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv
> 0f7cb26830a6 ath10k: add rx bitrate report for SDIO
> 3344b99d69ab ath10k: add bitrate parse for peer stats info
> 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO
I think these caused a new warning which I missed:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected restricted __le32 [usertype] reset_after_request
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int [usertype] reset
Please send a followup patch to fix that.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
Date: Tue, 28 Apr 2020 12:33:54 +0300 [thread overview]
Message-ID: <87k120eyyl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200428091303.089AEC433D2@smtp.codeaurora.org> (Kalle Valo's message of "Tue, 28 Apr 2020 09:13:03 +0000 (UTC)")
Kalle Valo <kvalo@codeaurora.org> writes:
> Wen Gong <wgong@codeaurora.org> wrote:
>
>> For wmi tlv type, firmware disable peer stats info by default, after
>> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if
>> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
>>
>> Enable it will only set a flag in firmware, firmware will not report
>> it without receive request WMI command.
>>
>> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>>
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> 4 patches applied to ath-next branch of ath.git, thanks.
>
> 2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv
> 0f7cb26830a6 ath10k: add rx bitrate report for SDIO
> 3344b99d69ab ath10k: add bitrate parse for peer stats info
> 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO
I think these caused a new warning which I missed:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected restricted __le32 [usertype] reset_after_request
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int [usertype] reset
Please send a followup patch to fix that.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-04-28 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 8:04 [PATCH v2 0/4] ath10k: sdio: add support for rx/tx bitrate reporting Wen Gong
2020-04-27 8:04 ` Wen Gong
2020-04-27 8:04 ` [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv Wen Gong
2020-04-27 8:04 ` Wen Gong
2020-04-28 9:13 ` Kalle Valo
2020-04-28 9:33 ` Kalle Valo [this message]
2020-04-28 9:33 ` Kalle Valo
2020-04-28 9:49 ` Wen Gong
2020-04-28 9:49 ` Wen Gong
2020-04-28 9:13 ` Kalle Valo
2020-04-27 8:04 ` [PATCH v2 2/4] ath10k: add rx bitrate report for SDIO Wen Gong
2020-04-27 8:04 ` Wen Gong
2020-04-27 8:04 ` [PATCH v2 3/4] ath10k: add bitrate parse for peer stats info Wen Gong
2020-04-27 8:04 ` Wen Gong
2020-04-27 8:04 ` [PATCH v2 4/4] ath10k: correct tx bitrate of iw for SDIO Wen Gong
2020-04-27 8:04 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k120eyyl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.