From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mips@vger.kernel.org, Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
intel-gvt-dev@lists.freedesktop.org,
Joerg Roedel <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Zhi Wang <zhi.a.wang@intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
intel-gfx@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
intel-gvt-dev@lists.freedesktop.org,
Joerg Roedel <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Zhi Wang <zhi.a.wang@intel.com>,
intel-gfx@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
Zhenyu Wang <zhenyuw@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
intel-gvt-dev@lists.freedesktop.org,
Joerg Roedel <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Zhi Wang <zhi.a.wang@intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
intel-gfx@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
intel-gvt-dev@lists.freedesktop.org,
Joerg Roedel <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
intel-gfx@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [Intel-gfx] [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 11:43:19 +0100 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize == PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Stevens <stevensd@chromium.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU
Date: Thu, 24 Jun 2021 10:43:19 +0000 [thread overview]
Message-ID: <87lf6zilvc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210624035749.4054934-5-stevensd@google.com>
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens <stevensd@chromium.org> wrote:
>
> From: David Stevens <stevensd@chromium.org>
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow_fault_pfn may not have a struct page set up for reference
> counting.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/arm64/kvm/mmu.c | 43 +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 896b3644b36f..a741972cb75f 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
[...]
> @@ -968,16 +968,16 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> */
> if (vma_pagesize = PAGE_SIZE && !force_pte)
> vma_pagesize = transparent_hugepage_adjust(memslot, hva,
> - &pfn, &fault_ipa);
> + &pfnpg, &fault_ipa);
> if (writable)
> prot |= KVM_PGTABLE_PROT_W;
>
> if (fault_status != FSC_PERM && !device)
> - clean_dcache_guest_page(pfn, vma_pagesize);
> + clean_dcache_guest_page(pfnpg.pfn, vma_pagesize);
>
> if (exec_fault) {
> prot |= KVM_PGTABLE_PROT_X;
> - invalidate_icache_guest_page(pfn, vma_pagesize);
> + invalidate_icache_guest_page(pfnpg.pfn, vma_pagesize);
This is going to clash with what is currently in -next, specially with
MTE.
Paolo, if you really want to take this in 5.13, can you please push a
stable branch based on -rc4 or older so that I can merge it in and
test it?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-06-24 10:43 UTC|newest]
Thread overview: 213+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 3:57 [PATCH 0/6] KVM: Remove uses of struct page from x86 and arm64 MMU David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [PATCH 1/6] KVM: x86/mmu: release audited pfns David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 8:43 ` Nicholas Piggin
2021-06-24 8:43 ` Nicholas Piggin
2021-06-24 8:43 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 8:43 ` Nicholas Piggin
2021-06-24 8:43 ` Nicholas Piggin
2021-06-24 8:43 ` Nicholas Piggin
2021-06-24 9:43 ` Paolo Bonzini
2021-06-24 9:43 ` Paolo Bonzini
2021-06-24 9:43 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 9:43 ` Paolo Bonzini
2021-06-24 9:43 ` Paolo Bonzini
2021-06-24 9:43 ` Paolo Bonzini
2021-06-24 15:36 ` Sean Christopherson
2021-06-24 15:36 ` [Intel-gfx] " Sean Christopherson
2021-06-24 15:36 ` Sean Christopherson
2021-06-24 15:36 ` Sean Christopherson
2021-06-24 15:36 ` Sean Christopherson
2021-06-24 15:36 ` Sean Christopherson
2021-06-24 3:57 ` [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 8:52 ` Nicholas Piggin
2021-06-24 8:52 ` Nicholas Piggin
2021-06-24 8:52 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 8:52 ` Nicholas Piggin
2021-06-24 8:52 ` Nicholas Piggin
2021-06-24 8:52 ` Nicholas Piggin
2021-06-24 9:42 ` Paolo Bonzini
2021-06-24 9:42 ` Paolo Bonzini
2021-06-24 9:42 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 9:42 ` Paolo Bonzini
2021-06-24 9:42 ` Paolo Bonzini
2021-06-24 9:42 ` Paolo Bonzini
2021-06-24 9:57 ` Nicholas Piggin
2021-06-24 9:57 ` Nicholas Piggin
2021-06-24 9:57 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 9:57 ` Nicholas Piggin
2021-06-24 9:57 ` Nicholas Piggin
2021-06-24 9:57 ` Nicholas Piggin
2021-06-24 10:13 ` Paolo Bonzini
2021-06-24 10:13 ` Paolo Bonzini
2021-06-24 10:13 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 10:13 ` Paolo Bonzini
2021-06-24 10:13 ` Paolo Bonzini
2021-06-24 10:13 ` Paolo Bonzini
2021-06-24 10:17 ` Nicholas Piggin
2021-06-24 10:17 ` Nicholas Piggin
2021-06-24 10:17 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 10:17 ` Nicholas Piggin
2021-06-24 10:17 ` Nicholas Piggin
2021-06-24 10:17 ` Nicholas Piggin
2021-06-24 10:21 ` Paolo Bonzini
2021-06-24 10:21 ` Paolo Bonzini
2021-06-24 10:21 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 10:21 ` Paolo Bonzini
2021-06-24 10:21 ` Paolo Bonzini
2021-06-24 10:21 ` Paolo Bonzini
2021-06-24 10:42 ` Nicholas Piggin
2021-06-24 10:42 ` Nicholas Piggin
2021-06-24 10:42 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 10:42 ` Nicholas Piggin
2021-06-24 10:42 ` Nicholas Piggin
2021-06-24 10:42 ` Nicholas Piggin
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 9:40 ` [Intel-gfx] " Marc Zyngier
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 9:40 ` Marc Zyngier
2021-06-24 3:57 ` [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 7:31 ` Paolo Bonzini
2021-06-24 7:31 ` Paolo Bonzini
2021-06-24 7:31 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 7:31 ` Paolo Bonzini
2021-06-24 7:31 ` Paolo Bonzini
2021-06-24 7:31 ` Paolo Bonzini
2021-06-24 8:58 ` Nicholas Piggin
2021-06-24 8:58 ` Nicholas Piggin
2021-06-24 8:58 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 8:58 ` Nicholas Piggin
2021-06-24 8:58 ` Nicholas Piggin
2021-06-24 8:58 ` Nicholas Piggin
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:06 ` [Intel-gfx] " Marc Zyngier
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:06 ` Marc Zyngier
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:17 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:17 ` Paolo Bonzini
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 10:43 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 10:43 ` Nicholas Piggin
2021-06-24 3:57 ` [PATCH 4/6] KVM: arm64/mmu: " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 10:43 ` Marc Zyngier [this message]
2021-06-24 10:43 ` Marc Zyngier
2021-06-24 10:43 ` [Intel-gfx] " Marc Zyngier
2021-06-24 10:43 ` Marc Zyngier
2021-06-24 10:43 ` Marc Zyngier
2021-06-24 10:43 ` Marc Zyngier
2021-06-24 10:43 ` Marc Zyngier
2021-06-24 3:57 ` [PATCH 5/6] KVM: mmu: remove over-aggressive warnings David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [PATCH 6/6] drm/i915/gvt: use gfn_to_pfn's page instead of pfn David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` [Intel-gfx] " David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 3:57 ` David Stevens
2021-06-24 4:28 ` David Stevens
2021-06-24 4:28 ` David Stevens
2021-06-24 4:28 ` [Intel-gfx] " David Stevens
2021-06-24 4:28 ` David Stevens
2021-06-24 4:28 ` David Stevens
2021-06-24 4:28 ` David Stevens
2021-06-24 10:25 ` kernel test robot
2021-06-24 10:38 ` kernel test robot
2021-06-24 4:19 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for KVM: Remove uses of struct page from x86 and arm64 MMU Patchwork
2021-06-24 6:57 ` [PATCH 0/6] " Paolo Bonzini
2021-06-24 6:57 ` Paolo Bonzini
2021-06-24 6:57 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 6:57 ` Paolo Bonzini
2021-06-24 6:57 ` Paolo Bonzini
2021-06-24 6:57 ` Paolo Bonzini
2021-06-24 10:34 ` Nicholas Piggin
2021-06-24 10:34 ` Nicholas Piggin
2021-06-24 10:34 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 10:34 ` Nicholas Piggin
2021-06-24 10:34 ` Nicholas Piggin
2021-06-24 10:34 ` Nicholas Piggin
2021-06-24 11:42 ` Nicholas Piggin
2021-06-24 11:42 ` Nicholas Piggin
2021-06-24 11:42 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 11:42 ` Nicholas Piggin
2021-06-24 11:42 ` Nicholas Piggin
2021-06-24 11:42 ` Nicholas Piggin
2021-06-24 12:00 ` Paolo Bonzini
2021-06-24 12:00 ` Paolo Bonzini
2021-06-24 12:00 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 12:00 ` Paolo Bonzini
2021-06-24 12:00 ` Paolo Bonzini
2021-06-24 12:00 ` Paolo Bonzini
2021-06-24 12:41 ` Paolo Bonzini
2021-06-24 12:41 ` Paolo Bonzini
2021-06-24 12:41 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 12:41 ` Paolo Bonzini
2021-06-24 12:41 ` Paolo Bonzini
2021-06-24 12:41 ` Paolo Bonzini
2021-06-24 12:57 ` Nicholas Piggin
2021-06-24 12:57 ` Nicholas Piggin
2021-06-24 12:57 ` [Intel-gfx] " Nicholas Piggin
2021-06-24 12:57 ` Nicholas Piggin
2021-06-24 12:57 ` Nicholas Piggin
2021-06-24 12:57 ` Nicholas Piggin
2021-06-24 15:35 ` Paolo Bonzini
2021-06-24 15:35 ` Paolo Bonzini
2021-06-24 15:35 ` [Intel-gfx] " Paolo Bonzini
2021-06-24 15:35 ` Paolo Bonzini
2021-06-24 15:35 ` Paolo Bonzini
2021-06-24 15:35 ` Paolo Bonzini
2021-06-25 0:20 ` Nicholas Piggin
2021-06-25 0:20 ` Nicholas Piggin
2021-06-25 0:20 ` [Intel-gfx] " Nicholas Piggin
2021-06-25 0:20 ` Nicholas Piggin
2021-06-25 0:20 ` Nicholas Piggin
2021-06-25 0:20 ` Nicholas Piggin
2021-06-25 7:44 ` Christian Borntraeger
2021-06-25 7:44 ` Christian Borntraeger
2021-06-25 7:44 ` [Intel-gfx] " Christian Borntraeger
2021-06-25 7:44 ` Christian Borntraeger
2021-06-25 7:44 ` Christian Borntraeger
2021-06-25 7:44 ` Christian Borntraeger
2021-06-24 16:07 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for KVM: Remove uses of struct page from x86 and arm64 MMU (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf6zilvc.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alexandru.elisei@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=stevensd@chromium.org \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.