Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU

From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Robert Marko <robert.marko@sartura.hr>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
	kostap@marvell.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
Date: Tue, 30 Aug 2022 09:42:00 +0200	[thread overview]
Message-ID: <87mtbm5gaf.fsf@BL-laptop> (raw)
In-Reply-To: <CA+HBbNF2R--984SdB0v42GMQOwAx4pTEz_FHifTtebN05ELU-Q@mail.gmail.com>

Robert Marko <robert.marko@sartura.hr> writes:

> On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
>>
>> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
>>
>> They feature the same CPU, RAM, and storage as well as the form factor.
>>
>> However, eDPU only has one SFP slot plus a copper G.hn port.
>>
>> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Changes in v2:
>> * Make the DTS split a separate commit
>> ---
>>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
>>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
>>  2 files changed, 15 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>>
>> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>> index 1c794cdcb8e6..104d7d7e8215 100644
>> --- a/arch/arm64/boot/dts/marvell/Makefile
>> +++ b/arch/arm64/boot/dts/marvell/Makefile
>> @@ -1,6 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  # Mvebu SoC Family
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
>> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> new file mode 100644
>> index 000000000000..57fc698e55d0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> @@ -0,0 +1,14 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +/dts-v1/;
>> +
>> +#include "armada-3720-uDPU.dtsi"
>> +
>> +/ {
>> +       model = "Methode eDPU Board";
>> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
>> +};
>> +
>> +&eth0 {
>> +       phy-mode = "2500base-x";
>> +};
>> --
>> 2.36.1
>>
>
> Hi Gregory,
Hello Roberto,

> Is there something else that I can improve in the series?

Sorry for having missed this series. At first view it seems OK, I am
going to have a closer look this week.

Gregory

>
> Regards,
> Robert
>
> -- 
> Robert Marko
> Staff Embedded Linux Engineer
> Sartura Ltd.
> Lendavska ulica 16a
> 10000 Zagreb, Croatia
> Email: robert.marko@sartura.hr
> Web: www.sartura.hr

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com