From: Andreas Schwab <schwab@linux-m68k.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Marko Myllynen <myllynen@redhat.com>,
linux-fbdev@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Steven Rostedt <rostedt@goodmis.org>,
Yisheng Xie <ysxie@foxmail.com>,
Hans de Goede <hdegoede@redhat.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots
Date: Tue, 02 Apr 2019 17:45:44 +0000 [thread overview]
Message-ID: <87mul8pagn.fsf@igel.home> (raw)
In-Reply-To: <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> (Prarit Bhargava's message of "Tue, 2 Apr 2019 07:31:49 -0400")
On Apr 02 2019, Prarit Bhargava <prarit@redhat.com> wrote:
> On 4/1/19 3:31 PM, Andreas Schwab wrote:
>> On Jan 29 2019, Prarit Bhargava <prarit@redhat.com> wrote:
>>
>>> @@ -1066,6 +1069,9 @@ static void fbcon_init(struct vc_data *vc, int init)
>>>
>>> cap = info->flags;
>>>
>>> + if (console_loglevel <= CONSOLE_LOGLEVEL_QUIET)
>>> + logo_shown = FBCON_LOGO_DONTSHOW;
>>> +
>>> if (vc != svc || logo_shown = FBCON_LOGO_DONTSHOW ||
>>> (info->fix.type = FB_TYPE_TEXT))
>>> logo = 0;
>>
>> This causes the scroll region to no longer be reset when the logo is
>> removed.
>>
>
> Andreas, my apologies but I'm not sure what you mean. Could you elaborate on
> the broken and expected behaviour?
If fbcon_init is called after the loglevel is reduced to
CONSOLE_LOGLEVEL_QUIET, the logo is not drawn, but the scrolling region
remains.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Marko Myllynen <myllynen@redhat.com>,
linux-fbdev@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Steven Rostedt <rostedt@goodmis.org>,
Yisheng Xie <ysxie@foxmail.com>,
Hans de Goede <hdegoede@redhat.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots
Date: Tue, 02 Apr 2019 19:45:44 +0200 [thread overview]
Message-ID: <87mul8pagn.fsf@igel.home> (raw)
In-Reply-To: <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> (Prarit Bhargava's message of "Tue, 2 Apr 2019 07:31:49 -0400")
On Apr 02 2019, Prarit Bhargava <prarit@redhat.com> wrote:
> On 4/1/19 3:31 PM, Andreas Schwab wrote:
>> On Jan 29 2019, Prarit Bhargava <prarit@redhat.com> wrote:
>>
>>> @@ -1066,6 +1069,9 @@ static void fbcon_init(struct vc_data *vc, int init)
>>>
>>> cap = info->flags;
>>>
>>> + if (console_loglevel <= CONSOLE_LOGLEVEL_QUIET)
>>> + logo_shown = FBCON_LOGO_DONTSHOW;
>>> +
>>> if (vc != svc || logo_shown == FBCON_LOGO_DONTSHOW ||
>>> (info->fix.type == FB_TYPE_TEXT))
>>> logo = 0;
>>
>> This causes the scroll region to no longer be reset when the logo is
>> removed.
>>
>
> Andreas, my apologies but I'm not sure what you mean. Could you elaborate on
> the broken and expected behaviour?
If fbcon_init is called after the loglevel is reduced to
CONSOLE_LOGLEVEL_QUIET, the logo is not drawn, but the scrolling region
remains.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-02 17:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190129134418epcas3p12a932e3d400600ac92ecf268f7bc4a38@epcas3p1.samsung.com>
2019-01-29 13:43 ` [PATCH v5 0/2] Do not output logo on quiet boots Prarit Bhargava
2019-01-29 13:43 ` Prarit Bhargava
2019-01-29 13:43 ` [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots Prarit Bhargava
2019-01-29 13:43 ` Prarit Bhargava
2019-04-01 19:31 ` Andreas Schwab
2019-04-01 19:31 ` Andreas Schwab
2019-04-02 11:31 ` Prarit Bhargava
2019-04-02 11:31 ` Prarit Bhargava
2019-04-02 17:45 ` Andreas Schwab [this message]
2019-04-02 17:45 ` Andreas Schwab
2019-04-02 18:09 ` [PATCH] fbcon: Don't reset logo_shown when logo is currently shown Andreas Schwab
2019-04-02 18:09 ` Andreas Schwab
2019-05-06 13:32 ` Bartlomiej Zolnierkiewicz
2019-05-06 13:32 ` Bartlomiej Zolnierkiewicz
2019-02-08 18:02 ` [PATCH v5 0/2] Do not output logo on quiet boots Bartlomiej Zolnierkiewicz
2019-02-08 18:02 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mul8pagn.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=myllynen@redhat.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=treding@nvidia.com \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.