From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v4 4/4] qapi: update pylint configuration
Date: Sat, 04 Feb 2023 12:34:54 +0100 [thread overview]
Message-ID: <87o7q97jfl.fsf@pond.sub.org> (raw)
In-Reply-To: <20230203184733.523522-5-jsnow@redhat.com> (John Snow's message of "Fri, 3 Feb 2023 13:47:33 -0500")
John Snow <jsnow@redhat.com> writes:
> Newer versions of pylint disable the "no-self-use" message by
> default. Older versions don't, though. If we leave the suppressions in,
> pylint yelps about useless options. Just tell pylint to shush.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qapi/pylintrc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
> index a7246282030..90546df5345 100644
> --- a/scripts/qapi/pylintrc
> +++ b/scripts/qapi/pylintrc
> @@ -23,6 +23,7 @@ disable=fixme,
> too-many-statements,
> too-many-instance-attributes,
> consider-using-f-string,
> + useless-option-value,
>
> [REPORTS]
Pylint docs[*] explains this is "used when a value for an option that is
now deleted from pylint is encountered." Switching that off makes sense
when you have to deal with a range of versions. Occasional garbage
collection of old options is advised :)
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[*] https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/useless-option-value.html
next prev parent reply other threads:[~2023-02-04 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 18:47 [PATCH v4 0/4] [DO-NOT-MERGE] qapi: static typing conversion, "pt0" John Snow
2023-02-03 18:47 ` [PATCH v4 1/4] [DO-NOT-MERGE] docs: enable sphinx-autodoc for scripts/qapi John Snow
2023-02-03 18:47 ` [PATCH v4 2/4] [DO-NOT-MERGE]: Add some ad-hoc linting helpers John Snow
2023-02-03 18:47 ` [PATCH v4 3/4] qapi: Update flake8 config John Snow
2023-02-04 11:24 ` Markus Armbruster
2023-02-03 18:47 ` [PATCH v4 4/4] qapi: update pylint configuration John Snow
2023-02-04 11:34 ` Markus Armbruster [this message]
2023-02-06 15:59 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7q97jfl.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.