Re: [PATCH v4 4/4] qapi: update pylint configuration

From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v4 4/4] qapi: update pylint configuration
Date: Mon, 6 Feb 2023 10:59:28 -0500	[thread overview]
Message-ID: <CAFn=p-bk-YQ-HwKVdQ44nxeE=0kMr8z0VDTcJV6=0_W7mu3X6w@mail.gmail.com> (raw)
In-Reply-To: <87o7q97jfl.fsf@pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Sat, Feb 4, 2023, 6:34 AM Markus Armbruster <armbru@redhat.com> wrote:

> John Snow <jsnow@redhat.com> writes:
>
> > Newer versions of pylint disable the "no-self-use" message by
> > default. Older versions don't, though. If we leave the suppressions in,
> > pylint yelps about useless options. Just tell pylint to shush.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >  scripts/qapi/pylintrc | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
> > index a7246282030..90546df5345 100644
> > --- a/scripts/qapi/pylintrc
> > +++ b/scripts/qapi/pylintrc
> > @@ -23,6 +23,7 @@ disable=fixme,
> >          too-many-statements,
> >          too-many-instance-attributes,
> >          consider-using-f-string,
> > +        useless-option-value,
> >
> >  [REPORTS]
>
> Pylint docs[*] explains this is "used when a value for an option that is
> now deleted from pylint is encountered."  Switching that off makes sense
> when you have to deal with a range of versions.  Occasional garbage
> collection of old options is advised :)
>

Indeed.

For the purposes of CI and repeatability (and maintainer happiness), it'd
be nice to just enforce specific, explicit versions.

For the purposes of developer happiness, I'm willing to accept *some* pain
in supporting a range of versions for the tools.

I'm anticipating re-evaluating suppressions and workarounds when 3.6 gets
dropped.

--js

> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
>
> [*]
> https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/useless-option-value.html
>
>

[-- Attachment #2: Type: text/html, Size: 2914 bytes --]