From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] ASoC: rsnd: add null CLOCKIN support
Date: 27 May 2021 07:06:19 +0900 [thread overview]
Message-ID: <87o8cxm9pg.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdVhnKeztftOJEZhSg8bXArzUDXAmHSMPVfbMamV3ihw+g@mail.gmail.com>
Hi Geert
> Oh right, I missed the static clk_hw pointer.
> What if you unload the snd-soc-rcar.ko module?
Hmm.. indeed.
It needs something..
Thank you for poining it.
> #define for_each_rsnd_clk(pos, adg, i) \
> for (i = 0; (pos) = adg->clk[i], i < CLKMAX; i++) \
> if (pos) { \
> continue; \
> } else
Wow!! I didn't know this technique.
Indeed it can use NULL pointer.
But, I want to avoid "if (pos) else" code as much as possible,
and keep simple code.
It can handle all clk case without thinking it if it has null_clk.
Why you don't want null_clk ??
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 3/3] ASoC: rsnd: add null CLOCKIN support
Date: 27 May 2021 07:06:19 +0900 [thread overview]
Message-ID: <87o8cxm9pg.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdVhnKeztftOJEZhSg8bXArzUDXAmHSMPVfbMamV3ihw+g@mail.gmail.com>
Hi Geert
> Oh right, I missed the static clk_hw pointer.
> What if you unload the snd-soc-rcar.ko module?
Hmm.. indeed.
It needs something..
Thank you for poining it.
> #define for_each_rsnd_clk(pos, adg, i) \
> for (i = 0; (pos) = adg->clk[i], i < CLKMAX; i++) \
> if (pos) { \
> continue; \
> } else
Wow!! I didn't know this technique.
Indeed it can use NULL pointer.
But, I want to avoid "if (pos) else" code as much as possible,
and keep simple code.
It can handle all clk case without thinking it if it has null_clk.
Why you don't want null_clk ??
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2021-05-26 22:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 6:11 [PATCH 0/3] ASoC: rsnd: add D3 support Kuninori Morimoto
2021-05-24 6:11 ` Kuninori Morimoto
2021-05-24 6:12 ` [PATCH 1/3] ASoC: dt-bindings: renesas: rsnd: tidyup properties Kuninori Morimoto
2021-05-24 6:12 ` Kuninori Morimoto
2021-05-24 6:12 ` [PATCH 2/3] ASoC: rsnd: tidyup loop on rsnd_adg_clk_query() Kuninori Morimoto
2021-05-24 6:12 ` Kuninori Morimoto
2021-05-24 6:12 ` [PATCH 3/3] ASoC: rsnd: add null CLOCKIN support Kuninori Morimoto
2021-05-24 6:12 ` Kuninori Morimoto
2021-05-25 10:31 ` Geert Uytterhoeven
2021-05-25 10:31 ` Geert Uytterhoeven
2021-05-25 22:48 ` Kuninori Morimoto
2021-05-25 22:48 ` Kuninori Morimoto
2021-05-26 6:58 ` Geert Uytterhoeven
2021-05-26 6:58 ` Geert Uytterhoeven
2021-05-26 22:06 ` Kuninori Morimoto [this message]
2021-05-26 22:06 ` Kuninori Morimoto
2021-05-27 7:30 ` Geert Uytterhoeven
2021-05-27 7:30 ` Geert Uytterhoeven
2021-05-27 9:48 ` Mark Brown
2021-05-27 9:48 ` Mark Brown
2021-05-24 11:59 ` [PATCH 0/3] ASoC: rsnd: add D3 support Mark Brown
2021-05-24 11:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8cxm9pg.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.