From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
akpm@linux-foundation.org
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Oliver O'Halloran <oohall@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Paul Mackerras <paulus@samba.org>,
dja@axtens.net, Steven Price <steven.price@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables
Date: Sat, 26 Jun 2021 09:46:47 +1000 [thread overview]
Message-ID: <87pmw9zevs.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <217a6b38-a6ac-84d5-e3dc-257331431bb2@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 25/06/2021 à 06:45, Michael Ellerman a écrit :
>> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>>> Hi Michael,
>>>
>>> Le 19/04/2021 à 12:47, Christophe Leroy a écrit :
>>>> Pagewalk ignores hugepd entries and walk down the tables
>>>> as if it was traditionnal entries, leading to crazy result.
>>>>
>>>> Add walk_hugepd_range() and use it to walk hugepage tables.
>>>
>>> I see you took patch 2 and 3 of the series.
>>
>> Yeah I decided those were bug fixes so could be taken separately.
>>
>>> Do you expect Andrew to take patch 1 via mm tree, and then you'll take
>>> patch 4 once mm tree is merged ?
>>
>> I didn't feel I could take patch 1 via the powerpc tree without risking
>> conflicts.
>>
>> Andrew could take patch 1 and 4 via mm, though he might not want to pick
>> them up this late.
>
> Patch 4 needs patches 2 and 3 and doesn't apply without them so it is not that easy.
Ah duh, sorry.
> Maybe Andrew you can take patch 1 now and then Michael you can take patch 4 at anytime during 5.15
> preparation without any conflict risk ?
Yeah that would work.
>> I guess step one would be to repost 1 and 4 as a new series. Either they
>> can go via mm, or for 5.15 I could probably take them both as long as I
>> pick them up early enough.
>>
>
> I'll first repost patch 1 as standalone and see what happens.
Thanks.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
akpm@linux-foundation.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Steven Price <steven.price@arm.com>,
linux-mm@kvack.org, Oliver O'Halloran <oohall@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, dja@axtens.net
Subject: Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables
Date: Sat, 26 Jun 2021 09:46:47 +1000 [thread overview]
Message-ID: <87pmw9zevs.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <217a6b38-a6ac-84d5-e3dc-257331431bb2@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 25/06/2021 à 06:45, Michael Ellerman a écrit :
>> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>>> Hi Michael,
>>>
>>> Le 19/04/2021 à 12:47, Christophe Leroy a écrit :
>>>> Pagewalk ignores hugepd entries and walk down the tables
>>>> as if it was traditionnal entries, leading to crazy result.
>>>>
>>>> Add walk_hugepd_range() and use it to walk hugepage tables.
>>>
>>> I see you took patch 2 and 3 of the series.
>>
>> Yeah I decided those were bug fixes so could be taken separately.
>>
>>> Do you expect Andrew to take patch 1 via mm tree, and then you'll take
>>> patch 4 once mm tree is merged ?
>>
>> I didn't feel I could take patch 1 via the powerpc tree without risking
>> conflicts.
>>
>> Andrew could take patch 1 and 4 via mm, though he might not want to pick
>> them up this late.
>
> Patch 4 needs patches 2 and 3 and doesn't apply without them so it is not that easy.
Ah duh, sorry.
> Maybe Andrew you can take patch 1 now and then Michael you can take patch 4 at anytime during 5.15
> preparation without any conflict risk ?
Yeah that would work.
>> I guess step one would be to repost 1 and 4 as a new series. Either they
>> can go via mm, or for 5.15 I could probably take them both as long as I
>> pick them up early enough.
>>
>
> I'll first repost patch 1 as standalone and see what happens.
Thanks.
cheers
next prev parent reply other threads:[~2021-06-25 23:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:47 [PATCH v2 0/4] Convert powerpc to GENERIC_PTDUMP Christophe Leroy
2021-04-19 10:47 ` Christophe Leroy
2021-04-19 10:47 ` [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables Christophe Leroy
2021-04-19 10:47 ` Christophe Leroy
2021-04-19 14:07 ` Steven Price
2021-04-19 14:07 ` Steven Price
2021-06-24 19:24 ` Christophe Leroy
2021-06-24 19:24 ` Christophe Leroy
2021-06-25 4:45 ` Michael Ellerman
2021-06-25 4:45 ` Michael Ellerman
2021-06-25 4:56 ` Christophe Leroy
2021-06-25 4:56 ` Christophe Leroy
2021-06-25 23:46 ` Michael Ellerman [this message]
2021-06-25 23:46 ` Michael Ellerman
2021-04-19 10:47 ` [PATCH v2 2/4] powerpc/mm: Leave a gap between early allocated IO areas Christophe Leroy
2021-04-19 10:47 ` Christophe Leroy
2021-04-19 10:47 ` [PATCH v2 3/4] powerpc/mm: Properly coalesce pages in ptdump Christophe Leroy
2021-04-19 10:47 ` Christophe Leroy
2021-04-19 10:47 ` [PATCH v2 4/4] powerpc/mm: Convert powerpc to GENERIC_PTDUMP Christophe Leroy
2021-04-19 10:47 ` Christophe Leroy
2021-06-26 10:37 ` [PATCH v2 0/4] " Michael Ellerman
2021-06-26 10:37 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmw9zevs.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dja@axtens.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.