From: Michael Ellerman <mpe@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>,
Haren Myneni <haren@linux.ibm.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: haren@us.ibm.com, hbabu@us.ibm.com
Subject: Re: [PATCH V3 02/16] powerpc/vas: Move VAS API to common book3s platform
Date: Tue, 11 May 2021 11:50:11 +1000 [thread overview]
Message-ID: <87pmxyxcmk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1620623481.kmr54zmxzv.astroid@bobo.none>
Nicholas Piggin <npiggin@gmail.com> writes:
> Excerpts from Haren Myneni's message of April 18, 2021 7:02 am:
>>
>> Using the same /dev/crypto/nx-gzip interface for both powerNV and
>> pseries.
>
> The pseries NX driver will use the powernv VAS API ?
>
>> So this patch creates platforms/book3s/ and moves VAS API
>> to that directory. The actual functionality is not changed.
>>
>> Common interface functions such as open, window open ioctl, mmap
>> and close are moved to arch/powerpc/platforms/book3s/vas-api.c
>> Added hooks to call platform specific code, but the underline
>> powerNV code in these functions is not changed.
>
> Even so, could you do one patch that just moves, and another that
> adds the ops struct?
>
>>
>> Signed-off-by: Haren Myneni <haren@linux.ibm.com>
>> ---
>> arch/powerpc/include/asm/vas.h | 22 ++++++-
>> arch/powerpc/platforms/Kconfig | 1 +
>> arch/powerpc/platforms/Makefile | 1 +
>> arch/powerpc/platforms/book3s/Kconfig | 15 +++++
>> arch/powerpc/platforms/book3s/Makefile | 2 +
>
> The usual place for these would be arch/powerpc/sysdev/vas. E.g., see
> arch/powerpc/sysdev/xive.
You're right that is the usual place, but is it a good place? :)
Using platforms/book3s was my suggestion:
https://lore.kernel.org/linuxppc-dev/87k0p6s5lo.fsf@mpe.ellerman.id.au/
But I don't feel that strongly about it, maybe just dumping things in
sysdev is easier.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>,
Haren Myneni <haren@linux.ibm.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 02/16] powerpc/vas: Move VAS API to common book3s platform
Date: Tue, 11 May 2021 11:50:11 +1000 [thread overview]
Message-ID: <87pmxyxcmk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1620623481.kmr54zmxzv.astroid@bobo.none>
Nicholas Piggin <npiggin@gmail.com> writes:
> Excerpts from Haren Myneni's message of April 18, 2021 7:02 am:
>>
>> Using the same /dev/crypto/nx-gzip interface for both powerNV and
>> pseries.
>
> The pseries NX driver will use the powernv VAS API ?
>
>> So this patch creates platforms/book3s/ and moves VAS API
>> to that directory. The actual functionality is not changed.
>>
>> Common interface functions such as open, window open ioctl, mmap
>> and close are moved to arch/powerpc/platforms/book3s/vas-api.c
>> Added hooks to call platform specific code, but the underline
>> powerNV code in these functions is not changed.
>
> Even so, could you do one patch that just moves, and another that
> adds the ops struct?
>
>>
>> Signed-off-by: Haren Myneni <haren@linux.ibm.com>
>> ---
>> arch/powerpc/include/asm/vas.h | 22 ++++++-
>> arch/powerpc/platforms/Kconfig | 1 +
>> arch/powerpc/platforms/Makefile | 1 +
>> arch/powerpc/platforms/book3s/Kconfig | 15 +++++
>> arch/powerpc/platforms/book3s/Makefile | 2 +
>
> The usual place for these would be arch/powerpc/sysdev/vas. E.g., see
> arch/powerpc/sysdev/xive.
You're right that is the usual place, but is it a good place? :)
Using platforms/book3s was my suggestion:
https://lore.kernel.org/linuxppc-dev/87k0p6s5lo.fsf@mpe.ellerman.id.au/
But I don't feel that strongly about it, maybe just dumping things in
sysdev is easier.
cheers
next prev parent reply other threads:[~2021-05-11 1:50 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 20:52 [V3 PATCH 00/16] Enable VAS and NX-GZIP support on powerVM Haren Myneni
2021-04-17 20:52 ` Haren Myneni
2021-04-17 21:00 ` [V3 PATCH 01/16] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni
2021-04-17 21:00 ` Haren Myneni
2021-05-10 5:10 ` Nicholas Piggin
2021-05-10 5:10 ` Nicholas Piggin
2021-05-10 16:59 ` Haren Myneni
2021-05-10 16:59 ` Haren Myneni
2021-04-17 21:02 ` [PATCH V3 02/16] powerpc/vas: Move VAS API to common book3s platform Haren Myneni
2021-04-17 21:02 ` Haren Myneni
2021-05-10 5:19 ` Nicholas Piggin
2021-05-10 5:19 ` Nicholas Piggin
2021-05-10 17:12 ` Haren Myneni
2021-05-10 17:12 ` Haren Myneni
2021-05-11 1:50 ` Michael Ellerman [this message]
2021-05-11 1:50 ` Michael Ellerman
2021-04-17 21:03 ` [V3 PATCH 03/16] powerpc/vas: Create take/drop task reference functions Haren Myneni
2021-04-17 21:03 ` Haren Myneni
2021-05-10 5:28 ` Nicholas Piggin
2021-05-10 5:28 ` Nicholas Piggin
2021-05-10 20:32 ` Haren Myneni
2021-05-10 20:32 ` Haren Myneni
2021-04-17 21:03 ` [V3 PATCH 04/16] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni
2021-04-17 21:03 ` Haren Myneni
2021-05-10 5:37 ` Nicholas Piggin
2021-05-10 5:37 ` Nicholas Piggin
2021-04-17 21:04 ` [V3 PATCH 05/16] powerpc/vas: Define and use common vas_window struct Haren Myneni
2021-04-17 21:04 ` Haren Myneni
2021-05-10 5:37 ` Nicholas Piggin
2021-05-10 5:37 ` Nicholas Piggin
2021-05-10 17:02 ` Haren Myneni
2021-05-10 17:02 ` Haren Myneni
2021-04-17 21:05 ` [V3 PATCH 06/16] powerpc/pseries/vas: Define VAS/NXGZIP HCALLs and structs Haren Myneni
2021-04-17 21:05 ` Haren Myneni
2021-05-10 5:49 ` Nicholas Piggin
2021-05-10 5:49 ` Nicholas Piggin
2021-05-11 2:18 ` Haren Myneni
2021-05-11 2:18 ` Haren Myneni
2021-04-17 21:06 ` [V3 PATCH 07/16] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni
2021-04-17 21:06 ` Haren Myneni
2021-05-10 5:54 ` Nicholas Piggin
2021-05-10 5:54 ` Nicholas Piggin
2021-05-11 2:12 ` Haren Myneni
2021-05-11 2:12 ` Haren Myneni
2021-04-17 21:07 ` [V3 PATCH 08/16] powerpc/pseries/VAS: Implement allocate/modify/deallocate HCALLS Haren Myneni
2021-04-17 21:07 ` Haren Myneni
2021-05-10 6:01 ` Nicholas Piggin
2021-05-10 6:01 ` Nicholas Piggin
2021-04-17 21:08 ` [V3 PATCH 09/16] powerpc/pseries/vas: Implement to get all capabilities Haren Myneni
2021-04-17 21:08 ` Haren Myneni
2021-05-10 6:13 ` Nicholas Piggin
2021-05-10 6:13 ` Nicholas Piggin
2021-05-11 2:08 ` Haren Myneni
2021-05-11 2:08 ` Haren Myneni
2021-04-17 21:08 ` [V3 PATCH 10/16] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni
2021-04-17 21:08 ` Haren Myneni
2021-05-10 6:18 ` Nicholas Piggin
2021-05-10 6:18 ` Nicholas Piggin
2021-05-10 6:28 ` Nicholas Piggin
2021-05-10 6:28 ` Nicholas Piggin
2021-04-17 21:09 ` [V3 PATCH 11/16] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni
2021-04-17 21:09 ` Haren Myneni
2021-04-17 21:10 ` [V3 PATCH 12/16] powerpc/pseries/vas: sysfs interface to export capabilities Haren Myneni
2021-04-17 21:10 ` Haren Myneni
2021-05-10 6:34 ` Nicholas Piggin
2021-05-10 6:34 ` Nicholas Piggin
2021-05-10 20:52 ` Haren Myneni
2021-05-10 20:52 ` Haren Myneni
2021-04-17 21:11 ` [V3 PATCH 13/16] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni
2021-04-17 21:11 ` Haren Myneni
2021-04-22 6:55 ` Herbert Xu
2021-04-22 6:55 ` Herbert Xu
2021-04-17 21:12 ` [V3 PATCH 14/16] crypto/nx: Register and unregister VAS interface Haren Myneni
2021-04-17 21:12 ` Haren Myneni
2021-04-22 6:56 ` Herbert Xu
2021-04-22 6:56 ` Herbert Xu
2021-04-17 21:12 ` [V3 PATCH 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni
2021-04-17 21:12 ` Haren Myneni
2021-04-22 6:56 ` Herbert Xu
2021-04-22 6:56 ` Herbert Xu
2021-05-10 6:38 ` Nicholas Piggin
2021-05-10 6:38 ` Nicholas Piggin
2021-05-10 20:44 ` Haren Myneni
2021-05-10 20:44 ` Haren Myneni
2021-04-17 21:13 ` [V3 PATCH 16/16] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni
2021-04-17 21:13 ` Haren Myneni
2021-04-22 6:56 ` Herbert Xu
2021-04-22 6:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmxyxcmk.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=haren@linux.ibm.com \
--cc=haren@us.ibm.com \
--cc=hbabu@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.