From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Liu CF/TW <cfliu.tw@gmail.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Michal Kazior <michal.kazior@tieto.com>
Subject: Re: [PATCH v4] ath10k: enable raw encap mode and software crypto engine.
Date: Fri, 24 Jul 2015 20:29:39 +0300 [thread overview]
Message-ID: <87pp3hbh18.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1434138966-3652-1-git-send-email-cfliu.tw@gmail.com> (Liu CF's message of "Fri, 12 Jun 2015 12:56:06 -0700")
Liu CF/TW <cfliu.tw@gmail.com> writes:
> From: David Liu <cfliu.tw@gmail.com>
>
> This patch enables raw Rx/Tx encap mode to support software based
> crypto engine. This patch introduces a new module param 'cryptmode'.
>
> cryptmode:
>
> 0: Use hardware crypto engine globally with native Wi-Fi mode TX/RX
> encapsulation to the firmware. This is the default mode.
> 1: Use sofware crypto engine globally with raw mode TX/RX
> encapsulation to the firmware.
>
> Known limitation:
> A-MSDU must be disabled for RAW Tx encap mode to perform well when
> heavy traffic is applied.
>
> Testing: (by Michal Kazior <michal.kazior@tieto.com>)
>
> a) Performance Testing
>
> cryptmode=1
> ap=qca988x sta=killer1525
> killer1525 -> qca988x 194.496 mbps [tcp1 ip4]
> killer1525 -> qca988x 238.309 mbps [tcp5 ip4]
> killer1525 -> qca988x 266.958 mbps [udp1 ip4]
> killer1525 -> qca988x 477.468 mbps [udp5 ip4]
> qca988x -> killer1525 301.378 mbps [tcp1 ip4]
> qca988x -> killer1525 297.949 mbps [tcp5 ip4]
> qca988x -> killer1525 331.351 mbps [udp1 ip4]
> qca988x -> killer1525 371.528 mbps [udp5 ip4]
> ap=killer1525 sta=qca988x
> qca988x -> killer1525 331.447 mbps [tcp1 ip4]
> qca988x -> killer1525 328.783 mbps [tcp5 ip4]
> qca988x -> killer1525 375.309 mbps [udp1 ip4]
> qca988x -> killer1525 403.379 mbps [udp5 ip4]
> killer1525 -> qca988x 203.689 mbps [tcp1 ip4]
> killer1525 -> qca988x 222.339 mbps [tcp5 ip4]
> killer1525 -> qca988x 264.199 mbps [udp1 ip4]
> killer1525 -> qca988x 479.371 mbps [udp5 ip4]
>
> Note:
> - only open network tested for RAW vs nwifi performance comparison
> - killer1525 (qca6174 hw2.2) is 2x2 device (hence max 866mbps)
> - used iperf
> - OTA, devices a few cm apart from each other, no shielding
> - tcpX/udpX, X - means number of threads used
>
> Overview:
> - relative Tx performance drop is seen but is within reasonable and
> expected threshold (A-MSDU must be disabled with RAW Tx)
>
> b) Connectivity Testing
>
> cryptmode=1
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta2br1vlan OK
>
> Note:
> - each test takes all possible endpoint pairs and pings
> - each pair-ping flushes arp table
> - ip6 is used
>
> c) Testbed Topology:
>
> 1ap1sta:
> [ap] ---- [sta]
>
> endpoints: ap, sta
>
> 1ap1sta2br:
> [veth0] [ap] ---- [sta] [veth2]
> | | | |
> [veth1] | \ [veth3]
> \ / \ /
> [br0] [br1]
>
> endpoints: veth0, veth2, br0, br1
> note: STA works in 4addr mode, AP has wds_sta=1
>
> 1ap1sta2br1vlan:
> [veth0] [ap] ---- [sta] [veth2]
> | | | |
> [veth1] | \ [veth3]
> \ / \ /
> [br0] [br1]
> | |
> [vlan0_id2] [vlan1_id2]
>
> endpoints: vlan0_id2, vlan1_id2
> note: STA works in 4addr mode, AP has wds_sta=1
>
> Credits:
>
> Thanks to Michal Kazior <michal.kazior@tieto.com> who helped find the
> amsdu issue, contributed a workaround (already squashed into this
> patch), and contributed the throughput and connectivity tests results.
>
> Signed-off-by: David Liu <cfliu.tw@gmail.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> Tested-by: Michal Kazior <michal.kazior@tieto.com>
Sorry for taking so long with the review and testing, this got delayed
because of my vacation. I now rebased the patch to the pending branch
and fixed conflicts. Please review carefully my changes:
https://github.com/kvalo/ath/commit/8f30e155b942cc712afe9ec80b463f923e7c2700
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Liu CF/TW <cfliu.tw@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Michal Kazior <michal.kazior@tieto.com>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v4] ath10k: enable raw encap mode and software crypto engine.
Date: Fri, 24 Jul 2015 20:29:39 +0300 [thread overview]
Message-ID: <87pp3hbh18.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1434138966-3652-1-git-send-email-cfliu.tw@gmail.com> (Liu CF's message of "Fri, 12 Jun 2015 12:56:06 -0700")
Liu CF/TW <cfliu.tw@gmail.com> writes:
> From: David Liu <cfliu.tw@gmail.com>
>
> This patch enables raw Rx/Tx encap mode to support software based
> crypto engine. This patch introduces a new module param 'cryptmode'.
>
> cryptmode:
>
> 0: Use hardware crypto engine globally with native Wi-Fi mode TX/RX
> encapsulation to the firmware. This is the default mode.
> 1: Use sofware crypto engine globally with raw mode TX/RX
> encapsulation to the firmware.
>
> Known limitation:
> A-MSDU must be disabled for RAW Tx encap mode to perform well when
> heavy traffic is applied.
>
> Testing: (by Michal Kazior <michal.kazior@tieto.com>)
>
> a) Performance Testing
>
> cryptmode=1
> ap=qca988x sta=killer1525
> killer1525 -> qca988x 194.496 mbps [tcp1 ip4]
> killer1525 -> qca988x 238.309 mbps [tcp5 ip4]
> killer1525 -> qca988x 266.958 mbps [udp1 ip4]
> killer1525 -> qca988x 477.468 mbps [udp5 ip4]
> qca988x -> killer1525 301.378 mbps [tcp1 ip4]
> qca988x -> killer1525 297.949 mbps [tcp5 ip4]
> qca988x -> killer1525 331.351 mbps [udp1 ip4]
> qca988x -> killer1525 371.528 mbps [udp5 ip4]
> ap=killer1525 sta=qca988x
> qca988x -> killer1525 331.447 mbps [tcp1 ip4]
> qca988x -> killer1525 328.783 mbps [tcp5 ip4]
> qca988x -> killer1525 375.309 mbps [udp1 ip4]
> qca988x -> killer1525 403.379 mbps [udp5 ip4]
> killer1525 -> qca988x 203.689 mbps [tcp1 ip4]
> killer1525 -> qca988x 222.339 mbps [tcp5 ip4]
> killer1525 -> qca988x 264.199 mbps [udp1 ip4]
> killer1525 -> qca988x 479.371 mbps [udp5 ip4]
>
> Note:
> - only open network tested for RAW vs nwifi performance comparison
> - killer1525 (qca6174 hw2.2) is 2x2 device (hence max 866mbps)
> - used iperf
> - OTA, devices a few cm apart from each other, no shielding
> - tcpX/udpX, X - means number of threads used
>
> Overview:
> - relative Tx performance drop is seen but is within reasonable and
> expected threshold (A-MSDU must be disabled with RAW Tx)
>
> b) Connectivity Testing
>
> cryptmode=1
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta OK
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta2br OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta2br OK
> ap=iwl6205 sta1=qca988x crypto=open topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wep1 topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wpa topology-1ap1sta2br1vlan OK
> ap=iwl6205 sta1=qca988x crypto=wpa-ccmp topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=open topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wep1 topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wpa topology-1ap1sta2br1vlan OK
> ap=qca988x sta1=iwl6205 crypto=wpa-ccmp topology-1ap1sta2br1vlan OK
>
> Note:
> - each test takes all possible endpoint pairs and pings
> - each pair-ping flushes arp table
> - ip6 is used
>
> c) Testbed Topology:
>
> 1ap1sta:
> [ap] ---- [sta]
>
> endpoints: ap, sta
>
> 1ap1sta2br:
> [veth0] [ap] ---- [sta] [veth2]
> | | | |
> [veth1] | \ [veth3]
> \ / \ /
> [br0] [br1]
>
> endpoints: veth0, veth2, br0, br1
> note: STA works in 4addr mode, AP has wds_sta=1
>
> 1ap1sta2br1vlan:
> [veth0] [ap] ---- [sta] [veth2]
> | | | |
> [veth1] | \ [veth3]
> \ / \ /
> [br0] [br1]
> | |
> [vlan0_id2] [vlan1_id2]
>
> endpoints: vlan0_id2, vlan1_id2
> note: STA works in 4addr mode, AP has wds_sta=1
>
> Credits:
>
> Thanks to Michal Kazior <michal.kazior@tieto.com> who helped find the
> amsdu issue, contributed a workaround (already squashed into this
> patch), and contributed the throughput and connectivity tests results.
>
> Signed-off-by: David Liu <cfliu.tw@gmail.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> Tested-by: Michal Kazior <michal.kazior@tieto.com>
Sorry for taking so long with the review and testing, this got delayed
because of my vacation. I now rebased the patch to the pending branch
and fixed conflicts. Please review carefully my changes:
https://github.com/kvalo/ath/commit/8f30e155b942cc712afe9ec80b463f923e7c2700
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-07-24 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 19:56 [PATCH v4] ath10k: enable raw encap mode and software crypto engine Liu CF/TW
2015-06-12 19:56 ` Liu CF/TW
2015-07-24 17:29 ` Kalle Valo [this message]
2015-07-24 17:29 ` Kalle Valo
2015-07-27 18:19 ` Liu CF/TW
2015-07-27 18:19 ` Liu CF/TW
2015-07-29 8:28 ` Kalle Valo
2015-07-29 8:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp3hbh18.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=cfliu.tw@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.