From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
"Linux-Kernel\@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap
Date: Wed, 13 Nov 2019 18:35:30 +0200 [thread overview]
Message-ID: <87r22bhgz1.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CACvgo51sNzSHCcix89giYEq=iGJa_-nYbgpOKY-MxPRGCM_cRQ@mail.gmail.com>
On Wed, 13 Nov 2019, Emil Velikov <emil.l.velikov@gmail.com>
wrote:
> On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu
> <adrian.ratiu@collabora.com> wrote:
>>
>> Convert the common bridge code and the two rockchip & stm
>> drivers which currently use it to the regmap API in
>> anticipation for further changes to make it more generic and
>> add older DSI host controller support as found on i.mx6 based
>> devices.
>>
>> The regmap becomes an internal state of the bridge. No
>> functional changes other than requiring the platform drivers to
>> use the pre-configured regmap supplied by the bridge after its
>> probe() call instead of ioremp'ing the registers themselves.
>>
>> In subsequent commits the bridge will become able to detect the
>> DSI host core version and init the regmap with different
>> register layouts. The platform drivers will continue to use the
>> regmap without modifications or worrying about the specific
>> layout in use (in other words the layout is abstracted away via
>> the regmap).
>>
>> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> I should have been clearer earlier - I didn't quite review the
> patch. Is is now though. Reviewed-by: Emil Velikov
> <emil.velikov@collabora.com>
Sorry about that, I got confused and thought you reviewed it all.
>
> Admittedly a couple of nitpicks (DRIVER_NAME, zero initialize of
> val) could have been left out. It's not a big deal, there's no
> need to polish those.
I'll address them in v3 as well as updating your mail address.
Thanks for reviewing!
>
> -Emil
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap
Date: Wed, 13 Nov 2019 18:35:30 +0200 [thread overview]
Message-ID: <87r22bhgz1.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CACvgo51sNzSHCcix89giYEq=iGJa_-nYbgpOKY-MxPRGCM_cRQ@mail.gmail.com>
On Wed, 13 Nov 2019, Emil Velikov <emil.l.velikov@gmail.com>
wrote:
> On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu
> <adrian.ratiu@collabora.com> wrote:
>>
>> Convert the common bridge code and the two rockchip & stm
>> drivers which currently use it to the regmap API in
>> anticipation for further changes to make it more generic and
>> add older DSI host controller support as found on i.mx6 based
>> devices.
>>
>> The regmap becomes an internal state of the bridge. No
>> functional changes other than requiring the platform drivers to
>> use the pre-configured regmap supplied by the bridge after its
>> probe() call instead of ioremp'ing the registers themselves.
>>
>> In subsequent commits the bridge will become able to detect the
>> DSI host core version and init the regmap with different
>> register layouts. The platform drivers will continue to use the
>> regmap without modifications or worrying about the specific
>> layout in use (in other words the layout is abstracted away via
>> the regmap).
>>
>> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> I should have been clearer earlier - I didn't quite review the
> patch. Is is now though. Reviewed-by: Emil Velikov
> <emil.velikov@collabora.com>
Sorry about that, I got confused and thought you reviewed it all.
>
> Admittedly a couple of nitpicks (DRIVER_NAME, zero initialize of
> val) could have been left out. It's not a big deal, there's no
> need to polish those.
I'll address them in v3 as well as updating your mail address.
Thanks for reviewing!
>
> -Emil
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap
Date: Wed, 13 Nov 2019 18:35:30 +0200 [thread overview]
Message-ID: <87r22bhgz1.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CACvgo51sNzSHCcix89giYEq=iGJa_-nYbgpOKY-MxPRGCM_cRQ@mail.gmail.com>
On Wed, 13 Nov 2019, Emil Velikov <emil.l.velikov@gmail.com>
wrote:
> On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu
> <adrian.ratiu@collabora.com> wrote:
>>
>> Convert the common bridge code and the two rockchip & stm
>> drivers which currently use it to the regmap API in
>> anticipation for further changes to make it more generic and
>> add older DSI host controller support as found on i.mx6 based
>> devices.
>>
>> The regmap becomes an internal state of the bridge. No
>> functional changes other than requiring the platform drivers to
>> use the pre-configured regmap supplied by the bridge after its
>> probe() call instead of ioremp'ing the registers themselves.
>>
>> In subsequent commits the bridge will become able to detect the
>> DSI host core version and init the regmap with different
>> register layouts. The platform drivers will continue to use the
>> regmap without modifications or worrying about the specific
>> layout in use (in other words the layout is abstracted away via
>> the regmap).
>>
>> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> I should have been clearer earlier - I didn't quite review the
> patch. Is is now though. Reviewed-by: Emil Velikov
> <emil.velikov@collabora.com>
Sorry about that, I got confused and thought you reviewed it all.
>
> Admittedly a couple of nitpicks (DRIVER_NAME, zero initialize of
> val) could have been left out. It's not a big deal, there's no
> need to polish those.
I'll address them in v3 as well as updating your mail address.
Thanks for reviewing!
>
> -Emil
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap
Date: Wed, 13 Nov 2019 18:35:30 +0200 [thread overview]
Message-ID: <87r22bhgz1.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> (raw)
Message-ID: <20191113163530.uUEz-CSWjdOo9XRtKkDdRyCtPa5mpm_ywSSOask0L4M@z> (raw)
In-Reply-To: <CACvgo51sNzSHCcix89giYEq=iGJa_-nYbgpOKY-MxPRGCM_cRQ@mail.gmail.com>
On Wed, 13 Nov 2019, Emil Velikov <emil.l.velikov@gmail.com>
wrote:
> On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu
> <adrian.ratiu@collabora.com> wrote:
>>
>> Convert the common bridge code and the two rockchip & stm
>> drivers which currently use it to the regmap API in
>> anticipation for further changes to make it more generic and
>> add older DSI host controller support as found on i.mx6 based
>> devices.
>>
>> The regmap becomes an internal state of the bridge. No
>> functional changes other than requiring the platform drivers to
>> use the pre-configured regmap supplied by the bridge after its
>> probe() call instead of ioremp'ing the registers themselves.
>>
>> In subsequent commits the bridge will become able to detect the
>> DSI host core version and init the regmap with different
>> register layouts. The platform drivers will continue to use the
>> regmap without modifications or worrying about the specific
>> layout in use (in other words the layout is abstracted away via
>> the regmap).
>>
>> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> I should have been clearer earlier - I didn't quite review the
> patch. Is is now though. Reviewed-by: Emil Velikov
> <emil.velikov@collabora.com>
Sorry about that, I got confused and thought you reviewed it all.
>
> Admittedly a couple of nitpicks (DRIVER_NAME, zero initialize of
> val) could have been left out. It's not a big deal, there's no
> need to polish those.
I'll address them in v3 as well as updating your mail address.
Thanks for reviewing!
>
> -Emil
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-13 16:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 16:30 [PATCH v2 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-13 14:57 ` Emil Velikov
2019-11-13 14:57 ` Emil Velikov
2019-11-13 14:57 ` Emil Velikov
2019-11-13 16:35 ` Adrian Ratiu [this message]
2019-11-13 16:35 ` Adrian Ratiu
2019-11-13 16:35 ` Adrian Ratiu
2019-11-13 16:35 ` Adrian Ratiu
2019-11-06 16:30 ` [PATCH v2 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-13 15:15 ` Emil Velikov
2019-11-13 15:15 ` Emil Velikov
2019-11-13 15:15 ` Emil Velikov
2019-11-06 16:30 ` [PATCH v2 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-13 15:43 ` Emil Velikov
2019-11-13 15:43 ` Emil Velikov
2019-11-13 15:43 ` Emil Velikov
2019-11-06 16:30 ` [PATCH v2 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-06 16:30 ` Adrian Ratiu
2019-11-13 16:06 ` Emil Velikov
2019-11-13 16:06 ` Emil Velikov
2019-11-13 16:06 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r22bhgz1.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me \
--to=adrian.ratiu@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.