From: Jani Nikula <jani.nikula@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Fernandes <joelaf@google.com>
Cc: Barret Rhoden <brho@google.com>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>,
Jonathan Nieder <jrn@google.com>,
Tomasz Figa <tfiga@chromium.org>,
Han-Wen Nienhuys <hanwen@google.com>,
Theodore Tso <tytso@google.com>,
David Rientjes <rientjes@google.com>,
Dmitry Torokhov <dtor@chromium.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits
Date: Wed, 28 Aug 2019 12:25:43 +0300 [thread overview]
Message-ID: <87r2557iaw.fsf@intel.com> (raw)
In-Reply-To: <20190828090837.GA31704@kroah.com>
On Wed, 28 Aug 2019, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Then, when the "final" patch is added, the message id of that will be
> committed to the tree with the git hook that has been posted here, and
> then, if someone _REALLY_ wants to go look up past history of versions,
> they can see it all linked together in a nice pretty tree on
> lore.kernel.org or elsewhere.
>
> And really, this whole discussion has been for the VERY RARE case of
> when someone wants to do some code spelunking and try to figure out
> older versions of a patch history before it was committed and they don't
> feel like searching for the author's name instead. The HUGE majority of
> kernel developers never actually care about this as they don't have to
> do it.
For me the Link: tag is also a bit of audit trail, if you will. You can
easily check that the patch was actually posted for review on a public
list, and nobody sneaked it in without review. (And in drm/i915 we point
the Link: tag at our patchwork which also contains the CI results we
require.)
When I've found myself looking at the actual discussion or earlier patch
versions, it's almost always because the commit message falls short. A
link to the discussion should never be a replacement for a proper commit
message.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2019-08-28 9:25 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 23:39 [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits Doug Anderson
2019-08-23 0:03 ` Brendan Higgins
2019-08-23 0:17 ` Linus Torvalds
2019-08-23 0:30 ` Olof Johansson
2019-08-23 0:43 ` Guenter Roeck
2019-08-23 0:45 ` Olof Johansson
2019-08-23 1:05 ` Olof Johansson
2019-08-23 1:09 ` Dmitry Torokhov
2019-08-23 1:36 ` Theodore Y. Ts'o
2019-08-23 2:58 ` Linus Torvalds
2019-08-23 3:03 ` Linus Torvalds
2019-08-23 13:15 ` Sean Paul
2019-08-23 15:18 ` Theodore Y. Ts'o
2019-08-23 15:31 ` Sean Paul
2019-08-23 15:48 ` Thomas Gleixner
2019-08-23 16:19 ` Dmitry Torokhov
2019-08-23 16:35 ` Joel Fernandes
2019-08-23 16:45 ` Doug Anderson
2019-08-23 16:54 ` Joel Fernandes
2019-08-23 18:00 ` Doug Anderson
2019-08-23 19:08 ` Joel Fernandes
2019-08-23 19:15 ` Joel Fernandes
2019-08-23 19:23 ` Thomas Gleixner
2019-08-23 19:31 ` Joel Fernandes
2019-08-24 16:53 ` Doug Anderson
2019-08-23 16:46 ` Dmitry Torokhov
2019-08-23 19:17 ` Thomas Gleixner
2019-08-23 19:38 ` Laurent Pinchart
2019-08-23 21:15 ` Thomas Gleixner
2019-08-23 21:25 ` Mark Brown
2019-08-24 23:13 ` Theodore Y. Ts'o
2019-08-25 7:09 ` Thomas Gleixner
2019-08-26 22:05 ` Thomas Gleixner
2019-08-28 8:50 ` Thomas Gleixner
2019-08-23 20:02 ` Christian Brauner
2019-08-24 16:34 ` Doug Anderson
2019-08-24 18:11 ` Linus Torvalds
2019-08-24 23:04 ` Theodore Y. Ts'o
2019-08-25 3:11 ` Greg Kroah-Hartman
2019-08-27 10:51 ` Mark Brown
2019-09-09 8:14 ` Michael Ellerman
2019-09-09 12:09 ` Mark Brown
2019-08-26 17:13 ` Doug Anderson
2019-08-26 17:30 ` Joel Fernandes
2019-08-26 21:35 ` Doug Anderson
2019-08-26 21:51 ` Thomas Gleixner
2019-08-26 22:06 ` Doug Anderson
2019-08-26 22:19 ` Thomas Gleixner
2019-08-26 23:02 ` Theodore Y. Ts'o
2019-08-26 23:11 ` Doug Anderson
2019-09-16 14:11 ` Christian Brauner
2019-09-16 17:43 ` Al Viro
2019-09-16 18:05 ` Doug Anderson
2019-08-26 23:43 ` Thomas Gleixner
2019-08-28 12:34 ` Christian Brauner
2019-08-27 0:29 ` Dmitry Vyukov
2019-08-27 6:06 ` Thomas Gleixner
2019-08-27 13:24 ` Dmitry Vyukov
2019-08-27 13:48 ` Greg Kroah-Hartman
2019-08-27 14:01 ` Guenter Roeck
2019-08-27 14:09 ` Thomas Gleixner
2019-08-27 15:33 ` Greg Kroah-Hartman
2019-08-27 15:42 ` Thomas Gleixner
2019-08-27 18:55 ` Konstantin Ryabitsev
2019-08-27 19:53 ` Greg Kroah-Hartman
2019-08-27 21:34 ` Joel Fernandes
2019-08-27 21:38 ` Joel Fernandes
2019-08-28 9:08 ` Greg Kroah-Hartman
2019-08-28 9:25 ` Jani Nikula [this message]
2019-08-28 10:04 ` Martin K. Petersen
2019-08-28 10:53 ` Thomas Gleixner
2019-08-28 12:46 ` Martin K. Petersen
2019-08-28 10:42 ` Mark Brown
2019-08-28 11:41 ` Greg Kroah-Hartman
2019-08-28 12:22 ` Christian Brauner
2019-08-28 12:38 ` Joel Fernandes
2019-08-28 13:58 ` Theodore Y. Ts'o
2019-08-28 20:39 ` Doug Anderson
2019-08-28 20:46 ` Johannes Berg
2019-08-28 21:00 ` Doug Anderson
2019-08-28 22:15 ` Rob Herring
2019-08-27 17:34 ` Geert Uytterhoeven
2019-08-27 18:50 ` Guenter Roeck
2019-08-27 14:06 ` Thomas Gleixner
2019-08-27 7:33 ` Geert Uytterhoeven
2019-08-27 13:30 ` Dmitry Vyukov
2019-08-27 14:28 ` Paul E. McKenney
2019-08-27 15:06 ` Thomas Gleixner
2019-08-27 15:25 ` Paul E. McKenney
2019-08-28 8:57 ` Dan Carpenter
2019-08-23 15:49 ` Doug Anderson
2019-08-23 15:54 ` Thomas Gleixner
2019-08-23 15:59 ` Thomas Gleixner
2019-08-23 16:38 ` Doug Anderson
2019-08-23 16:50 ` Andrew Lunn
2019-08-23 17:50 ` Doug Anderson
2019-08-23 18:10 ` Konstantin Ryabitsev
2019-08-26 22:19 ` Paul Mackerras
2019-08-27 7:02 ` Stephen Rothwell
2019-08-23 9:09 ` Vlastimil Babka
2019-08-23 12:48 ` Bhaskar Chowdhury
2019-08-23 1:01 ` Dmitry Torokhov
2019-08-23 1:07 ` Doug Anderson
2019-08-23 1:18 ` Joel Fernandes
2019-09-05 8:12 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2557iaw.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=brho@google.com \
--cc=dtor@chromium.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanwen@google.com \
--cc=joelaf@google.com \
--cc=jrn@google.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=rientjes@google.com \
--cc=tfiga@chromium.org \
--cc=tytso@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.