Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits

From: Thomas Gleixner <tglx@linutronix.de>
To: Sean Paul <seanpaul@chromium.org>
Cc: Joel Fernandes <joelaf@google.com>,
	Barret Rhoden <brho@google.com>,
	ksummit <ksummit-discuss@lists.linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Nieder <jrn@google.com>,
	Tomasz Figa <tfiga@chromium.org>,
	Han-Wen Nienhuys <hanwen@google.com>,
	Theodore Tso <tytso@google.com>,
	David Rientjes <rientjes@google.com>,
	Dmitry Torokhov <dtor@chromium.org>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits
Date: Fri, 23 Aug 2019 17:48:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1908231740020.1896@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAOw6vb+1LH8t20S_3kC6xyGZAhrDa3Pe4ZptsJqoQzXf3WCOeg@mail.gmail.com>

On Fri, 23 Aug 2019, Sean Paul wrote:
> On Fri, Aug 23, 2019 at 11:18 AM Theodore Y. Ts'o <tytso@mit.edu> wrote:
> >
> > On Fri, Aug 23, 2019 at 09:15:30AM -0400, Sean Paul wrote:
> > > Only if you've uploaded the patch somewhere before sending it to the
> > > mailing list. I think this would satisfy the Gerrit crowd, since
> > > they're presumably uploading the patch to Gerrit, getting some review
> > > on it and then sending it upstream. They will have a link. If you're
> > > just interested in being archival tool friendly, you probably just
> > > want to add some uuid cookie to the patch and post it directly to the
> > > mailing list.
> >
> > And this is why I think something like one of the two:
> >
> > Link: https://linux-review.googlesource.com/c/1158
> > Link: https://linux-review.googlesource.com/q/I3268f9036512c4378cde1da37e0612b43ed4d384
> >
> > ... is a better choice.
> >
> 
> Agreed. If you have a url for the patch this makes sense.
> 
> I don't upload my patches to Gerrit, but I am interested in enabling
> patchwork (or equivalent tool) to do a better job of tracking revision
> changes.
> 
> Currently I just link to all past revisions in the latest one (see
> [1]) so folks can see the prior discussion. It'd be nice if there was
> an easier way of achieving this.

That's mostly a question of being careful about it. The initial submissions
cover letter starts the whole thing. For any following version, the cover
letter should have:

    This is version X of this series. The previous version can be found
    here:

	https://lkml.kernel.org/r/$MSGID_PREV_COVERLETTER

So when the final version gets applied, then each commit gets a link:

   Link: https://lkml.kernel.org/r/$MSGID_OF_PATCH_$N

Then it's just a matter of following the links and that can be automated.

For a single patch w/o cover letter this can be solved as well:

    Subject ....

    changelog

    SOB
    ---
    V3: Fixed stuff
    V2: https://lkml.kernel.org/r/$MSGID_OF_PATCH_V2

    diffstat
    ---
    diff

And looking at the above example, you can add even gerrit ids or whatever
information into the '---' discard section. It's going to be in the mail
archive and traceable by the commit Link.

Yes, it's work for the submitter, but it's always work if the submitter
wants to have a proper trace.

For the committer it's a matter of tooling to add the link with the message
id per patch. I'm doing that for years fully automated.

Thanks,

	tglx