All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Matthias Blankertz <matthias.blankertz@cetitec.com>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 0/2] ASoC: rsnd: Fixes for multichannel HDMI audio output
Date: 16 Apr 2020 10:35:17 +0900	[thread overview]
Message-ID: <87sgh4p60a.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200415141017.384017-1-matthias.blankertz@cetitec.com>


Hi

> This fixes two issues in the snd-soc-rcar driver blocking multichannel
> HDMI audio out: The parent SSI in a multi-SSI configuration is not
> correctly set up and started, and the SSI->HDMI channel mapping is
> wrong.
> 
> With these patches, the following device tree snippet can be used on an
> r8a7795-based platform (Salvator-X) to enable multichannel HDMI audio on
> HDMI0:
> 
> rsnd_port1: port@1 {
> 	rsnd_endpoint1: endpoint {
> 		remote-endpoint = <&dw_hdmi0_snd_in>;
> 
> 		dai-format = "i2s";
> 		bitclock-master = <&rsnd_endpoint1>;
> 		frame-master = <&rsnd_endpoint1>;
> 
> 		playback = <&ssi0 &ssi1 &ssi2 &ssi9>;
> 	};
> };
> 
> With a capable receiver attached, all of 2ch (stereo), 6ch (e.g. 5.1)
> and 8ch audio output should work.
> 
> 
> Matthias Blankertz (2):
>   ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode
>   ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode
> 
>  sound/soc/sh/rcar/ssi.c  | 8 ++++----
>  sound/soc/sh/rcar/ssiu.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Matthias Blankertz <matthias.blankertz@cetitec.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	linux-renesas-soc@vger.kernel.org,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/2] ASoC: rsnd: Fixes for multichannel HDMI audio output
Date: 16 Apr 2020 10:35:17 +0900	[thread overview]
Message-ID: <87sgh4p60a.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200415141017.384017-1-matthias.blankertz@cetitec.com>


Hi

> This fixes two issues in the snd-soc-rcar driver blocking multichannel
> HDMI audio out: The parent SSI in a multi-SSI configuration is not
> correctly set up and started, and the SSI->HDMI channel mapping is
> wrong.
> 
> With these patches, the following device tree snippet can be used on an
> r8a7795-based platform (Salvator-X) to enable multichannel HDMI audio on
> HDMI0:
> 
> rsnd_port1: port@1 {
> 	rsnd_endpoint1: endpoint {
> 		remote-endpoint = <&dw_hdmi0_snd_in>;
> 
> 		dai-format = "i2s";
> 		bitclock-master = <&rsnd_endpoint1>;
> 		frame-master = <&rsnd_endpoint1>;
> 
> 		playback = <&ssi0 &ssi1 &ssi2 &ssi9>;
> 	};
> };
> 
> With a capable receiver attached, all of 2ch (stereo), 6ch (e.g. 5.1)
> and 8ch audio output should work.
> 
> 
> Matthias Blankertz (2):
>   ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode
>   ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode
> 
>  sound/soc/sh/rcar/ssi.c  | 8 ++++----
>  sound/soc/sh/rcar/ssiu.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2020-04-16  1:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 14:10 [PATCH 0/2] ASoC: rsnd: Fixes for multichannel HDMI audio output Matthias Blankertz
2020-04-15 14:10 ` Matthias Blankertz
2020-04-15 14:10 ` [PATCH 1/2] ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode Matthias Blankertz
2020-04-15 14:10   ` Matthias Blankertz
2020-04-16 15:23   ` Applied "ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode" to the asoc tree Mark Brown
2020-04-16 15:23     ` Mark Brown
2020-04-15 14:10 ` [PATCH 2/2] ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode Matthias Blankertz
2020-04-15 14:10   ` Matthias Blankertz
2020-04-16 15:23   ` Applied "ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode" to the asoc tree Mark Brown
2020-04-16 15:23     ` Mark Brown
2020-04-16  1:35 ` Kuninori Morimoto [this message]
2020-04-16  1:35   ` [PATCH 0/2] ASoC: rsnd: Fixes for multichannel HDMI audio output Kuninori Morimoto
2020-04-17 16:15 ` Mark Brown
2020-04-17 16:15   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgh4p60a.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=matthias.blankertz@cetitec.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.