Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code

From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code
Date: Tue, 16 Apr 2019 21:19:42 +0200	[thread overview]
Message-ID: <87sguh3ghd.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190416160927.GT31311@redhat.com> ("Daniel P. =?utf-8?Q?Ber?= =?utf-8?Q?rang=C3=A9=22's?= message of "Tue, 16 Apr 2019 17:09:27 +0100")

Daniel P. Berrangé <berrange@redhat.com> writes:

[...]
> I think that's fundamentally the wrong way around. Most stuff *should*
> be locale dependant, otherwise any interaction with the host OS is
> likely to use incorrect localization. It isn't practical to put a
> uselocale() call around every place that opens a filename. There are
> a few places where QEMU should be locale indepandant such as the QMP
> and guest OS ABI sensitive things, which should take account of it.

All right, you convinced me.  The problem is even bigger than I thought.
That means the return on investment in this area is even poorer than I
thought.

I don't think we should try to support anything but ASCII and UTF-8.