From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>,
Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com
Subject: Re: [PATCH] drm/i915: Fix i915_error_state_store error defination
Date: Fri, 17 Jan 2020 15:14:25 +0200 [thread overview]
Message-ID: <87tv4ugr7y.fsf@intel.com> (raw)
In-Reply-To: <20200117121550.GA3238@intel.intel>
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Zhang,
>
> On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
>> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
>> capture"), function 'i915_error_state_store' was defined and used with
>> only one parameter.
>>
>> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
>> with two parameter.
>>
>> This may lead compile error. This patch fix it.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>
> I've never been a fan of non human accounts, we had this discussion
> already in a different mailing list. Could you please find a
> different way of giving credit to your CI system?
I don't actually mind for Reported-by credits. The history is full of
things like:
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
Care to reference the discussion?
BR,
Janid.
>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
>> index 9109004956bd..41c1475e1500 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
>> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>> }
>>
>> static inline void
>> -i915_error_state_store(struct drm_i915_private *i915,
>> - struct i915_gpu_coredump *error)
>> +i915_error_state_store(struct i915_gpu_coredump *error)
>
> ouch! that's an oversight.
>
> Thanks for your patch,
>
> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>,
Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
Date: Fri, 17 Jan 2020 15:14:25 +0200 [thread overview]
Message-ID: <87tv4ugr7y.fsf@intel.com> (raw)
In-Reply-To: <20200117121550.GA3238@intel.intel>
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Zhang,
>
> On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
>> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
>> capture"), function 'i915_error_state_store' was defined and used with
>> only one parameter.
>>
>> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
>> with two parameter.
>>
>> This may lead compile error. This patch fix it.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>
> I've never been a fan of non human accounts, we had this discussion
> already in a different mailing list. Could you please find a
> different way of giving credit to your CI system?
I don't actually mind for Reported-by credits. The history is full of
things like:
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
Care to reference the discussion?
BR,
Janid.
>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
>> index 9109004956bd..41c1475e1500 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
>> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>> }
>>
>> static inline void
>> -i915_error_state_store(struct drm_i915_private *i915,
>> - struct i915_gpu_coredump *error)
>> +i915_error_state_store(struct i915_gpu_coredump *error)
>
> ouch! that's an oversight.
>
> Thanks for your patch,
>
> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-17 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:34 [PATCH] drm/i915: Fix i915_error_state_store error defination Zhang Xiaoxu
2020-01-17 7:34 ` [Intel-gfx] " Zhang Xiaoxu
2020-01-17 12:15 ` Andi Shyti
2020-01-17 12:15 ` [Intel-gfx] " Andi Shyti
2020-01-17 13:14 ` Jani Nikula [this message]
2020-01-17 13:14 ` Jani Nikula
2020-01-17 14:05 ` Andi Shyti
2020-01-17 14:05 ` [Intel-gfx] " Andi Shyti
2020-01-17 14:13 ` Jani Nikula
2020-01-17 14:13 ` [Intel-gfx] " Jani Nikula
2020-01-18 2:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv4ugr7y.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=andi.shyti@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.