From: "Huang\, Ying" <ying.huang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning
Date: Sat, 01 Jun 2019 08:14:29 +0800 [thread overview]
Message-ID: <87tvda40wq.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20190531061047.GB6896@dhcp22.suse.cz> (Michal Hocko's message of "Fri, 31 May 2019 08:10:47 +0200")
Michal Hocko <mhocko@kernel.org> writes:
> On Fri 31-05-19 10:41:02, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>>
>> Mike reported the following warning messages
>>
>> get_swap_device: Bad swap file entry 1400000000000001
>>
>> This is produced by
>>
>> - total_swapcache_pages()
>> - get_swap_device()
>>
>> Where get_swap_device() is used to check whether the swap device is
>> valid and prevent it from being swapoff if so. But get_swap_device()
>> may produce warning message as above for some invalid swap devices.
>> This is fixed via calling swp_swap_info() before get_swap_device() to
>> filter out the swap devices that may cause warning messages.
>>
>> Fixes: 6a946753dbe6 ("mm/swap_state.c: simplify total_swapcache_pages() with get_swap_device()")
>
> I suspect this is referring to a mmotm patch right?
Yes.
> There doesn't seem
> to be any sha like this in Linus' tree AFAICS. If that is the case then
> please note that mmotm patch showing up in linux-next do not have a
> stable sha1 and therefore you shouldn't reference them in the commit
> message. Instead please refer to the specific mmotm patch file so that
> Andrew knows it should be folded in to it.
Thanks for reminding! I will be more careful in the future. It seems
that Andrew has identified the right patch to be folded into.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2019-06-01 0:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 2:41 [PATCH -mm] mm, swap: Fix bad swap file entry warning Huang, Ying
2019-05-31 6:10 ` Michal Hocko
2019-06-01 0:14 ` Huang, Ying [this message]
2019-06-01 0:14 ` Huang, Ying
2019-05-31 16:59 ` Mike Kravetz
2019-05-31 18:27 ` Dexuan-Linux Cui
2019-05-31 18:27 ` Dexuan-Linux Cui
2019-05-31 19:16 ` Qian Cai
2019-05-31 19:16 ` Qian Cai
2019-05-31 22:36 ` [EXT] " Yuri Norov
2019-06-01 4:25 Yuri Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvda40wq.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.