From: Jonathan Corbet <corbet@lwn.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Andersson" <andersson@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Heiko Stuebner" <heiko@sntech.de>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nishanth Menon" <nm@ti.com>, "Olof Johansson" <olof@lixom.net>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document
Date: Sat, 25 Nov 2023 12:33:47 -0700 [thread overview]
Message-ID: <87v89p1vc4.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Document preferred coding style for Devicetree sources (DTS and DTSI),
> to bring consistency among all (sub)architectures and ease in reviews.
One little nit:
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> new file mode 100644
> index 000000000000..e374bec0f555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -0,0 +1,194 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. _dtscodingstyle:
There is no need to put a label at the top of a document like that, I'd
just take it out.
Thanks,
jon
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Andersson" <andersson@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Heiko Stuebner" <heiko@sntech.de>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nishanth Menon" <nm@ti.com>, "Olof Johansson" <olof@lixom.net>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document
Date: Sat, 25 Nov 2023 12:33:47 -0700 [thread overview]
Message-ID: <87v89p1vc4.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Document preferred coding style for Devicetree sources (DTS and DTSI),
> to bring consistency among all (sub)architectures and ease in reviews.
One little nit:
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> new file mode 100644
> index 000000000000..e374bec0f555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -0,0 +1,194 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. _dtscodingstyle:
There is no need to put a label at the top of a document like that, I'd
just take it out.
Thanks,
jon
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Andersson" <andersson@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Heiko Stuebner" <heiko@sntech.de>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nishanth Menon" <nm@ti.com>, "Olof Johansson" <olof@lixom.net>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document
Date: Sat, 25 Nov 2023 12:33:47 -0700 [thread overview]
Message-ID: <87v89p1vc4.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Document preferred coding style for Devicetree sources (DTS and DTSI),
> to bring consistency among all (sub)architectures and ease in reviews.
One little nit:
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> new file mode 100644
> index 000000000000..e374bec0f555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -0,0 +1,194 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. _dtscodingstyle:
There is no need to put a label at the top of a document like that, I'd
just take it out.
Thanks,
jon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Andersson" <andersson@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Heiko Stuebner" <heiko@sntech.de>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nishanth Menon" <nm@ti.com>, "Olof Johansson" <olof@lixom.net>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document
Date: Sat, 25 Nov 2023 12:33:47 -0700 [thread overview]
Message-ID: <87v89p1vc4.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231125184422.12315-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Document preferred coding style for Devicetree sources (DTS and DTSI),
> to bring consistency among all (sub)architectures and ease in reviews.
One little nit:
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> new file mode 100644
> index 000000000000..e374bec0f555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -0,0 +1,194 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. _dtscodingstyle:
There is no need to put a label at the top of a document like that, I'd
just take it out.
Thanks,
jon
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-11-25 19:33 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 18:44 [PATCH v3] docs: dt-bindings: add DTS Coding Style document Krzysztof Kozlowski
2023-11-25 18:44 ` Krzysztof Kozlowski
2023-11-25 18:44 ` Krzysztof Kozlowski
2023-11-25 18:44 ` Krzysztof Kozlowski
2023-11-25 19:33 ` Jonathan Corbet [this message]
2023-11-25 19:33 ` Jonathan Corbet
2023-11-25 19:33 ` Jonathan Corbet
2023-11-25 19:33 ` Jonathan Corbet
2023-11-26 10:28 ` Krzysztof Kozlowski
2023-11-26 10:28 ` Krzysztof Kozlowski
2023-11-26 10:28 ` Krzysztof Kozlowski
2023-11-26 10:28 ` Krzysztof Kozlowski
2023-11-25 19:37 ` Laurent Pinchart
2023-11-25 19:37 ` Laurent Pinchart
2023-11-25 19:37 ` Laurent Pinchart
2023-11-25 19:37 ` Laurent Pinchart
2023-11-25 22:24 ` Konrad Dybcio
2023-11-25 22:24 ` Konrad Dybcio
2023-11-25 22:24 ` Konrad Dybcio
2023-11-25 22:24 ` Konrad Dybcio
2023-11-26 10:32 ` Krzysztof Kozlowski
2023-11-26 10:32 ` Krzysztof Kozlowski
2023-11-26 10:32 ` Krzysztof Kozlowski
2023-11-26 10:32 ` Krzysztof Kozlowski
2023-11-26 14:53 ` Laurent Pinchart
2023-11-26 14:53 ` Laurent Pinchart
2023-11-26 14:53 ` Laurent Pinchart
2023-11-26 14:53 ` Laurent Pinchart
2023-11-27 21:55 ` Rob Herring
2023-11-27 21:55 ` Rob Herring
2023-11-27 21:55 ` Rob Herring
2023-11-27 21:55 ` Rob Herring
2023-11-25 19:47 ` Andrew Lunn
2023-11-25 19:47 ` Andrew Lunn
2023-11-25 19:47 ` Andrew Lunn
2023-11-25 19:47 ` Andrew Lunn
2023-11-26 10:38 ` Krzysztof Kozlowski
2023-11-26 10:38 ` Krzysztof Kozlowski
2023-11-26 10:38 ` Krzysztof Kozlowski
2023-11-26 10:38 ` Krzysztof Kozlowski
2023-11-26 17:48 ` Andrew Lunn
2023-11-26 17:48 ` Andrew Lunn
2023-11-26 17:48 ` Andrew Lunn
2023-11-26 17:48 ` Andrew Lunn
2023-11-29 10:06 ` Krzysztof Kozlowski
2023-11-29 10:06 ` Krzysztof Kozlowski
2023-11-29 10:06 ` Krzysztof Kozlowski
2023-11-29 10:06 ` Krzysztof Kozlowski
2023-11-25 22:26 ` Konrad Dybcio
2023-11-25 22:26 ` Konrad Dybcio
2023-11-25 22:26 ` Konrad Dybcio
2023-11-25 22:26 ` Konrad Dybcio
2023-11-27 14:19 ` Geert Uytterhoeven
2023-11-27 14:19 ` Geert Uytterhoeven
2023-11-27 14:19 ` Geert Uytterhoeven
2023-11-27 14:19 ` Geert Uytterhoeven
2023-11-29 10:16 ` Krzysztof Kozlowski
2023-11-29 10:16 ` Krzysztof Kozlowski
2023-11-29 10:16 ` Krzysztof Kozlowski
2023-11-29 10:16 ` Krzysztof Kozlowski
2023-11-28 20:00 ` Dragan Simic
2023-11-28 20:00 ` Dragan Simic
2023-11-28 20:00 ` Dragan Simic
2023-11-28 20:00 ` Dragan Simic
2023-11-29 10:43 ` Krzysztof Kozlowski
2023-11-29 10:43 ` Krzysztof Kozlowski
2023-11-29 10:43 ` Krzysztof Kozlowski
2023-11-29 10:43 ` Krzysztof Kozlowski
2023-11-29 11:37 ` Dragan Simic
2023-11-29 11:37 ` Dragan Simic
2023-11-29 11:37 ` Dragan Simic
2023-11-29 11:37 ` Dragan Simic
2023-12-03 20:12 ` Dragan Simic
2023-12-03 20:12 ` Dragan Simic
2023-12-03 20:12 ` Dragan Simic
2023-12-03 20:12 ` Dragan Simic
2023-12-04 15:11 ` Krzysztof Kozlowski
2023-12-04 15:11 ` Krzysztof Kozlowski
2023-12-04 15:11 ` Krzysztof Kozlowski
2023-12-04 15:11 ` Krzysztof Kozlowski
2023-12-04 16:19 ` Dragan Simic
2023-12-04 16:19 ` Dragan Simic
2023-12-04 16:19 ` Dragan Simic
2023-12-04 16:19 ` Dragan Simic
2023-11-29 7:29 ` Francesco Dolcini
2023-11-29 7:29 ` Francesco Dolcini
2023-11-29 7:29 ` Francesco Dolcini
2023-11-29 7:29 ` Francesco Dolcini
2023-11-29 8:47 ` Geert Uytterhoeven
2023-11-29 8:47 ` Geert Uytterhoeven
2023-11-29 8:47 ` Geert Uytterhoeven
2023-11-29 8:47 ` Geert Uytterhoeven
2023-11-29 10:19 ` Krzysztof Kozlowski
2023-11-29 10:19 ` Krzysztof Kozlowski
2023-11-29 10:19 ` Krzysztof Kozlowski
2023-11-29 10:19 ` Krzysztof Kozlowski
2023-11-29 11:16 ` Francesco Dolcini
2023-11-29 11:16 ` Francesco Dolcini
2023-11-29 11:16 ` Francesco Dolcini
2023-11-29 11:16 ` Francesco Dolcini
2023-12-01 16:46 ` Conor Dooley
2023-12-01 16:46 ` Conor Dooley
2023-12-01 16:46 ` Conor Dooley
2023-12-01 16:46 ` Conor Dooley
2023-12-02 13:04 ` Krzysztof Kozlowski
2023-12-02 13:04 ` Krzysztof Kozlowski
2023-12-02 13:04 ` Krzysztof Kozlowski
2023-12-02 13:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v89p1vc4.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=wens@kernel.org \
--cc=workflows@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.