From: Jani Nikula <jani.nikula@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
Christoph Hellwig <hch@lst.de>,
"Wang, Zhi A" <zhi.a.wang@intel.com>
Subject: Re: [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API
Date: Mon, 07 Feb 2022 14:13:50 +0200 [thread overview]
Message-ID: <87v8xqri0x.fsf@intel.com> (raw)
In-Reply-To: <20220207120647.GA28851@lst.de>
On Mon, 07 Feb 2022, Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote:
>> Hi Christoph and Jani:
>>
>> Thanks for the comments. It would be nice that people can achieve a
>> agreement. I am OK with both of the options and also moving some files into
>> different folders doesn't needs me to do the full test run again. :)
>
> The way I understood Jani he agrees that the mmio table, which needs to
> be part of the core i915 module should not be under the gvt/ subdiretory.
> I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The
> declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h
> or drivers/gpu/drm/i915/intel_gvt_mmio_table.h.
Correct.
Generally I prefer to have the declarations for stuff in intel_foo.c to
be placed in intel_foo.h, and named intel_foo_*.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Xu, Terrence" <terrence.xu@intel.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API
Date: Mon, 07 Feb 2022 14:13:50 +0200 [thread overview]
Message-ID: <87v8xqri0x.fsf@intel.com> (raw)
In-Reply-To: <20220207120647.GA28851@lst.de>
On Mon, 07 Feb 2022, Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote:
>> Hi Christoph and Jani:
>>
>> Thanks for the comments. It would be nice that people can achieve a
>> agreement. I am OK with both of the options and also moving some files into
>> different folders doesn't needs me to do the full test run again. :)
>
> The way I understood Jani he agrees that the mmio table, which needs to
> be part of the core i915 module should not be under the gvt/ subdiretory.
> I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The
> declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h
> or drivers/gpu/drm/i915/intel_gvt_mmio_table.h.
Correct.
Generally I prefer to have the declarations for stuff in intel_foo.c to
be placed in intel_foo.h, and named intel_foo_*.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Wang, Zhi A" <zhi.a.wang@intel.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API
Date: Mon, 07 Feb 2022 14:13:50 +0200 [thread overview]
Message-ID: <87v8xqri0x.fsf@intel.com> (raw)
In-Reply-To: <20220207120647.GA28851@lst.de>
On Mon, 07 Feb 2022, Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote:
>> Hi Christoph and Jani:
>>
>> Thanks for the comments. It would be nice that people can achieve a
>> agreement. I am OK with both of the options and also moving some files into
>> different folders doesn't needs me to do the full test run again. :)
>
> The way I understood Jani he agrees that the mmio table, which needs to
> be part of the core i915 module should not be under the gvt/ subdiretory.
> I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The
> declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h
> or drivers/gpu/drm/i915/intel_gvt_mmio_table.h.
Correct.
Generally I prefer to have the declarations for stuff in intel_foo.c to
be placed in intel_foo.h, and named intel_foo_*.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-02-07 12:14 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 12:05 [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API Zhi Wang
2022-01-27 12:05 ` [Intel-gfx] " Zhi Wang
2022-01-27 12:05 ` Zhi Wang
2022-01-27 12:05 ` [PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915 Zhi Wang
2022-01-27 12:05 ` [Intel-gfx] " Zhi Wang
2022-01-27 12:05 ` Zhi Wang
2022-01-31 6:38 ` Christoph Hellwig
2022-01-31 6:38 ` [Intel-gfx] " Christoph Hellwig
2022-01-27 12:05 ` [PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved " Zhi Wang
2022-01-27 12:05 ` [Intel-gfx] " Zhi Wang
2022-01-27 12:05 ` Zhi Wang
2022-01-27 14:52 ` [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API Christoph Hellwig
2022-01-27 14:52 ` [Intel-gfx] " Christoph Hellwig
2022-01-27 15:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
2022-01-27 15:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-27 15:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-27 17:14 ` [Intel-gfx] [PATCH 1/3] " kernel test robot
2022-01-27 17:14 ` kernel test robot
2022-01-27 17:14 ` kernel test robot
2022-01-27 17:46 ` kernel test robot
2022-01-27 17:46 ` kernel test robot
2022-01-27 17:46 ` kernel test robot
2022-01-27 17:46 ` kernel test robot
2022-01-27 19:08 ` kernel test robot
2022-01-27 19:08 ` kernel test robot
2022-01-27 19:08 ` kernel test robot
2022-01-27 20:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork
2022-01-28 5:01 ` [RFC PATCH] i915/gvt: intel_gvt_match_device() can be static kernel test robot
2022-01-28 5:01 ` kernel test robot
2022-01-28 5:01 ` [Intel-gfx] " kernel test robot
2022-01-28 5:01 ` kernel test robot
2022-01-28 5:11 ` [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API kernel test robot
2022-01-28 5:11 ` kernel test robot
2022-01-28 5:11 ` kernel test robot
2022-01-31 6:34 ` Christoph Hellwig
2022-01-31 6:34 ` Christoph Hellwig
2022-02-07 7:32 ` [Intel-gfx] " Christoph Hellwig
2022-02-07 7:32 ` Christoph Hellwig
2022-02-07 8:28 ` [Intel-gfx] " Wang, Zhi A
2022-02-07 8:28 ` Wang, Zhi A
2022-02-07 8:28 ` Wang, Zhi A
2022-02-07 8:35 ` [Intel-gfx] " Christoph Hellwig
2022-02-07 8:35 ` Christoph Hellwig
2022-02-07 10:48 ` Jani Nikula
2022-02-07 10:48 ` Jani Nikula
2022-02-07 10:48 ` [Intel-gfx] " Jani Nikula
2022-02-07 11:57 ` Zhi Wang
2022-02-07 11:57 ` Zhi Wang
2022-02-07 11:57 ` [Intel-gfx] " Zhi Wang
2022-02-07 12:06 ` Christoph Hellwig
2022-02-07 12:06 ` Christoph Hellwig
2022-02-07 12:13 ` Jani Nikula [this message]
2022-02-07 12:13 ` Jani Nikula
2022-02-07 12:13 ` [Intel-gfx] " Jani Nikula
2022-02-08 8:04 ` Joonas Lahtinen
2022-02-08 8:04 ` [Intel-gfx] " Joonas Lahtinen
2022-02-08 8:04 ` Joonas Lahtinen
2022-02-07 14:47 ` [Intel-gfx] " kernel test robot
2022-02-07 14:47 ` kernel test robot
2022-02-07 14:47 ` kernel test robot
2022-02-08 14:38 ` kernel test robot
2022-02-08 14:38 ` kernel test robot
2022-02-08 14:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8xqri0x.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.