Re: [PATCH 1/3] ath10k: embed supported chip ids in hw_params

From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: embed supported chip ids in hw_params
Date: Wed, 26 Nov 2014 09:21:16 +0200	[thread overview]
Message-ID: <87vbm2whoz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1416838646-18801-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Mon, 24 Nov 2014 15:17:24 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> This will make it easier to extend and maintain
> list of supported hardware.
>
> As a requirement this moves chip_id checking a
> little later because target_version isn't known
> until BMI can be queried.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

The reason why I originally added the chip_id check was that QCA988X hw
1.0 failed badly (ath10k might have even crashed, don't remember
anymore) and I added this chip_id as an ugly workaround to detect hw1.0
early. Most likely with this patch the problem comes back again.

I don't know what's a good solution, need to think more. Any ideas?

-- 
Kalle Valo