All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-security-module@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	linux-ima-devel@lists.sourceforge.net,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list
Date: Tue, 09 Aug 2016 20:59:51 +1000	[thread overview]
Message-ID: <87wpjqtdg8.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1470313475-20090-2-git-send-email-zohar@linux.vnet.ibm.com>

Mimi Zohar <zohar@linux.vnet.ibm.com> writes:

> diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
> index b5728da..84e8d36 100644
> --- a/security/integrity/ima/ima.h
> +++ b/security/integrity/ima/ima.h
> @@ -102,6 +102,13 @@ struct ima_queue_entry {
>  };
>  extern struct list_head ima_measurements;	/* list of all measurements */
>  
> +/* Some details preceding the binary serialized measurement list */
> +struct ima_kexec_hdr {
> +	unsigned short version;
> +	unsigned long buffer_size;
> +	unsigned long count;
> +} __packed;
> +

Am I understanding it correctly that this structure is passed between kernels?

If so it's an ABI and should use types with well defined sizes, as if it was
going out to userspace, shouldn't it?

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-security-module@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, Dave Young <dyoung@redhat.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-ima-devel@lists.sourceforge.net,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list
Date: Tue, 09 Aug 2016 20:59:51 +1000	[thread overview]
Message-ID: <87wpjqtdg8.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1470313475-20090-2-git-send-email-zohar@linux.vnet.ibm.com>

Mimi Zohar <zohar@linux.vnet.ibm.com> writes:

> diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
> index b5728da..84e8d36 100644
> --- a/security/integrity/ima/ima.h
> +++ b/security/integrity/ima/ima.h
> @@ -102,6 +102,13 @@ struct ima_queue_entry {
>  };
>  extern struct list_head ima_measurements;	/* list of all measurements */
>  
> +/* Some details preceding the binary serialized measurement list */
> +struct ima_kexec_hdr {
> +	unsigned short version;
> +	unsigned long buffer_size;
> +	unsigned long count;
> +} __packed;
> +

Am I understanding it correctly that this structure is passed between kernels?

If so it's an ABI and should use types with well defined sizes, as if it was
going out to userspace, shouldn't it?

cheers

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2016-08-09 10:59 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 12:24 [PATCH 0/7] ima: carry the measurement list across kexec Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 1/7] ima: on soft reboot, restore the measurement list Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-05  8:44   ` Petko Manolov
2016-08-05  8:44     ` Petko Manolov
2016-08-05 13:34     ` Mimi Zohar
2016-08-05 13:34       ` Mimi Zohar
2016-08-05 15:56       ` Petko Manolov
2016-08-05 15:56         ` Petko Manolov
2016-08-09 10:59   ` Michael Ellerman [this message]
2016-08-09 10:59     ` Michael Ellerman
2016-08-09 13:01     ` Mimi Zohar
2016-08-09 13:01       ` Mimi Zohar
2016-08-09 13:19       ` Thiago Jung Bauermann
2016-08-09 13:19         ` Thiago Jung Bauermann
2016-08-09 13:35         ` David Laight
2016-08-09 13:35           ` David Laight
2016-08-09 13:35           ` David Laight
2016-08-09 14:02           ` Mimi Zohar
2016-08-09 14:02             ` Mimi Zohar
2016-08-09 14:02             ` Mimi Zohar
2016-08-09 13:55         ` Mimi Zohar
2016-08-09 13:55           ` Mimi Zohar
2016-08-09 14:06           ` Mimi Zohar
2016-08-09 14:06             ` Mimi Zohar
2016-08-09 23:13         ` Samuel Mendoza-Jonas
2016-08-09 23:13           ` Samuel Mendoza-Jonas
2016-08-10  3:41         ` Michael Ellerman
2016-08-10  3:41           ` Michael Ellerman
2016-08-10  5:05           ` Thiago Jung Bauermann
2016-08-10  5:05             ` Thiago Jung Bauermann
2016-08-10  9:52             ` Michael Ellerman
2016-08-10  9:52               ` Michael Ellerman
2016-08-10 12:54               ` Mimi Zohar
2016-08-10 12:54                 ` Mimi Zohar
2016-08-10 14:32                 ` [Linux-ima-devel] " Petko Manolov
2016-08-10 14:32                   ` Petko Manolov
2016-08-10 14:40                   ` David Laight
2016-08-10 14:40                     ` David Laight
2016-08-10 14:40                     ` David Laight
2016-08-10 15:48                     ` Petko Manolov
2016-08-10 15:48                       ` Petko Manolov
2016-08-10 15:48                       ` Petko Manolov
2016-08-04 12:24 ` [PATCH 2/7] ima: permit duplicate measurement list entries Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 3/7] ima: maintain memory size needed for serializing the measurement list Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 4/7] ima: serialize the binary_runtime_measurements Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 5/7] ima: on soft reboot, save the measurement list Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 6/7] ima: store the builtin/custom template definitions in a list Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 7/7] ima: support restoring multiple template formats Mimi Zohar
2016-08-04 12:24   ` Mimi Zohar
2016-08-09  5:19 ` [PATCH 0/7] ima: carry the measurement list across kexec Balbir Singh
2016-08-09  5:19   ` Balbir Singh
2016-08-09 12:36   ` Mimi Zohar
2016-08-09 12:36     ` Mimi Zohar
2016-08-11  7:38     ` Balbir Singh
2016-08-11  7:38       ` Balbir Singh
2016-08-11 11:25       ` Mimi Zohar
2016-08-11 11:25         ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpjqtdg8.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.