All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction
Date: Tue, 5 Apr 2016 12:46:37 +0000	[thread overview]
Message-ID: <87wpocb4ur.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <73a1d6a04908fe060559d1a6e9afb128@codeaurora.org> (Rajkumar Manoharan's message of "Fri, 01 Apr 2016 10:49:05 +0530")

Rajkumar Manoharan <rmanohar@codeaurora.org> writes:

> On 2016-04-01 00:22, Ben Greear wrote:
>> On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote:
>>> Decrement num_mpdus_ready only when rx amsdu is processed
>>> successfully.
>>> Not doing so, will result in leak and impact stabilty under low memory
>>> cases.
>>
>> Should this patch be rebased on top of the "ath10k: process htt rx
>> indication as batch mode" patch?
>>
> It should be on top of "ath10k: speedup htt rx descriptor processing
> for rx_ind". Instead of sending next version of original series, i
> sent it as follow up.

Should this commit log have a fixes line like this:

Fixes: 59465fe46ef1 ("ath10k: speedup htt rx descriptor processing for tx completion")

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction
Date: Tue, 5 Apr 2016 12:46:37 +0000	[thread overview]
Message-ID: <87wpocb4ur.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <73a1d6a04908fe060559d1a6e9afb128@codeaurora.org> (Rajkumar Manoharan's message of "Fri, 01 Apr 2016 10:49:05 +0530")

Rajkumar Manoharan <rmanohar@codeaurora.org> writes:

> On 2016-04-01 00:22, Ben Greear wrote:
>> On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote:
>>> Decrement num_mpdus_ready only when rx amsdu is processed
>>> successfully.
>>> Not doing so, will result in leak and impact stabilty under low memory
>>> cases.
>>
>> Should this patch be rebased on top of the "ath10k: process htt rx
>> indication as batch mode" patch?
>>
> It should be on top of "ath10k: speedup htt rx descriptor processing
> for rx_ind". Instead of sending next version of original series, i
> sent it as follow up.

Should this commit log have a fixes line like this:

Fixes: 59465fe46ef1 ("ath10k: speedup htt rx descriptor processing for tx completion")

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2016-04-05 12:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 15:42 [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0 Rajkumar Manoharan
2016-03-30 15:42 ` Rajkumar Manoharan
2016-03-30 15:42 ` [PATCH 2/3] ath10k: remove unnecessary warning for probe response drops Rajkumar Manoharan
2016-03-30 15:42   ` Rajkumar Manoharan
2016-03-31 16:57   ` Ben Greear
2016-03-31 16:57     ` Ben Greear
2016-04-01  5:13     ` Rajkumar Manoharan
2016-04-01  5:13       ` Rajkumar Manoharan
2016-03-30 15:42 ` [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction Rajkumar Manoharan
2016-03-30 15:42   ` Rajkumar Manoharan
2016-03-31 18:52   ` Ben Greear
2016-03-31 18:52     ` Ben Greear
2016-04-01  5:19     ` Rajkumar Manoharan
2016-04-01  5:19       ` Rajkumar Manoharan
2016-04-05 12:46       ` Valo, Kalle [this message]
2016-04-05 12:46         ` Valo, Kalle
2016-04-05 12:48   ` Valo, Kalle
2016-04-05 12:48     ` Valo, Kalle
2016-04-05 13:34     ` Rajkumar Manoharan
2016-04-05 13:34       ` Rajkumar Manoharan
2016-04-05 12:40 ` [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0 Valo, Kalle
2016-04-05 12:40   ` Valo, Kalle
2016-04-05 13:32   ` Rajkumar Manoharan
2016-04-05 13:32     ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpocb4ur.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanohar@codeaurora.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.