From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sameer Pujar <spujar@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, sharadg@nvidia.com
Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function
Date: 04 Feb 2021 07:33:37 +0900 [thread overview]
Message-ID: <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210203172415.GH4880@sirena.org.uk>
Hi
> > > > +int graph_remove(struct platform_device *pdev);
>
> > > I think this needs better namespacing if it's going to be exported.
>
> > audio_graph_remove() can be a better choice?
>
> Yeah, that looks reasonable.
Nice naming I think.
In such case, update also graph_parse_of() is nice idea for me.
- int graph_parse_of(...)
+ int audio_graph_parse_of()
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Sameer Pujar <spujar@nvidia.com>,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
sharadg@nvidia.com, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function
Date: 04 Feb 2021 07:33:37 +0900 [thread overview]
Message-ID: <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210203172415.GH4880@sirena.org.uk>
Hi
> > > > +int graph_remove(struct platform_device *pdev);
>
> > > I think this needs better namespacing if it's going to be exported.
>
> > audio_graph_remove() can be a better choice?
>
> Yeah, that looks reasonable.
Nice naming I think.
In such case, update also graph_parse_of() is nice idea for me.
- int graph_parse_of(...)
+ int audio_graph_parse_of()
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2021-02-03 22:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:09 [PATCH 0/2] Add remove path for Tegra audio graph card Sameer Pujar
2021-02-03 16:09 ` Sameer Pujar
2021-02-03 16:09 ` [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function Sameer Pujar
2021-02-03 16:09 ` Sameer Pujar
2021-02-03 16:19 ` Mark Brown
2021-02-03 16:19 ` Mark Brown
2021-02-03 16:39 ` Sameer Pujar
2021-02-03 16:39 ` Sameer Pujar
2021-02-03 17:24 ` Mark Brown
2021-02-03 17:24 ` Mark Brown
2021-02-03 22:33 ` Kuninori Morimoto [this message]
2021-02-03 22:33 ` Kuninori Morimoto
2021-02-04 3:45 ` Sameer Pujar
2021-02-04 3:45 ` Sameer Pujar
2021-02-03 22:31 ` Kuninori Morimoto
2021-02-03 22:31 ` Kuninori Morimoto
2021-02-04 3:39 ` Sameer Pujar
2021-02-04 3:39 ` Sameer Pujar
2021-02-03 16:09 ` [PATCH 2/2] ASoC: tegra: Add driver remove() callback Sameer Pujar
2021-02-03 16:09 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2g494b0.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.