From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greentime Hu <greentime.hu@sifive.com>,
palmer@dabbelt.com, linux-kernel@vger.kernel.org,
atish.patra@wdc.com, linux-riscv@lists.infradead.org,
paul.walmsley@sifive.com, anup@brainfault.org
Cc: Ulrich Hecht <uli+renesas@fpond.eu>, linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC PATCH] irqchip/sifive-plic: Fix getting wrong chip_data when interrupt is hierarchy
Date: Sun, 01 Nov 2020 17:52:06 +0100 [thread overview]
Message-ID: <87y2jl81ft.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <160423261831.76459.6853837344029171039.b4-ty@kernel.org>
On Sun, Nov 01 2020 at 12:10, Marc Zyngier wrote:
> On Thu, 29 Oct 2020 10:37:38 +0800, Greentime Hu wrote:
>> This oops is caused by a wrong chip_data and it is because plic_irq_unmask
>> uses irq_get_chip_data(irq_data->irq) to get the chip_data. However it may
>> get another irq_data with the same irq_data->irq if it is hierarchy.
>>
>> In this case, it will get irq_data of sifive_gpio_irqchip instead of
>> plic_chip so that it will get a wrong chip_data and then the wrong lmask
>> of it to cause this oops.
>>
>> [...]
>
> Applied to irq/irqchip-next, thanks!
That should go into urgent, the offending commit is in Linus tree already
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greentime Hu <greentime.hu@sifive.com>,
palmer@dabbelt.com, linux-kernel@vger.kernel.org,
atish.patra@wdc.com, linux-riscv@lists.infradead.org,
paul.walmsley@sifive.com, anup@brainfault.org
Cc: linux-renesas-soc@vger.kernel.org, Ulrich Hecht <uli+renesas@fpond.eu>
Subject: Re: [RFC PATCH] irqchip/sifive-plic: Fix getting wrong chip_data when interrupt is hierarchy
Date: Sun, 01 Nov 2020 17:52:06 +0100 [thread overview]
Message-ID: <87y2jl81ft.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <160423261831.76459.6853837344029171039.b4-ty@kernel.org>
On Sun, Nov 01 2020 at 12:10, Marc Zyngier wrote:
> On Thu, 29 Oct 2020 10:37:38 +0800, Greentime Hu wrote:
>> This oops is caused by a wrong chip_data and it is because plic_irq_unmask
>> uses irq_get_chip_data(irq_data->irq) to get the chip_data. However it may
>> get another irq_data with the same irq_data->irq if it is hierarchy.
>>
>> In this case, it will get irq_data of sifive_gpio_irqchip instead of
>> plic_chip so that it will get a wrong chip_data and then the wrong lmask
>> of it to cause this oops.
>>
>> [...]
>
> Applied to irq/irqchip-next, thanks!
That should go into urgent, the offending commit is in Linus tree already
Thanks,
tglx
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-11-01 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 2:37 [RFC PATCH] irqchip/sifive-plic: Fix getting wrong chip_data when interrupt is hierarchy Greentime Hu
2020-10-29 2:37 ` Greentime Hu
2020-10-28 16:09 ` Anup Patel
2020-10-28 16:09 ` Anup Patel
2020-10-29 21:43 ` Atish Patra
2020-10-29 21:43 ` Atish Patra
2020-11-01 12:10 ` Marc Zyngier
2020-11-01 12:10 ` Marc Zyngier
2020-11-01 16:52 ` Thomas Gleixner [this message]
2020-11-01 16:52 ` Thomas Gleixner
2020-11-06 2:02 ` Palmer Dabbelt
2020-11-06 2:02 ` Palmer Dabbelt
2020-11-01 17:00 ` [tip: irq/urgent] irqchip/sifive-plic: Fix chip_data access within a hierarchy tip-bot2 for Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2jl81ft.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=anup@brainfault.org \
--cc=atish.patra@wdc.com \
--cc=geert+renesas@glider.be \
--cc=greentime.hu@sifive.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.