From: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 1/2] dt/bindings: serial: bcm2835: add binding documentation for bcm2835-aux-uart
Date: Wed, 27 Jan 2016 22:39:54 -0800 [thread overview]
Message-ID: <87y4bacimd.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <4799423.86Gz9JKjiK@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> writes:
> On Monday 11 January 2016 14:57:46 Martin Sperl wrote:
>> > On 11.01.2016, at 13:21, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
>> >
>> > Please just add another patch to rename the existing uarts appropriately
>> > first, then add this one on top with the correct name.
>>
>> I can do that with the next incarnation of the patch.
>>
>> But would that not break dt-source files, that refer to uart0?
>> Is this not considered an API change as well or does this only apply
>> to the binary files?
>
> To clarify: I meant you should change the node name, not the label.
>
> The label is not part of the dtb data that gets passed to the kernel
> and can have any value, including "uart0".
>
> The node name is part of the dtb and should follow common naming
> conventions (per ePAPR), but the kernel doesn't actually care, so
> it won't break anything.
>
> There are cases where a bootloader relies on a particular node name
> in order to find a device node and patch its properties, but I don't
> think this is the case here.
Confirmed, the booloader source I have doesn't do anything with uart
nodes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] dt/bindings: serial: bcm2835: add binding documentation for bcm2835-aux-uart
Date: Wed, 27 Jan 2016 22:39:54 -0800 [thread overview]
Message-ID: <87y4bacimd.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <4799423.86Gz9JKjiK@wuerfel>
Arnd Bergmann <arnd@arndb.de> writes:
> On Monday 11 January 2016 14:57:46 Martin Sperl wrote:
>> > On 11.01.2016, at 13:21, Arnd Bergmann <arnd@arndb.de> wrote:
>> >
>> > Please just add another patch to rename the existing uarts appropriately
>> > first, then add this one on top with the correct name.
>>
>> I can do that with the next incarnation of the patch.
>>
>> But would that not break dt-source files, that refer to uart0?
>> Is this not considered an API change as well or does this only apply
>> to the binary files?
>
> To clarify: I meant you should change the node name, not the label.
>
> The label is not part of the dtb data that gets passed to the kernel
> and can have any value, including "uart0".
>
> The node name is part of the dtb and should follow common naming
> conventions (per ePAPR), but the kernel doesn't actually care, so
> it won't break anything.
>
> There are cases where a bootloader relies on a particular node name
> in order to find a device node and patch its properties, but I don't
> think this is the case here.
Confirmed, the booloader source I have doesn't do anything with uart
nodes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/797abe9b/attachment.sig>
next prev parent reply other threads:[~2016-01-28 6:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 13:07 [PATCH V2 0/2] serial: bcm2835: add bcm2835 auxiliar uart driver kernel-TqfNSX0MhmxHKSADF0wUEw
2016-01-09 13:07 ` kernel at martin.sperl.org
[not found] ` <1452344854-2576-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-09 13:07 ` [PATCH V2 1/2] dt/bindings: serial: bcm2835: add binding documentation for bcm2835-aux-uart kernel-TqfNSX0MhmxHKSADF0wUEw
2016-01-09 13:07 ` kernel at martin.sperl.org
[not found] ` <1452344854-2576-2-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-09 20:53 ` Arnd Bergmann
2016-01-09 20:53 ` Arnd Bergmann
2016-01-10 10:49 ` Martin Sperl
2016-01-10 10:49 ` Martin Sperl
[not found] ` <175E89CE-581C-48AB-B7FF-6E9A41B033D5-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-11 12:21 ` Arnd Bergmann
2016-01-11 12:21 ` Arnd Bergmann
2016-01-11 13:57 ` Martin Sperl
2016-01-11 13:57 ` Martin Sperl
[not found] ` <6035A0DD-AD61-48F7-B641-272BB23F3CD8-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-11 14:40 ` Arnd Bergmann
2016-01-11 14:40 ` Arnd Bergmann
2016-01-28 6:39 ` Eric Anholt [this message]
2016-01-28 6:39 ` Eric Anholt
2016-01-09 13:07 ` [PATCH V2 2/2] serial: bcm2835: add driver " kernel-TqfNSX0MhmxHKSADF0wUEw
2016-01-09 13:07 ` kernel at martin.sperl.org
[not found] ` <1452344854-2576-3-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-11 9:52 ` Stefan Wahren
2016-01-11 9:52 ` Stefan Wahren
2016-01-11 15:25 ` Peter Korsgaard
2016-01-11 15:25 ` Peter Korsgaard
2016-01-10 15:05 ` [PATCH V2 0/2] serial: bcm2835: add bcm2835 auxiliar uart driver Stefan Wahren
2016-01-10 15:05 ` Stefan Wahren
[not found] ` <1057226922.507844.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-01-10 15:45 ` Martin Sperl
2016-01-10 15:45 ` Martin Sperl
[not found] ` <46FD7886-510C-4F0F-A039-500D5438207B-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-01-10 21:17 ` Stefan Wahren
2016-01-10 21:17 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4bacimd.fsf@eliezer.anholt.net \
--to=eric-whkq6xtqapystnjn9+bgxg@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
--cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.