From: Ben Gamari <ben@smart-cactus.org> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Sudeep Holla <Sudeep.Holla@arm.com>, Thomas Abraham <thomas.ab@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Lukasz Majewski <l.majewski@samsung.com>, Heiko Stuebner <heiko@sntech.de>, Chanwoo Choi <cw00.choi@samsung.com>, Kevin Hilman <khilman@linaro.org>, Javier Martinez Canillas <javier@dowhile0.org>, Tobias Jakobi <tjakobi@math.uni-bielefeld.de>, Anand Moon <linux.amoon@gmail.com>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com Subject: Re: [PATCH v5 0/12] cpufreq: Add support for Exynos 5800, 5420, and 5422 Date: Thu, 03 Dec 2015 12:21:33 +0100 [thread overview] Message-ID: <87y4db3hhe.fsf@smart-cactus.org> (raw) In-Reply-To: <20151203103703.GC2097@ubuntu> [-- Attachment #1: Type: text/plain, Size: 1889 bytes --] Viresh Kumar <viresh.kumar@linaro.org> writes: > On 03-12-15, 11:26, Ben Gamari wrote: >> Viresh Kumar <viresh.kumar@linaro.org> writes: >> > But, before I start reviewing this series, I have few comments. >> > - We weren't able to use cpufreq-dt driver for big LITTLE platforms >> > earlier, as it never had multi cluster support and we wanted >> > clock-sharing information via DT. >> >> Fair enough. >> >> > - That is all fixed now. >> >> I did not see any mention of this in the cpufreq-dt driver binding >> documentation, otherwise I would have tried going this route. >> >> Do you have any references? I'd be happy to examine what would be >> necessary to go this route although, being an independent contributor, >> it may take time. > > You wouldn't find in cpufreq-dt documentation as its not specific to > that. I have seen you DT patches now, and you have created the OPP > tables mostly correctly. Just create the cpufreq-platform device for > cpufreq-dt instead of arm-big-little one. And it should just work. > Do you mean something along these lines? [1] >> Sounds reasonable to me. However, I'd just like to reiterate that this >> line of work can be pursued independently from the upstreaming of this >> series. > > I think this is the right time to upstream the right solution. Just > try it once, if you face lots of difficulties or issues, then we can > ofcourse see.. > Sure. I didn't realize things were so close to being functional. Thanks for the hint. I'll give it a shot next time my XU4 is free. > NOTE: Check how OPP nodes are required to be created now in > linux-next. They should be named like opp@<freq-hz>. Something I > noticed in your DTs. > I've fixed this in the branch. Thanks again. Cheers, - Ben [1] https://github.com/bgamari/linux/commit/285778aaff464d4dcf152f3e9e0df3d8c6909576 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 472 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: ben@smart-cactus.org (Ben Gamari) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 0/12] cpufreq: Add support for Exynos 5800, 5420, and 5422 Date: Thu, 03 Dec 2015 12:21:33 +0100 [thread overview] Message-ID: <87y4db3hhe.fsf@smart-cactus.org> (raw) In-Reply-To: <20151203103703.GC2097@ubuntu> Viresh Kumar <viresh.kumar@linaro.org> writes: > On 03-12-15, 11:26, Ben Gamari wrote: >> Viresh Kumar <viresh.kumar@linaro.org> writes: >> > But, before I start reviewing this series, I have few comments. >> > - We weren't able to use cpufreq-dt driver for big LITTLE platforms >> > earlier, as it never had multi cluster support and we wanted >> > clock-sharing information via DT. >> >> Fair enough. >> >> > - That is all fixed now. >> >> I did not see any mention of this in the cpufreq-dt driver binding >> documentation, otherwise I would have tried going this route. >> >> Do you have any references? I'd be happy to examine what would be >> necessary to go this route although, being an independent contributor, >> it may take time. > > You wouldn't find in cpufreq-dt documentation as its not specific to > that. I have seen you DT patches now, and you have created the OPP > tables mostly correctly. Just create the cpufreq-platform device for > cpufreq-dt instead of arm-big-little one. And it should just work. > Do you mean something along these lines? [1] >> Sounds reasonable to me. However, I'd just like to reiterate that this >> line of work can be pursued independently from the upstreaming of this >> series. > > I think this is the right time to upstream the right solution. Just > try it once, if you face lots of difficulties or issues, then we can > ofcourse see.. > Sure. I didn't realize things were so close to being functional. Thanks for the hint. I'll give it a shot next time my XU4 is free. > NOTE: Check how OPP nodes are required to be created now in > linux-next. They should be named like opp@<freq-hz>. Something I > noticed in your DTs. > I've fixed this in the branch. Thanks again. Cheers, - Ben [1] https://github.com/bgamari/linux/commit/285778aaff464d4dcf152f3e9e0df3d8c6909576 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 472 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151203/b1e97e1c/attachment.sig>
next prev parent reply other threads:[~2015-12-03 11:21 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-02 21:19 [PATCH v5 0/12] cpufreq: Add support for Exynos 5800, 5420, and 5422 Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 01/12] cpufreq: arm_big_little: add cluster regulator support Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-03 4:41 ` Anand Moon 2015-12-03 4:41 ` Anand Moon 2015-12-03 4:41 ` Anand Moon 2015-12-03 4:41 ` Anand Moon 2015-12-02 21:19 ` [PATCH 02/12] clk: samsung: exynos5420: add cpu clock configuration data and instantiate cpu clock Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-03 6:08 ` Krzysztof Kozlowski 2015-12-03 6:08 ` Krzysztof Kozlowski 2015-12-03 10:30 ` Ben Gamari 2015-12-03 10:30 ` Ben Gamari 2015-12-04 2:25 ` Krzysztof Kozlowski 2015-12-04 2:25 ` Krzysztof Kozlowski 2015-12-02 21:19 ` [PATCH 03/12] ARM: dts: Exynos5420: add CPU OPP and regulator supply property Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 04/12] ARM: Exynos: use generic cpufreq driver for Exynos5420 Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 05/12] clk: samsung: exynos5800: fix cpu clock configuration data Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 06/12] ARM: dts: Exynos5800: fix CPU OPP Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 07/12] ARM: dts: Exynos5422: fix OPP tables Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 08/12] ARM: Exynos: use generic cpufreq driver for Exynos5800 Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 09/12] ARM: dts: Exynos5420/5800: add cluster regulator supply properties Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 10/12] cpufreq: arm-big-little: accept operating-points-v2 nodes Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 11/12] cpufreq: arm-big-little: clarify frequency units Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-03 14:22 ` Jon Medhurst (Tixy) 2015-12-03 14:22 ` Jon Medhurst (Tixy) 2015-12-03 14:22 ` Jon Medhurst (Tixy) 2015-12-03 14:37 ` Ben Gamari 2015-12-03 14:37 ` Ben Gamari 2015-12-03 14:37 ` Ben Gamari 2015-12-02 21:19 ` [PATCH 12/12] cpufreq: arm-big-little: warn on invalid regulator Ben Gamari 2015-12-02 21:19 ` Ben Gamari 2015-12-03 6:05 ` [PATCH v5 0/12] cpufreq: Add support for Exynos 5800, 5420, and 5422 Viresh Kumar 2015-12-03 6:05 ` Viresh Kumar 2015-12-03 10:26 ` Ben Gamari 2015-12-03 10:26 ` Ben Gamari 2015-12-03 10:37 ` Viresh Kumar 2015-12-03 10:37 ` Viresh Kumar 2015-12-03 11:21 ` Ben Gamari [this message] 2015-12-03 11:21 ` Ben Gamari 2015-12-03 11:25 ` Viresh Kumar 2015-12-03 11:25 ` Viresh Kumar 2015-12-07 21:19 ` Ben Gamari 2015-12-07 21:19 ` Ben Gamari 2015-12-03 11:05 ` Sudeep Holla 2015-12-03 11:05 ` Sudeep Holla 2015-12-03 11:24 ` Viresh Kumar 2015-12-03 11:24 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87y4db3hhe.fsf@smart-cactus.org \ --to=ben@smart-cactus.org \ --cc=Sudeep.Holla@arm.com \ --cc=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=heiko@sntech.de \ --cc=javier@dowhile0.org \ --cc=k.kozlowski@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=kgene@kernel.org \ --cc=khilman@linaro.org \ --cc=l.majewski@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux.amoon@gmail.com \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=thomas.ab@samsung.com \ --cc=tjakobi@math.uni-bielefeld.de \ --cc=tomasz.figa@gmail.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.