From: Jani Nikula <jani.nikula@linux.intel.com>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>, keescook@chromium.org
Cc: luc.vanoostenryck@gmail.com, nathan@kernel.org,
ndesaulniers@google.com, trix@redhat.com, dlatypov@google.com,
vitor@massaru.org, gustavoars@kernel.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
tvrtko.ursulin@linux.intel.com, airlied@linux.ie,
daniel@ffwll.ch, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-sparse@vger.kernel.org, arnd@kernel.org
Subject: Re: [PATCH v3] overflow: Introduce overflows_type() and castable_to_type()
Date: Thu, 13 Oct 2022 11:12:29 +0300 [thread overview]
Message-ID: <87zge0rvki.fsf@intel.com> (raw)
In-Reply-To: <20221013064956.1548741-1-gwan-gyeong.mun@intel.com>
On Thu, 13 Oct 2022, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> wrote:
> diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
> index 0d98c9bc75da..44da9d190057 100644
> --- a/lib/overflow_kunit.c
> +++ b/lib/overflow_kunit.c
> @@ -16,6 +16,11 @@
> #include <linux/types.h>
> #include <linux/vmalloc.h>
>
> +/* We're expecting to do a lot of "always true" or "always false" tests. */
> +#ifdef CONFIG_CC_IS_CLANG
> +#pragma clang diagnostic ignored "-Wtautological-constant-out-of-range-compare"
> +#endif
I thought #pragma was discouraged. I didn't try this, but would
something like this work in the Makefile instead:
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
Sorry for not noticing before. If you all think pragma is fine, sorry
for the noise.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>, keescook@chromium.org
Cc: tvrtko.ursulin@linux.intel.com, arnd@kernel.org,
airlied@linux.ie, trix@redhat.com, dlatypov@google.com,
llvm@lists.linux.dev, ndesaulniers@google.com,
gustavoars@kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, nathan@kernel.org,
linux-sparse@vger.kernel.org, linux-hardening@vger.kernel.org,
rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org,
vitor@massaru.org, luc.vanoostenryck@gmail.com
Subject: Re: [PATCH v3] overflow: Introduce overflows_type() and castable_to_type()
Date: Thu, 13 Oct 2022 11:12:29 +0300 [thread overview]
Message-ID: <87zge0rvki.fsf@intel.com> (raw)
In-Reply-To: <20221013064956.1548741-1-gwan-gyeong.mun@intel.com>
On Thu, 13 Oct 2022, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> wrote:
> diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
> index 0d98c9bc75da..44da9d190057 100644
> --- a/lib/overflow_kunit.c
> +++ b/lib/overflow_kunit.c
> @@ -16,6 +16,11 @@
> #include <linux/types.h>
> #include <linux/vmalloc.h>
>
> +/* We're expecting to do a lot of "always true" or "always false" tests. */
> +#ifdef CONFIG_CC_IS_CLANG
> +#pragma clang diagnostic ignored "-Wtautological-constant-out-of-range-compare"
> +#endif
I thought #pragma was discouraged. I didn't try this, but would
something like this work in the Makefile instead:
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
Sorry for not noticing before. If you all think pragma is fine, sorry
for the noise.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>, keescook@chromium.org
Cc: arnd@kernel.org, airlied@linux.ie, trix@redhat.com,
dlatypov@google.com, llvm@lists.linux.dev,
ndesaulniers@google.com, gustavoars@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nathan@kernel.org, linux-sparse@vger.kernel.org,
linux-hardening@vger.kernel.org, daniel@ffwll.ch,
rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org,
vitor@massaru.org, luc.vanoostenryck@gmail.com
Subject: Re: [Intel-gfx] [PATCH v3] overflow: Introduce overflows_type() and castable_to_type()
Date: Thu, 13 Oct 2022 11:12:29 +0300 [thread overview]
Message-ID: <87zge0rvki.fsf@intel.com> (raw)
In-Reply-To: <20221013064956.1548741-1-gwan-gyeong.mun@intel.com>
On Thu, 13 Oct 2022, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> wrote:
> diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
> index 0d98c9bc75da..44da9d190057 100644
> --- a/lib/overflow_kunit.c
> +++ b/lib/overflow_kunit.c
> @@ -16,6 +16,11 @@
> #include <linux/types.h>
> #include <linux/vmalloc.h>
>
> +/* We're expecting to do a lot of "always true" or "always false" tests. */
> +#ifdef CONFIG_CC_IS_CLANG
> +#pragma clang diagnostic ignored "-Wtautological-constant-out-of-range-compare"
> +#endif
I thought #pragma was discouraged. I didn't try this, but would
something like this work in the Makefile instead:
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
Sorry for not noticing before. If you all think pragma is fine, sorry
for the noise.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-10-13 8:12 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 19:11 [PATCH v2] overflow: Introduce overflows_type() and castable_to_type() Kees Cook
2022-09-26 19:11 ` [Intel-gfx] " Kees Cook
2022-09-26 19:11 ` Kees Cook
2022-09-26 20:17 ` Nick Desaulniers
2022-09-26 20:17 ` [Intel-gfx] " Nick Desaulniers
2022-09-26 20:17 ` Nick Desaulniers
2022-09-26 21:07 ` Kees Cook
2022-09-26 21:07 ` [Intel-gfx] " Kees Cook
2022-09-26 21:07 ` Kees Cook
2022-09-27 6:45 ` Arnd Bergmann
2022-09-27 6:45 ` [Intel-gfx] " Arnd Bergmann
2022-09-27 6:45 ` Arnd Bergmann
2022-09-27 0:27 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-09-27 8:29 ` [PATCH v2] " Gwan-gyeong Mun
2022-09-27 8:29 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-27 8:29 ` Gwan-gyeong Mun
2022-09-27 23:36 ` [Intel-gfx] " kernel test robot
2022-09-27 23:36 ` kernel test robot
2022-09-27 23:36 ` kernel test robot
2022-09-28 8:19 ` Gwan-gyeong Mun
2022-09-28 8:19 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:19 ` Gwan-gyeong Mun
2022-09-29 3:24 ` [Intel-gfx] " kernel test robot
2022-09-29 3:24 ` kernel test robot
2022-09-29 3:24 ` kernel test robot
2022-09-29 8:32 ` kernel test robot
2022-09-29 8:32 ` kernel test robot
2022-09-29 8:32 ` kernel test robot
2022-10-13 6:49 ` [PATCH v3] " Gwan-gyeong Mun
2022-10-13 6:49 ` Gwan-gyeong Mun
2022-10-13 6:49 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-13 8:12 ` Jani Nikula [this message]
2022-10-13 8:12 ` Jani Nikula
2022-10-13 8:12 ` Jani Nikula
2022-10-13 8:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for overflow: Introduce overflows_type() and castable_to_type() (rev2) Patchwork
2022-10-21 8:33 ` [PATCH v4] overflow: Introduce overflows_type() and castable_to_type() Gwan-gyeong Mun
2022-10-21 8:33 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-21 8:33 ` Gwan-gyeong Mun
2022-10-21 16:06 ` Nathan Chancellor
2022-10-21 16:06 ` [Intel-gfx] " Nathan Chancellor
2022-10-21 16:06 ` Nathan Chancellor
2022-10-21 12:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for overflow: Introduce overflows_type() and castable_to_type() (rev3) Patchwork
2022-10-21 12:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-21 12:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-21 19:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-24 20:11 ` [PATCH v5] overflow: Introduce overflows_type() and castable_to_type() Gwan-gyeong Mun
2022-10-24 20:11 ` Gwan-gyeong Mun
2022-10-24 20:11 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-29 5:55 ` Gwan-gyeong Mun
2022-10-29 5:55 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-29 5:55 ` Gwan-gyeong Mun
2022-10-29 7:32 ` Kees Cook
2022-10-29 7:32 ` [Intel-gfx] " Kees Cook
2022-10-29 7:32 ` Kees Cook
2022-10-29 8:01 ` Gwan-gyeong Mun
2022-10-29 8:01 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-29 8:01 ` Gwan-gyeong Mun
2022-11-01 23:06 ` Kees Cook
2022-11-01 23:06 ` [Intel-gfx] " Kees Cook
2022-11-02 11:27 ` Gwan-gyeong Mun
2022-11-02 11:27 ` [Intel-gfx] " Gwan-gyeong Mun
2022-11-02 11:27 ` Gwan-gyeong Mun
2022-11-02 11:52 ` Rasmus Villemoes
2022-11-02 11:52 ` [Intel-gfx] " Rasmus Villemoes
2022-11-02 11:52 ` Rasmus Villemoes
2022-11-02 19:33 ` Kees Cook
2022-11-02 19:33 ` [Intel-gfx] " Kees Cook
2022-11-02 19:33 ` Kees Cook
2022-10-25 0:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for overflow: Introduce overflows_type() and castable_to_type() (rev4) Patchwork
2022-10-25 0:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-25 0:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zge0rvki.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=arnd@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luc.vanoostenryck@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rodrigo.vivi@intel.com \
--cc=trix@redhat.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.