From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: David Airlie <airlied@linux.ie>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind
Date: Tue, 15 Jun 2021 16:03:27 +0200 [thread overview]
Message-ID: <87zgvrw7gw.fsf@redhat.com> (raw)
In-Reply-To: <20210615133519.754763-5-hch@lst.de>
On Tue, Jun 15 2021, Christoph Hellwig <hch@lst.de> wrote:
> EPROBE_DEFER is an internal kernel error code and it should not be leaked
> to userspace via the bind_store() sysfs. Userspace doesn't have this
> constant and cannot understand it.
>
> Further, it doesn't really make sense to have userspace trigger a deferred
> probe via bind_store(), which could eventually succeed, while
> simultaneously returning an error back.
>
> Resolve this by splitting driver_probe_device so that the version used
> by the sysfs binding that turns EPROBE_DEFER into -EAGAIN, while the one
> used for internally binding keeps the error code, and calls
> driver_deferred_probe_add where needed. This also allows to nicely split
> out the defer_all_probes / probe_count checks so that they actually allow
> for full device_{block,unblock}_probing protection while not bothering
> the sysfs bind case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/base/dd.c | 78 +++++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 36 deletions(-)
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind
Date: Tue, 15 Jun 2021 16:03:27 +0200 [thread overview]
Message-ID: <87zgvrw7gw.fsf@redhat.com> (raw)
In-Reply-To: <20210615133519.754763-5-hch@lst.de>
On Tue, Jun 15 2021, Christoph Hellwig <hch@lst.de> wrote:
> EPROBE_DEFER is an internal kernel error code and it should not be leaked
> to userspace via the bind_store() sysfs. Userspace doesn't have this
> constant and cannot understand it.
>
> Further, it doesn't really make sense to have userspace trigger a deferred
> probe via bind_store(), which could eventually succeed, while
> simultaneously returning an error back.
>
> Resolve this by splitting driver_probe_device so that the version used
> by the sysfs binding that turns EPROBE_DEFER into -EAGAIN, while the one
> used for internally binding keeps the error code, and calls
> driver_deferred_probe_add where needed. This also allows to nicely split
> out the defer_all_probes / probe_count checks so that they actually allow
> for full device_{block,unblock}_probing protection while not bothering
> the sysfs bind case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/base/dd.c | 78 +++++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 36 deletions(-)
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind
Date: Tue, 15 Jun 2021 16:03:27 +0200 [thread overview]
Message-ID: <87zgvrw7gw.fsf@redhat.com> (raw)
In-Reply-To: <20210615133519.754763-5-hch@lst.de>
On Tue, Jun 15 2021, Christoph Hellwig <hch@lst.de> wrote:
> EPROBE_DEFER is an internal kernel error code and it should not be leaked
> to userspace via the bind_store() sysfs. Userspace doesn't have this
> constant and cannot understand it.
>
> Further, it doesn't really make sense to have userspace trigger a deferred
> probe via bind_store(), which could eventually succeed, while
> simultaneously returning an error back.
>
> Resolve this by splitting driver_probe_device so that the version used
> by the sysfs binding that turns EPROBE_DEFER into -EAGAIN, while the one
> used for internally binding keeps the error code, and calls
> driver_deferred_probe_add where needed. This also allows to nicely split
> out the defer_all_probes / probe_count checks so that they actually allow
> for full device_{block,unblock}_probing protection while not bothering
> the sysfs bind case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/base/dd.c | 78 +++++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 36 deletions(-)
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-15 14:03 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:35 Allow mdev drivers to directly create the vfio_device (v3) Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 13:35 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 13:35 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 13:53 ` Cornelia Huck
2021-06-15 13:53 ` [Intel-gfx] " Cornelia Huck
2021-06-15 13:53 ` Cornelia Huck
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-15 14:09 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-15 14:09 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:09 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
2021-06-16 20:20 ` [Intel-gfx] " Kirti Wankhede
2021-06-16 20:20 ` Kirti Wankhede
2021-06-15 13:35 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 13:35 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:03 ` Cornelia Huck [this message]
2021-06-15 14:03 ` Cornelia Huck
2021-06-15 14:03 ` Cornelia Huck
2021-06-15 19:36 ` Alex Williamson
2021-06-15 19:36 ` [Intel-gfx] " Alex Williamson
2021-06-15 19:36 ` Alex Williamson
2021-06-15 13:35 ` [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:10 ` Greg Kroah-Hartman
2021-06-15 14:10 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:10 ` Greg Kroah-Hartman
2021-06-15 13:35 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:10 ` Greg Kroah-Hartman
2021-06-15 14:10 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:10 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
2021-06-16 20:20 ` [Intel-gfx] " Kirti Wankhede
2021-06-16 20:20 ` Kirti Wankhede
2021-06-15 13:35 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:06 ` Cornelia Huck
2021-06-15 14:06 ` [Intel-gfx] " Cornelia Huck
2021-06-15 14:06 ` Cornelia Huck
2021-06-15 14:11 ` Greg Kroah-Hartman
2021-06-15 14:11 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:11 ` Greg Kroah-Hartman
2021-06-16 0:00 ` Jason Gunthorpe
2021-06-16 0:00 ` [Intel-gfx] " Jason Gunthorpe
2021-06-16 0:00 ` Jason Gunthorpe
2021-06-16 6:39 ` Greg Kroah-Hartman
2021-06-16 6:39 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-16 6:39 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
2021-06-16 20:20 ` [Intel-gfx] " Kirti Wankhede
2021-06-16 20:20 ` Kirti Wankhede
2021-06-15 13:35 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:11 ` Greg Kroah-Hartman
2021-06-15 14:11 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:11 ` Greg Kroah-Hartman
2021-06-16 20:20 ` Kirti Wankhede
2021-06-16 20:20 ` [Intel-gfx] " Kirti Wankhede
2021-06-16 20:20 ` Kirti Wankhede
2021-06-15 13:35 ` [PATCH 09/10] vfio/mdpy: " Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:12 ` Greg Kroah-Hartman
2021-06-15 14:12 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:12 ` Greg Kroah-Hartman
2021-06-15 13:35 ` [PATCH 10/10] vfio/mbochs: " Christoph Hellwig
2021-06-15 13:35 ` [Intel-gfx] " Christoph Hellwig
2021-06-15 14:12 ` Greg Kroah-Hartman
2021-06-15 14:12 ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15 14:12 ` Greg Kroah-Hartman
2021-06-15 14:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
2021-06-15 14:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-15 14:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-15 19:35 ` Allow mdev drivers to directly create the vfio_device (v3) Alex Williamson
2021-06-15 19:35 ` [Intel-gfx] " Alex Williamson
2021-06-15 19:35 ` Alex Williamson
2021-06-15 20:35 ` Jason Gunthorpe
2021-06-15 20:35 ` [Intel-gfx] " Jason Gunthorpe
2021-06-15 20:35 ` Jason Gunthorpe
2021-06-16 3:13 ` Christoph Hellwig
2021-06-16 3:13 ` [Intel-gfx] " Christoph Hellwig
2021-06-16 14:03 ` Jason Gunthorpe
2021-06-16 14:03 ` Jason Gunthorpe
2021-06-15 21:59 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-06-17 14:22 Allow mdev drivers to directly create the vfio_device (v4) Christoph Hellwig
2021-06-17 14:22 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind Christoph Hellwig
2021-06-14 15:08 Allow mdev drivers to directly create the vfio_device (v2 / alternative) Christoph Hellwig
2021-06-14 15:08 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind Christoph Hellwig
2021-06-14 22:43 ` Jason Gunthorpe
2021-06-14 22:43 ` Jason Gunthorpe
2021-06-08 0:55 [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind Jason Gunthorpe
2021-06-08 6:14 ` Christoph Hellwig
2021-06-08 7:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgvrw7gw.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.