From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
Shawn Lin <shawn.lin@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB
Date: Thu, 12 May 2016 00:36:20 +0200 [thread overview]
Message-ID: <8868581.lJFUogXGzy@phil> (raw)
In-Reply-To: <20160511223233.GB65449@google.com>
Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris:
> On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote:
> > Hi Brian,
> >
> > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris:
> > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob
> > > Herring,
> > > though it's still not merged.
> >
> > The commit message should describe the actual change not the volatile
> > environment surrounding it :-) .
> >
> > When I apply this patch the property-binding will have made it into a
> > maintainer-tree so is not valid anymore then. That is more material for
> > the "comment-section" below the "---"
>
> Of course. I think I just felt guilty without a commit message :)
I really prefer a (even simple) message being there - although I'm not as
strict as Greg and Felipe ;-) , and in cases like this I think something
like "enable the newly added emmc node on the rk3399 evaluation board"
should be sufficient.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB
Date: Thu, 12 May 2016 00:36:20 +0200 [thread overview]
Message-ID: <8868581.lJFUogXGzy@phil> (raw)
In-Reply-To: <20160511223233.GB65449-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris:
> On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote:
> > Hi Brian,
> >
> > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris:
> > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob
> > > Herring,
> > > though it's still not merged.
> >
> > The commit message should describe the actual change not the volatile
> > environment surrounding it :-) .
> >
> > When I apply this patch the property-binding will have made it into a
> > maintainer-tree so is not valid anymore then. That is more material for
> > the "comment-section" below the "---"
>
> Of course. I think I just felt guilty without a commit message :)
I really prefer a (even simple) message being there - although I'm not as
strict as Greg and Felipe ;-) , and in cases like this I think something
like "enable the newly added emmc node on the rk3399 evaluation board"
should be sufficient.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB
Date: Thu, 12 May 2016 00:36:20 +0200 [thread overview]
Message-ID: <8868581.lJFUogXGzy@phil> (raw)
In-Reply-To: <20160511223233.GB65449@google.com>
Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris:
> On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote:
> > Hi Brian,
> >
> > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris:
> > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob
> > > Herring,
> > > though it's still not merged.
> >
> > The commit message should describe the actual change not the volatile
> > environment surrounding it :-) .
> >
> > When I apply this patch the property-binding will have made it into a
> > maintainer-tree so is not valid anymore then. That is more material for
> > the "comment-section" below the "---"
>
> Of course. I think I just felt guilty without a commit message :)
I really prefer a (even simple) message being there - although I'm not as
strict as Greg and Felipe ;-) , and in cases like this I think something
like "enable the newly added emmc node on the rk3399 evaluation board"
should be sufficient.
Heiko
next prev parent reply other threads:[~2016-05-11 22:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 0:02 [PATCH 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris
2016-05-11 0:02 ` Brian Norris
2016-05-11 0:02 ` Brian Norris
2016-05-11 0:02 ` [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris
2016-05-11 0:02 ` Brian Norris
2016-05-11 0:02 ` Brian Norris
2016-05-11 0:59 ` Shawn Lin
2016-05-11 0:59 ` Shawn Lin
2016-05-11 0:59 ` Shawn Lin
2016-05-11 1:19 ` Brian Norris
2016-05-11 1:19 ` Brian Norris
2016-05-11 1:19 ` Brian Norris
2016-05-11 14:51 ` Heiko Stuebner
2016-05-11 14:51 ` Heiko Stuebner
2016-05-11 22:32 ` Brian Norris
2016-05-11 22:32 ` Brian Norris
2016-05-11 22:32 ` Brian Norris
2016-05-11 22:36 ` Heiko Stuebner [this message]
2016-05-11 22:36 ` Heiko Stuebner
2016-05-11 22:36 ` Heiko Stuebner
2016-05-11 1:17 ` [PATCH 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Shawn Lin
2016-05-11 1:17 ` Shawn Lin
2016-05-11 22:31 ` Brian Norris
2016-05-11 22:31 ` Brian Norris
2016-05-12 22:22 ` Brian Norris
2016-05-12 22:22 ` Brian Norris
2016-05-12 22:22 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8868581.lJFUogXGzy@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.