From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Date: Wed, 3 Jan 2018 12:52:22 -0600 [thread overview] Message-ID: <88a3511c-b3c5-9a92-8d31-33bc1619427b@linux.intel.com> (raw) In-Reply-To: <1514999340.7000.597.camel@linux.intel.com> On 01/03/2018 11:09 AM, Andy Shevchenko wrote: > On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote: >> The first patch solves issues reported by 0day with non-ACPI platforms >> >> The second patch implements what Linus, Takashi and Mark >> requested: a top-level selector defaulting to 'y' to easily filter all >> other options and with no impact on code generation. There should be >> no >> functionality change and will avoid breaking audio for people using >> make oldnoconfig. >> >> The rest of the patch series does a more in-depth cleanup. It was >> tested >> on Baytrail/Cherrytrail/Skylake platforms with no regressions >> observed and no reports of any compilation issues with 0-day or >> randconfig. >> >> The 5th patch is really the most important one, there were nested >> configs which made no sense to me. I don't know the history which led >> to such complicated stuff but simpler is better. >> >> Patches 6..7 are just clean-ups of the machine driver configs, >> for some reason there is no consistency in the settings so I tried to >> apply common sense and use the same rules. At Andy Shevchenko's >> suggestion, >> I also replaced the broken dependency on X86_INTEL_LPSS by >> MFD_INTEL_LPSS >> for Skylake+ machines. No regressions were identified with this >> change. >> >> Patch 9 is new in this series and are just cosmetic changes (comments >> and text simplification). >> >> Thanks to Vinod Koul for his contributions and comments. > Couple of nitpicks and seems patch 9 missed some (all?) comments to be > addressed. > > So, after fixing them: > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks Andy for the quick review. the last patch is new and indeed could be cleaned-up further, will send a v3. > >> Changes since v1: >> fixed more 0-day warnings for e.g. s390 non-ACPI compilation >> fixed use of depends >> fixed use of CONFIG_ >> fixed indentations as needed >> simplified text and comments >> >> Changes since RFCv2: >> Moved machine drivers to submenu >> Dropped SND_SOC_INTEL_COMMON since it was not needed >> Added more comments for if/endif >> Simplified text for options (dropped "ASoC Intel driver....") >> Fixed one 0-day warning >> >> Changes since initial RFC: >> Removed default n >> Added help text for HASWELL, BAYTRAIL (legacy) and SKYLAKE options >> Made top level machine driver selection dependent on >> INTEL_SST_TOPLEVEL. >> Added help text for PCI and HIFI2 platforms >> Replaced X86_INTEL_LPSS by MFD_INTEL_LPSS for Skylake+ devices >> Fixed a couple of indentation issues >> >> Pierre-Louis Bossart (8): >> ASoC: acpi: add missing includes for non-ACPI platforms >> ASoC: Intel: Fix Kconfig with top-level selector >> ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies >> ASoC: Intel: document what Kconfig options do >> ASoC: Intel: Fix nested/unnecessary Kconfig dependencies >> ASoC: Intel: boards: align Kconfig dependencies for >> Haswell/Broadwell >> ASoC: Intel: boards: align Kconfig configurations for HiFi2 >> ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs >> >> Vinod Koul (1): >> ASoC: Intel: kconfig: add some comments for if symbols >> >> include/sound/soc-acpi-intel-match.h | 1 + >> include/sound/soc-acpi.h | 1 + >> sound/soc/intel/Kconfig | 116 +++++++++++++++------ >> sound/soc/intel/Makefile | 2 +- >> sound/soc/intel/boards/Kconfig | 191 ++++++++++++++++++------ >> ----------- >> 5 files changed, 186 insertions(+), 125 deletions(-) >>
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, alsa-devel@alsa-project.org Cc: arnd@arndb.de, tiwai@suse.de, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, vinod.koul@intel.com, broonie@kernel.org, torvalds@linux-foundation.org Subject: Re: [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Date: Wed, 3 Jan 2018 12:52:22 -0600 [thread overview] Message-ID: <88a3511c-b3c5-9a92-8d31-33bc1619427b@linux.intel.com> (raw) In-Reply-To: <1514999340.7000.597.camel@linux.intel.com> On 01/03/2018 11:09 AM, Andy Shevchenko wrote: > On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote: >> The first patch solves issues reported by 0day with non-ACPI platforms >> >> The second patch implements what Linus, Takashi and Mark >> requested: a top-level selector defaulting to 'y' to easily filter all >> other options and with no impact on code generation. There should be >> no >> functionality change and will avoid breaking audio for people using >> make oldnoconfig. >> >> The rest of the patch series does a more in-depth cleanup. It was >> tested >> on Baytrail/Cherrytrail/Skylake platforms with no regressions >> observed and no reports of any compilation issues with 0-day or >> randconfig. >> >> The 5th patch is really the most important one, there were nested >> configs which made no sense to me. I don't know the history which led >> to such complicated stuff but simpler is better. >> >> Patches 6..7 are just clean-ups of the machine driver configs, >> for some reason there is no consistency in the settings so I tried to >> apply common sense and use the same rules. At Andy Shevchenko's >> suggestion, >> I also replaced the broken dependency on X86_INTEL_LPSS by >> MFD_INTEL_LPSS >> for Skylake+ machines. No regressions were identified with this >> change. >> >> Patch 9 is new in this series and are just cosmetic changes (comments >> and text simplification). >> >> Thanks to Vinod Koul for his contributions and comments. > Couple of nitpicks and seems patch 9 missed some (all?) comments to be > addressed. > > So, after fixing them: > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks Andy for the quick review. the last patch is new and indeed could be cleaned-up further, will send a v3. > >> Changes since v1: >> fixed more 0-day warnings for e.g. s390 non-ACPI compilation >> fixed use of depends >> fixed use of CONFIG_ >> fixed indentations as needed >> simplified text and comments >> >> Changes since RFCv2: >> Moved machine drivers to submenu >> Dropped SND_SOC_INTEL_COMMON since it was not needed >> Added more comments for if/endif >> Simplified text for options (dropped "ASoC Intel driver....") >> Fixed one 0-day warning >> >> Changes since initial RFC: >> Removed default n >> Added help text for HASWELL, BAYTRAIL (legacy) and SKYLAKE options >> Made top level machine driver selection dependent on >> INTEL_SST_TOPLEVEL. >> Added help text for PCI and HIFI2 platforms >> Replaced X86_INTEL_LPSS by MFD_INTEL_LPSS for Skylake+ devices >> Fixed a couple of indentation issues >> >> Pierre-Louis Bossart (8): >> ASoC: acpi: add missing includes for non-ACPI platforms >> ASoC: Intel: Fix Kconfig with top-level selector >> ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies >> ASoC: Intel: document what Kconfig options do >> ASoC: Intel: Fix nested/unnecessary Kconfig dependencies >> ASoC: Intel: boards: align Kconfig dependencies for >> Haswell/Broadwell >> ASoC: Intel: boards: align Kconfig configurations for HiFi2 >> ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs >> >> Vinod Koul (1): >> ASoC: Intel: kconfig: add some comments for if symbols >> >> include/sound/soc-acpi-intel-match.h | 1 + >> include/sound/soc-acpi.h | 1 + >> sound/soc/intel/Kconfig | 116 +++++++++++++++------ >> sound/soc/intel/Makefile | 2 +- >> sound/soc/intel/boards/Kconfig | 191 ++++++++++++++++++------ >> ----------- >> 5 files changed, 186 insertions(+), 125 deletions(-) >>
next prev parent reply other threads:[~2018-01-03 18:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-03 16:50 [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Pierre-Louis Bossart 2018-01-03 16:50 ` Pierre-Louis Bossart 2018-01-03 16:50 ` [PATCH v2 1/9] ASoC: acpi: add missing includes for non-ACPI platforms Pierre-Louis Bossart 2018-01-03 16:50 ` Pierre-Louis Bossart 2018-01-08 16:23 ` Applied "ASoC: acpi: add missing includes for non-ACPI platforms" to the asoc tree Mark Brown 2018-01-08 16:23 ` Mark Brown 2018-01-03 16:50 ` [PATCH v2 2/9] ASoC: Intel: Fix Kconfig with top-level selector Pierre-Louis Bossart 2018-01-08 16:22 ` Applied "ASoC: Intel: Fix Kconfig with top-level selector" to the asoc tree Mark Brown 2018-01-08 16:22 ` Mark Brown 2018-01-03 16:50 ` [PATCH v2 3/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart 2018-01-03 16:50 ` Pierre-Louis Bossart 2018-01-08 16:22 ` Applied "ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies" to the asoc tree Mark Brown 2018-01-08 16:22 ` Mark Brown 2018-01-03 16:50 ` [PATCH v2 4/9] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart 2018-01-03 16:50 ` Pierre-Louis Bossart 2018-01-08 16:22 ` Applied "ASoC: Intel: document what Kconfig options do" to the asoc tree Mark Brown 2018-01-08 16:22 ` Mark Brown 2018-01-03 16:50 ` [PATCH v2 5/9] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart 2018-01-03 16:50 ` Pierre-Louis Bossart 2018-01-03 16:56 ` Andy Shevchenko 2018-01-03 16:56 ` Andy Shevchenko 2018-01-03 18:09 ` Andy Shevchenko 2018-01-03 16:50 ` [PATCH v2 6/9] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart 2018-01-03 16:50 ` [PATCH v2 7/9] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart 2018-01-08 16:21 ` Applied "ASoC: Intel: boards: align Kconfig configurations for HiFi2" to the asoc tree Mark Brown 2018-01-08 16:21 ` Mark Brown 2018-01-03 16:50 ` [PATCH v2 8/9] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart 2018-01-03 17:00 ` Andy Shevchenko 2018-01-03 17:00 ` Andy Shevchenko 2018-01-03 16:50 ` [PATCH v2 9/9] ASoC: Intel: kconfig: add some comments for if symbols Pierre-Louis Bossart 2018-01-03 17:07 ` Andy Shevchenko 2018-01-03 19:25 ` Randy Dunlap 2018-01-03 19:25 ` Randy Dunlap 2018-01-03 19:51 ` Pierre-Louis Bossart 2018-01-03 17:09 ` [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Andy Shevchenko 2018-01-03 18:52 ` Pierre-Louis Bossart [this message] 2018-01-03 18:52 ` Pierre-Louis Bossart 2018-01-03 19:10 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88a3511c-b3c5-9a92-8d31-33bc1619427b@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tiwai@suse.de \ --cc=torvalds@linux-foundation.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.