From: Randy Dunlap <rdunlap@infradead.org>
To: Alistair Francis <alistair@alistair23.me>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: andreas@kemnade.info, alistair23@gmail.com,
dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
robh+dt@kernel.org, rydberg@bitmath.org,
mylene.josserand@free-electrons.com,
"Mylène Josserand" <mylene.josserand@bootlin.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 25 Oct 2021 13:10:38 -0700 [thread overview]
Message-ID: <896cd7b2-57c8-e777-0e12-4f319c43f49e@infradead.org> (raw)
In-Reply-To: <20211025114214.44617-2-alistair@alistair23.me>
On 10/25/21 4:42 AM, Alistair Francis wrote:
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index d4e74738c5a8..231cb0c1750b 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -284,6 +284,20 @@ config TOUCHSCREEN_CYTTSP4_SPI
> To compile this driver as a module, choose M here: the
> module will be called cyttsp4_spi.
>
> +config TOUCHSCREEN_CYTTSP5
> + tristate "Cypress TrueTouch Gen5 Touchscreen Driver"
> + depends on OF
> + select REGMAP_I2C
> + select CRC_ITU_T
> + help
> + Driver for Parade TrueTouch Standard Product
> + Generation 5 touchscreen controllers.
> + I2C bus interface support only.
> + Say Y here if you have a Cypress Gen5 touchscreen.
> + If unsure, say N.
> + To compile this driver as a module, choose M here: the
> + module will be called cyttsp5.
Hi,
Why is there no line:
depends on I2C
here?
thanks.
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Alistair Francis <alistair@alistair23.me>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: andreas@kemnade.info, alistair23@gmail.com,
dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
robh+dt@kernel.org, rydberg@bitmath.org,
mylene.josserand@free-electrons.com,
"Mylène Josserand" <mylene.josserand@bootlin.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 25 Oct 2021 13:10:38 -0700 [thread overview]
Message-ID: <896cd7b2-57c8-e777-0e12-4f319c43f49e@infradead.org> (raw)
In-Reply-To: <20211025114214.44617-2-alistair@alistair23.me>
On 10/25/21 4:42 AM, Alistair Francis wrote:
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index d4e74738c5a8..231cb0c1750b 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -284,6 +284,20 @@ config TOUCHSCREEN_CYTTSP4_SPI
> To compile this driver as a module, choose M here: the
> module will be called cyttsp4_spi.
>
> +config TOUCHSCREEN_CYTTSP5
> + tristate "Cypress TrueTouch Gen5 Touchscreen Driver"
> + depends on OF
> + select REGMAP_I2C
> + select CRC_ITU_T
> + help
> + Driver for Parade TrueTouch Standard Product
> + Generation 5 touchscreen controllers.
> + I2C bus interface support only.
> + Say Y here if you have a Cypress Gen5 touchscreen.
> + If unsure, say N.
> + To compile this driver as a module, choose M here: the
> + module will be called cyttsp5.
Hi,
Why is there no line:
depends on I2C
here?
thanks.
--
~Randy
next prev parent reply other threads:[~2021-10-25 20:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 11:42 [PATCH 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2021-10-25 11:42 ` Alistair Francis
2021-10-25 11:42 ` [PATCH 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2021-10-25 11:42 ` Alistair Francis
2021-10-25 20:10 ` Randy Dunlap [this message]
2021-10-25 20:10 ` Randy Dunlap
2021-10-27 3:45 ` kernel test robot
2021-10-27 3:45 ` kernel test robot
2021-10-27 3:45 ` kernel test robot
2021-10-25 11:42 ` [PATCH 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Alistair Francis
2021-10-25 11:42 ` Alistair Francis
2021-10-25 18:16 ` Rob Herring
2021-10-25 18:16 ` Rob Herring
2021-10-25 23:18 ` Linus Walleij
2021-10-25 23:18 ` Linus Walleij
2021-10-26 7:16 ` Andreas Kemnade
2021-10-26 7:16 ` Andreas Kemnade
2021-10-27 12:28 ` Alistair Francis
2021-10-27 12:28 ` Alistair Francis
2021-10-31 16:49 ` Andreas Kemnade
2021-10-31 16:49 ` Andreas Kemnade
2021-10-25 11:42 ` [PATCH 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2021-10-25 11:42 ` Alistair Francis
2021-10-25 11:42 ` [PATCH 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5 Alistair Francis
2021-10-25 11:42 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896cd7b2-57c8-e777-0e12-4f319c43f49e@infradead.org \
--to=rdunlap@infradead.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mylene.josserand@bootlin.com \
--cc=mylene.josserand@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.