From: Zeng Heng <zengheng4@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <shuah@kernel.org>, <catalin.marinas@arm.com>, <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kselftest@vger.kernel.org>, <xiexiuqi@huawei.com>
Subject: Re: [PATCH -next 3/4] kselftest/arm64: add pmull feature to hwcap test
Date: Tue, 15 Aug 2023 11:57:45 +0800 [thread overview]
Message-ID: <89d94875-5267-a2aa-a2aa-38f4b10f0e7e@huawei.com> (raw)
In-Reply-To: <3864eda1-0d02-42a2-ae9c-0d1eb3195a19@sirena.org.uk>
在 2023/8/15 0:38, Mark Brown 写道:
> On Mon, Aug 14, 2023 at 10:17:46AM +0800, Zeng Heng wrote:
>
>> asm volatile("mrs x0, S3_3_C2_C4_0" : : : "x0");
>> @@ -359,6 +365,13 @@ static const struct hwcap_data {
>> .cpuinfo = "rng",
>> .sigill_fn = rng_sigill,
>> },
>> + {
>> + .name = "PMULL",
>> + .at_hwcap = AT_HWCAP,
>> + .hwcap_bit = HWCAP_PMULL,
>> + .cpuinfo = "pmull",
>> + .sigill_fn = pmull_sigill,
>> + },
> Please keep the table alphabatically sorted - the function is in the
> right place but this seems to have got reordered.
Oops, sorry for that. I would update v2 and resend with your reviewed
tag soon.
Thanks for your review.
Zeng Heng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Zeng Heng <zengheng4@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <shuah@kernel.org>, <catalin.marinas@arm.com>, <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kselftest@vger.kernel.org>, <xiexiuqi@huawei.com>
Subject: Re: [PATCH -next 3/4] kselftest/arm64: add pmull feature to hwcap test
Date: Tue, 15 Aug 2023 11:57:45 +0800 [thread overview]
Message-ID: <89d94875-5267-a2aa-a2aa-38f4b10f0e7e@huawei.com> (raw)
In-Reply-To: <3864eda1-0d02-42a2-ae9c-0d1eb3195a19@sirena.org.uk>
在 2023/8/15 0:38, Mark Brown 写道:
> On Mon, Aug 14, 2023 at 10:17:46AM +0800, Zeng Heng wrote:
>
>> asm volatile("mrs x0, S3_3_C2_C4_0" : : : "x0");
>> @@ -359,6 +365,13 @@ static const struct hwcap_data {
>> .cpuinfo = "rng",
>> .sigill_fn = rng_sigill,
>> },
>> + {
>> + .name = "PMULL",
>> + .at_hwcap = AT_HWCAP,
>> + .hwcap_bit = HWCAP_PMULL,
>> + .cpuinfo = "pmull",
>> + .sigill_fn = pmull_sigill,
>> + },
> Please keep the table alphabatically sorted - the function is in the
> right place but this seems to have got reordered.
Oops, sorry for that. I would update v2 and resend with your reviewed
tag soon.
Thanks for your review.
Zeng Heng
next prev parent reply other threads:[~2023-08-15 3:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 2:17 [PATCH -next 0/4] kselftest/arm64: Add crypto-related feature checks to hwcap test Zeng Heng
2023-08-14 2:17 ` Zeng Heng
2023-08-14 2:17 ` [PATCH -next 1/4] kselftest/arm64: add SHA1 and related features " Zeng Heng
2023-08-14 2:17 ` Zeng Heng
2023-08-14 2:17 ` [PATCH -next 2/4] kselftest/arm64: add AES feature check " Zeng Heng
2023-08-14 2:17 ` Zeng Heng
2023-08-14 2:17 ` [PATCH -next 3/4] kselftest/arm64: add pmull feature " Zeng Heng
2023-08-14 2:17 ` Zeng Heng
2023-08-14 16:38 ` Mark Brown
2023-08-14 16:38 ` Mark Brown
2023-08-15 3:57 ` Zeng Heng [this message]
2023-08-15 3:57 ` Zeng Heng
2023-08-14 2:17 ` [PATCH -next 4/4] kselftest/arm64: add jscvt " Zeng Heng
2023-08-14 2:17 ` Zeng Heng
2023-08-14 16:41 ` [PATCH -next 0/4] kselftest/arm64: Add crypto-related feature checks " Mark Brown
2023-08-14 16:41 ` Mark Brown
2023-08-15 3:58 Zeng Heng
2023-08-15 3:58 ` [PATCH -next 3/4] kselftest/arm64: add pmull feature " Zeng Heng
2023-08-15 3:58 ` Zeng Heng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d94875-5267-a2aa-a2aa-38f4b10f0e7e@huawei.com \
--to=zengheng4@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.