All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Maik Broemme <mbroemme@libmpq.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 15/18] video: fbdev: intelfb: Move inline before return type
Date: Wed,  5 Jul 2017 13:02:24 -0700	[thread overview]
Message-ID: <8ba151a1fdc84e42cbf4aafc798513c0158edee1.1499284835.git.joe@perches.com> (raw)
In-Reply-To: <cover.1499284835.git.joe@perches.com>

Make the code like the rest of the kernel.

But there is an oddity here because the inline should probably be removed.

It's an extern function in intelfb.h and it is used in intelfbdrv.c and
intelfbhw.c.

The inline is kept here as I suppose it's possible for some compiler to
make the uses inline in intelfbdrv and and also create an external function
for intelfbhw.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400a86c..ffc391208b27 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -907,7 +907,7 @@ static void intelfb_pci_unregister(struct pci_dev *pdev)
  *                       helper functions                      *
  ***************************************************************/
 
-int __inline__ intelfb_var_to_depth(const struct fb_var_screeninfo *var)
+__inline__ int intelfb_var_to_depth(const struct fb_var_screeninfo *var)
 {
 	DBG_MSG("intelfb_var_to_depth: bpp: %d, green.length is %d\n",
 		var->bits_per_pixel, var->green.length);
-- 
2.10.0.rc2.1.g053435c

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Maik Broemme <mbroemme@libmpq.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 15/18] video: fbdev: intelfb: Move inline before return type
Date: Wed, 05 Jul 2017 20:02:24 +0000	[thread overview]
Message-ID: <8ba151a1fdc84e42cbf4aafc798513c0158edee1.1499284835.git.joe@perches.com> (raw)
In-Reply-To: <cover.1499284835.git.joe@perches.com>

Make the code like the rest of the kernel.

But there is an oddity here because the inline should probably be removed.

It's an extern function in intelfb.h and it is used in intelfbdrv.c and
intelfbhw.c.

The inline is kept here as I suppose it's possible for some compiler to
make the uses inline in intelfbdrv and and also create an external function
for intelfbhw.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400a86c..ffc391208b27 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -907,7 +907,7 @@ static void intelfb_pci_unregister(struct pci_dev *pdev)
  *                       helper functions                      *
  ***************************************************************/
 
-int __inline__ intelfb_var_to_depth(const struct fb_var_screeninfo *var)
+__inline__ int intelfb_var_to_depth(const struct fb_var_screeninfo *var)
 {
 	DBG_MSG("intelfb_var_to_depth: bpp: %d, green.length is %d\n",
 		var->bits_per_pixel, var->green.length);
-- 
2.10.0.rc2.1.g053435c


  parent reply	other threads:[~2017-07-05 20:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` [PATCH 01/18] checkpatch: improve the STORAGE_CLASS test Joe Perches
2017-07-05 20:02 ` [PATCH 02/18] ARM: KVM: Move asmlinkage before type Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 03/18] ARM: HP Jornada 7XX: Move inline before return type Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 04/18] CRIS: gpio: " Joe Perches
2017-07-05 20:02 ` [PATCH 05/18] FRV: tlbflush: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 06/18] ia64: Move inline " Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 07/18] ia64: sn: pci: Move inline before type Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 08/18] m68k: coldfire: Move inline before return type Joe Perches
2017-07-06  0:45   ` Greg Ungerer
2017-07-06  0:45     ` Greg Ungerer
2017-07-05 20:02 ` Joe Perches
2017-07-05 20:02 ` [PATCH 09/18] MIPS: SMP: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 10/18] sh: Move inline " Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 11/18] x86/efi: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 12/18] drivers: s390: Move static and inline " Joe Perches
2017-07-06 10:29   ` Heiko Carstens
2017-07-06 10:57     ` Joe Perches
2017-07-06 12:25       ` Heiko Carstens
2017-07-06 18:04         ` Julian Wiedmann
2017-07-05 20:02 ` [PATCH 13/18] drivers: tty: serial: Move " Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 14/18] USB: serial: safe_serial: Move __inline__ " Joe Perches
2017-07-05 20:02 ` Joe Perches [this message]
2017-07-05 20:02   ` [PATCH 15/18] video: fbdev: intelfb: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 16/18] video: fbdev: omap: " Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:02 ` [PATCH 17/18] ARM: samsung: usb-ohci: " Joe Perches
2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: " Joe Perches
2017-07-05 20:02   ` Joe Perches
2017-07-05 20:30   ` Clemens Ladisch
2017-07-05 20:30     ` Clemens Ladisch
2017-07-06  7:24   ` Takashi Iwai
2017-07-06  7:24     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ba151a1fdc84e42cbf4aafc798513c0158edee1.1499284835.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbroemme@libmpq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.