Re: [PATCH v2] selftests/bpf: Copy runqslower to OUTPUT directory

From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Veronika Kabatova <vkabatov@redhat.com>
Cc: bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andriin@fb.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH v2] selftests/bpf: Copy runqslower to OUTPUT directory
Date: Tue, 28 Apr 2020 21:40:30 +0200	[thread overview]
Message-ID: <8e07a2db-a258-f1b3-d1f4-74f131cbcb6d@iogearbox.net> (raw)
In-Reply-To: <CAEf4Bzbp44pnj-yNP61enxh8-ZvFn56fSF4uDHLz0ZcY-H2yAA@mail.gmail.com>

On 4/28/20 8:57 PM, Andrii Nakryiko wrote:
> On Tue, Apr 28, 2020 at 10:38 AM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>
>> $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
>> binary in the $(OUTPUT) directory. As lib.mk expects all
>> TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
>> the OUTPUT directory, this results in an error when running e.g. `make
>> install`:
>>
>> rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
>>         such file or directory (2)
>>
>> Copy the binary into the OUTPUT directory after building it to fix the
>> error.
>>
>> Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")
>> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
>> ---
> 
> Acked-by: Andrii Nakryiko <andriin@fb.com>

Applied, thanks!