From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Veronika Kabatova <vkabatov@redhat.com>
Cc: bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andriin@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH v2] selftests/bpf: Copy runqslower to OUTPUT directory
Date: Tue, 28 Apr 2020 11:57:49 -0700 [thread overview]
Message-ID: <CAEf4Bzbp44pnj-yNP61enxh8-ZvFn56fSF4uDHLz0ZcY-H2yAA@mail.gmail.com> (raw)
In-Reply-To: <20200428173742.2988395-1-vkabatov@redhat.com>
On Tue, Apr 28, 2020 at 10:38 AM Veronika Kabatova <vkabatov@redhat.com> wrote:
>
> $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> binary in the $(OUTPUT) directory. As lib.mk expects all
> TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> the OUTPUT directory, this results in an error when running e.g. `make
> install`:
>
> rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> such file or directory (2)
>
> Copy the binary into the OUTPUT directory after building it to fix the
> error.
>
> Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")
> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> ---
Looks good, thanks.
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/testing/selftests/bpf/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 7729892e0b04..4e654d41c7af 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -141,7 +141,8 @@ VMLINUX_BTF := $(abspath $(firstword $(wildcard $(VMLINUX_BTF_PATHS))))
> $(OUTPUT)/runqslower: $(BPFOBJ)
> $(Q)$(MAKE) $(submake_extras) -C $(TOOLSDIR)/bpf/runqslower \
> OUTPUT=$(SCRATCH_DIR)/ VMLINUX_BTF=$(VMLINUX_BTF) \
> - BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR)
> + BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR) && \
> + cp $(SCRATCH_DIR)/runqslower $@
>
> $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): $(OUTPUT)/test_stub.o $(BPFOBJ)
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-04-28 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 17:37 [PATCH v2] selftests/bpf: Copy runqslower to OUTPUT directory Veronika Kabatova
2020-04-28 18:57 ` Andrii Nakryiko [this message]
2020-04-28 19:40 ` Daniel Borkmann
2020-04-29 0:15 ` Andrii Nakryiko
2020-04-29 1:25 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzbp44pnj-yNP61enxh8-ZvFn56fSF4uDHLz0ZcY-H2yAA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=vkabatov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.