From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: "David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Lee, Chun-Yi" <jlee@suse.com>,
"Mark Gross" <markgross@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali@kernel.org>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Ike Panhc" <ike.pan@canonical.com>,
"Daniel Dadap" <ddadap@nvidia.com>,
"Kenneth Chan" <kenneth.t.chan@gmail.com>,
"Mattia Dongili" <malattia@linux.it>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Azael Avalos" <coproscefalo@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Robert Moore" <robert.moore@intel.com>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
ibm-acpi-devel@lists.sourceforge.net,
linux-fbdev@vger.kernel.org, devel@acpica.org
Subject: Re: [PATCH 00/22] Fallback to native backlight
Date: Tue, 25 Oct 2022 12:23:39 +0900 [thread overview]
Message-ID: <8ed65e3e-e0b9-05ae-b113-db9d649a1e5a@daynix.com> (raw)
In-Reply-To: <87o7u1drcz.fsf@intel.com>
On 2022/10/25 3:11, Jani Nikula wrote:
> On Tue, 25 Oct 2022, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>> That aside, the first patch in this series can be applied without the
>> later patches so you may have a look at it. It's fine if you don't merge
>> it though since it does not fix really a pragmatic bug as its message says.
>
> I think it's problematic because it needlessly ties i915 backlight
> operation to existence of backlight devices that may not be related to
> Intel GPU at all. The direction should be multiple supported backlight
> devices, across GPUs and connectors, but only one per display.
>
> BR,
> Jani.
>
>
Unfortunately it is the current situation (even without this patch), and
this patch is not meant to fix the particular issue.
This patch replaces the following expression:
acpi_video_get_backlight_type() == acpi_backlight_native
As you can see, acpi_video_get_backlight_type() doesn't take a parameter
which represents the backlight currently being operated. The problem is
known and documented in "Brightness handling on devices with multiple
internal panels" section of Documentation/gpu/todo.rst.
The exiting solution is based on the assumption that no device with i915
and multiple internal backlights.
Regards,
Akihiko Odaki
WARNING: multiple messages have this Message-ID (diff)
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-fbdev@vger.kernel.org, "Ike Panhc" <ike.pan@canonical.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
dri-devel@lists.freedesktop.org,
"Azael Avalos" <coproscefalo@gmail.com>,
"Mattia Dongili" <malattia@linux.it>,
"Daniel Dadap" <ddadap@nvidia.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"David Airlie" <airlied@gmail.com>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Lee, Chun-Yi" <jlee@suse.com>, "Helge Deller" <deller@gmx.de>,
"Lee Jones" <lee@kernel.org>,
"Robert Moore" <robert.moore@intel.com>,
linux-acpi@vger.kernel.org,
"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
"Len Brown" <lenb@kernel.org>,
"Kenneth Chan" <kenneth.t.chan@gmail.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
intel-gfx@lists.freedesktop.org,
acpi4asus-user@lists.sourceforge.net,
"Maxime Ripard" <mripard@kernel.org>,
"Mark Gross" <markgross@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
platform-driver-x86@vger.kernel.org, devel@acpica.org,
ibm-acpi-devel@lists.sourceforge.net,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight
Date: Tue, 25 Oct 2022 12:23:39 +0900 [thread overview]
Message-ID: <8ed65e3e-e0b9-05ae-b113-db9d649a1e5a@daynix.com> (raw)
In-Reply-To: <87o7u1drcz.fsf@intel.com>
On 2022/10/25 3:11, Jani Nikula wrote:
> On Tue, 25 Oct 2022, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>> That aside, the first patch in this series can be applied without the
>> later patches so you may have a look at it. It's fine if you don't merge
>> it though since it does not fix really a pragmatic bug as its message says.
>
> I think it's problematic because it needlessly ties i915 backlight
> operation to existence of backlight devices that may not be related to
> Intel GPU at all. The direction should be multiple supported backlight
> devices, across GPUs and connectors, but only one per display.
>
> BR,
> Jani.
>
>
Unfortunately it is the current situation (even without this patch), and
this patch is not meant to fix the particular issue.
This patch replaces the following expression:
acpi_video_get_backlight_type() == acpi_backlight_native
As you can see, acpi_video_get_backlight_type() doesn't take a parameter
which represents the backlight currently being operated. The problem is
known and documented in "Brightness handling on devices with multiple
internal panels" section of Documentation/gpu/todo.rst.
The exiting solution is based on the assumption that no device with i915
and multiple internal backlights.
Regards,
Akihiko Odaki
WARNING: multiple messages have this Message-ID (diff)
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-fbdev@vger.kernel.org, "Ike Panhc" <ike.pan@canonical.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
dri-devel@lists.freedesktop.org,
"Azael Avalos" <coproscefalo@gmail.com>,
"Mattia Dongili" <malattia@linux.it>,
"Daniel Dadap" <ddadap@nvidia.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Lee, Chun-Yi" <jlee@suse.com>, "Helge Deller" <deller@gmx.de>,
"Lee Jones" <lee@kernel.org>,
"Robert Moore" <robert.moore@intel.com>,
linux-acpi@vger.kernel.org,
"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
"Len Brown" <lenb@kernel.org>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Kenneth Chan" <kenneth.t.chan@gmail.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
intel-gfx@lists.freedesktop.org,
acpi4asus-user@lists.sourceforge.net,
"Mark Gross" <markgross@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
platform-driver-x86@vger.kernel.org, devel@acpica.org,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
ibm-acpi-devel@lists.sourceforge.net,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 00/22] Fallback to native backlight
Date: Tue, 25 Oct 2022 12:23:39 +0900 [thread overview]
Message-ID: <8ed65e3e-e0b9-05ae-b113-db9d649a1e5a@daynix.com> (raw)
In-Reply-To: <87o7u1drcz.fsf@intel.com>
On 2022/10/25 3:11, Jani Nikula wrote:
> On Tue, 25 Oct 2022, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>> That aside, the first patch in this series can be applied without the
>> later patches so you may have a look at it. It's fine if you don't merge
>> it though since it does not fix really a pragmatic bug as its message says.
>
> I think it's problematic because it needlessly ties i915 backlight
> operation to existence of backlight devices that may not be related to
> Intel GPU at all. The direction should be multiple supported backlight
> devices, across GPUs and connectors, but only one per display.
>
> BR,
> Jani.
>
>
Unfortunately it is the current situation (even without this patch), and
this patch is not meant to fix the particular issue.
This patch replaces the following expression:
acpi_video_get_backlight_type() == acpi_backlight_native
As you can see, acpi_video_get_backlight_type() doesn't take a parameter
which represents the backlight currently being operated. The problem is
known and documented in "Brightness handling on devices with multiple
internal panels" section of Documentation/gpu/todo.rst.
The exiting solution is based on the assumption that no device with i915
and multiple internal backlights.
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2022-10-25 3:23 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 11:34 [PATCH 00/22] Fallback to native backlight Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 01/22] drm/i915/opregion: Improve backlight request condition Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 02/22] ACPI: video: Introduce acpi_video_get_backlight_types() Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 03/22] LoongArch: Use acpi_video_get_backlight_types() Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 04/22] platform/x86: acer-wmi: " Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 05/22] platform/x86: asus-laptop: " Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 06/22] platform/x86: asus-wmi: " Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 07/22] platform/x86: compal-laptop: " Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 08/22] platform/x86: eeepc-laptop: " Akihiko Odaki
2022-10-24 11:34 ` Akihiko Odaki
2022-10-24 11:34 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 09/22] platform/x86: fujitsu-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 22:24 ` Jonathan Woithe
2022-10-24 22:24 ` [Intel-gfx] " Jonathan Woithe
2022-10-24 22:24 ` Jonathan Woithe
2022-10-24 11:35 ` [PATCH 10/22] platform/x86: ideapad-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 11/22] platform/x86: msi-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 12/22] platform/x86: msi-wmi: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 13/22] platform/x86: nvidia-wmi-ec-backlight: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 14/22] platform/x86: panasonic-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 15/22] platform/x86: samsung-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 16/22] platform/x86: sony-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 17/22] platform/x86: thinkpad_acpi: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 18/22] platform/x86: toshiba_acpi: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 19/22] platform/x86: dell-laptop: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 20/22] platform/x86: intel_oaktrail: " Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 21/22] ACPI: video: Remove acpi_video_get_backlight_type() Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 22/22] ACPI: video: Fallback to native backlight Akihiko Odaki
2022-10-24 11:35 ` Akihiko Odaki
2022-10-24 11:35 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 11:48 ` [PATCH 00/22] " Jani Nikula
2022-10-24 11:48 ` Jani Nikula
2022-10-24 11:48 ` [Intel-gfx] " Jani Nikula
2022-10-24 11:56 ` Akihiko Odaki
2022-10-24 11:56 ` Akihiko Odaki
2022-10-24 11:56 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 12:00 ` Hans de Goede
2022-10-24 12:00 ` Hans de Goede
2022-10-24 12:00 ` [Intel-gfx] " Hans de Goede
2022-10-24 11:53 ` Hans de Goede
2022-10-24 11:53 ` Hans de Goede
2022-10-24 11:53 ` [Intel-gfx] " Hans de Goede
2022-10-24 12:58 ` Akihiko Odaki
2022-10-24 12:58 ` Akihiko Odaki
2022-10-24 12:58 ` Akihiko Odaki
2022-10-24 13:14 ` Pali Rohár
2022-10-24 13:14 ` Pali Rohár
2022-10-24 13:14 ` [Intel-gfx] " Pali Rohár
2022-10-24 13:23 ` Hans de Goede
2022-10-24 13:23 ` Hans de Goede
2022-10-24 13:23 ` [Intel-gfx] " Hans de Goede
2022-10-24 13:21 ` Hans de Goede
2022-10-24 13:21 ` Hans de Goede
2022-10-24 13:21 ` [Intel-gfx] " Hans de Goede
2022-10-24 14:06 ` Akihiko Odaki
2022-10-24 14:06 ` Akihiko Odaki
2022-10-24 14:06 ` Akihiko Odaki
2022-10-24 14:31 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 14:31 ` Akihiko Odaki
2022-10-24 14:31 ` Akihiko Odaki
2022-10-24 14:37 ` Hans de Goede
2022-10-24 14:37 ` Hans de Goede
2022-10-24 14:37 ` [Intel-gfx] " Hans de Goede
2022-10-24 15:00 ` Akihiko Odaki
2022-10-24 15:00 ` Akihiko Odaki
2022-10-24 15:00 ` Akihiko Odaki
2022-10-24 18:11 ` Jani Nikula
2022-10-24 18:11 ` Jani Nikula
2022-10-24 18:11 ` [Intel-gfx] " Jani Nikula
2022-10-25 3:23 ` Akihiko Odaki [this message]
2022-10-25 3:23 ` Akihiko Odaki
2022-10-25 3:23 ` [Intel-gfx] " Akihiko Odaki
2022-10-24 16:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-10-24 16:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-24 17:16 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed65e3e-e0b9-05ae-b113-db9d649a1e5a@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=airlied@gmail.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=coproscefalo@gmail.com \
--cc=corbet@lwn.net \
--cc=corentin.chary@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=ddadap@nvidia.com \
--cc=deller@gmx.de \
--cc=devel@acpica.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=jlee@suse.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jwoithe@just42.net \
--cc=kenneth.t.chan@gmail.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malattia@linux.it \
--cc=markgross@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mripard@kernel.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.