Re: [RESEND PATCHv2 4/4] arm64: dts: add support for per sub-dir makefiles for DT building

From: Frank Rowand <frowand.list@gmail.com>
To: Tero Kristo <t-kristo@ti.com>,
	catalin.marinas@arm.com, will.deacon@arm.com,
	linux@armlinux.org.uk, robh+dt@kernel.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	tony@atomide.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCHv2 4/4] arm64: dts: add support for per sub-dir makefiles for DT building
Date: Wed, 5 Sep 2018 13:37:26 -0700	[thread overview]
Message-ID: <8ef6d1a9-f038-c83b-24f7-fe42a8fdad0e@gmail.com> (raw)
In-Reply-To: <1536048344-9995-5-git-send-email-t-kristo@ti.com>

On 09/04/18 01:05, Tero Kristo wrote:
> Currently the makefile for arm64 builds all the DT files based on
> rules in the arch/arm64/boot/dts/Makefile, as this is statically
> passed via the $(build)= parameter. Change the $(build) parameter
> to actually point to the subdir itself, so the makefile from
> that subdir can be used to set-up build flags etc., for example
> setting up DTC_FLAGS. The patsubst magic is used to strip the
> trailing "/" from the path, as that confuses the kbuild system.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  arch/arm64/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index f04c814..2ac4358 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -128,7 +128,7 @@ zinstall install:
>  	$(Q)$(MAKE) $(build)=$(boot) $@
>  
>  %.dtb %.dtbo: scripts
> -	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@
> +	$(Q)$(MAKE) $(build)=$(patsubst %/,%,$(boot)/dts/$(dir $@)) $(boot)/dts/$@
>  
>  PHONY += dtbs dtbs_install
>  
> 

same comment as for patch 2/4