Re: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
	Alexander Klimov <grandmaster@al2klimov.de>,
	Alex Dewar <alex.dewar90@gmail.com>,
	Antonino Daplas <adaplas@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Evgeny Novikov <novikov@ispras.ru>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	George Kennedy <george.kennedy@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Gustavo Silva <gustavoars@kernel.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Jason Yan <yanaijie@huawei.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Jiri Slaby <jirislaby@kernel.org>, Joe Perches <joe@perches.com>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mike Rapoport <rppt@kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
	Qilong Zhang <zhangqilong3@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Thomas Winischhofer <thomas@winischhofer.net>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi
Date: Tue, 1 Dec 2020 11:03:42 +0100	[thread overview]
Message-ID: <8f39b00f-3ec7-0712-0eaa-07156c1cdc37@suse.de> (raw)
In-Reply-To: <20201128224114.1033617-23-sam@ravnborg.org>


[-- Attachment #1.1: Type: text/plain, Size: 3269 bytes --]


Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix several W=1 warnings.
> This removes unused code and avoids an assignment by moving
> the use inside the conditional block.
> 
> The register read FLD_GET(r, 15, 8) could be dropped as it was done a
> few lines before too.
> 
> v2:
>    - Updated subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Lee Jones <lee.jones@linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 6f9c25fec994..72d45a02c3ac 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -1178,13 +1178,12 @@ static int dsi_regulator_init(struct platform_device *dsidev)
>   
>   static void _dsi_print_reset_status(struct platform_device *dsidev)
>   {
> -	u32 l;
>   	int b0, b1, b2;
>   
>   	/* A dummy read using the SCP interface to any DSIPHY register is
>   	 * required after DSIPHY reset to complete the reset of the DSI complex
>   	 * I/O. */
> -	l = dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
> +	dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
>   
>   	if (dss_has_feature(FEAT_DSI_REVERSE_TXCLKESC)) {
>   		b0 = 28;
> @@ -3627,7 +3626,7 @@ static int dsi_proto_config(struct platform_device *dsidev)
>   static void dsi_proto_timings(struct platform_device *dsidev)
>   {
>   	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> -	unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail;
> +	unsigned tlpx, tclk_zero, tclk_prepare;
>   	unsigned tclk_pre, tclk_post;
>   	unsigned ths_prepare, ths_prepare_ths_zero, ths_zero;
>   	unsigned ths_trail, ths_exit;
> @@ -3646,7 +3645,6 @@ static void dsi_proto_timings(struct platform_device *dsidev)
>   
>   	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG1);
>   	tlpx = FLD_GET(r, 20, 16) * 2;
> -	tclk_trail = FLD_GET(r, 15, 8);
>   	tclk_zero = FLD_GET(r, 7, 0);
>   
>   	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG2);
> @@ -4040,7 +4038,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
>   {
>   	struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev);
>   	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> -	u16 dw, dh;
>   
>   	dsi_perf_mark_setup(dsidev);
>   
> @@ -4049,11 +4046,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
>   	dsi->framedone_callback = callback;
>   	dsi->framedone_data = data;
>   
> -	dw = dsi->timings.x_res;
> -	dh = dsi->timings.y_res;
> -
>   #ifdef DSI_PERF_MEASURE
> -	dsi->update_bytes = dw * dh *
> +	dsi->update_bytes = dsi->timings.x_res * dsi->timings.y_res *
>   		dsi_get_pixel_size(dsi->pix_fmt) / 8;
>   #endif
>   	dsi_update_screen_dispc(dsidev);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]