From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/guc: Handle interrupt based logging with lack of SSE4.1, relay and other setup
Date: Wed, 31 Jan 2018 15:24:50 +0530 [thread overview]
Message-ID: <902f0876-0eea-d5c4-d7f7-de3633187ac7@intel.com> (raw)
In-Reply-To: <151739150606.10214.14523374424856928927@mail.alporthouse.com>
On 1/31/2018 3:08 PM, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2018-01-31 06:14:38)
>> On some systems like skl-gvtdvm, SSE4.1 movntdqa might not be available.
>> movntdqa is needed for efficient capture of the logs from uncached GuC
>> log buffer. GuC init was tied with this support and other setup needed
>> for interrupt based GuC log capture like relay channel/file support and
>> uncached mapping support. With this patch, GuC init is now unblocked from
>> lack of this support.
>> SSE and relay support init/fini is now being done by new functions
>> intel_guc_log_init|fini_runtime() which makes relay functions static.
>> We have introduced two states "supported" and "enabled". Supported is set
>> when we have SSE4.1 support and have relay, GuC log, WC mapping available.
>> Enabled is set when support is present and user has requested logging
>> through i915_modparams.guc_log_level.
>> While at this change, fixed unwind order in intel_uc_fini_misc.
> Downside would appear to be the loss of feedback in i915.guc_log_level
> when it fail?
This patch decouples the guc_log_level from only interrupt based log
support.
We can continue to use/know guc_log_level to send the verbosity to GuC
still.
Have to rely only on static dumps like i915_guc_log_dump or
error_uc->guc_log wherever runtime logging is off.
> Otherwise, looks tidy enough.
> -Chris
--
Thanks,
Sagar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-31 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 6:14 [PATCH 1/3] drm/i915/guc: Fix return from guc_log_relay_file_create Sagar Arun Kamble
2018-01-31 6:14 ` [PATCH 2/3] drm/i915/guc: Handle interrupt based logging with lack of SSE4.1, relay and other setup Sagar Arun Kamble
2018-01-31 9:38 ` Chris Wilson
2018-01-31 9:54 ` Sagar Arun Kamble [this message]
2018-01-31 10:37 ` Michał Winiarski
2018-01-31 10:45 ` Chris Wilson
2018-01-31 11:20 ` Sagar Arun Kamble
2018-01-31 6:14 ` [PATCH 3/3] [HAX] drm/i915/guc: Enable GuC and logging for CI Sagar Arun Kamble
2018-01-31 6:39 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/guc: Fix return from guc_log_relay_file_create Patchwork
2018-01-31 9:36 ` [PATCH 1/3] " Chris Wilson
2018-01-31 9:49 ` Sagar Arun Kamble
2018-01-31 11:39 ` ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=902f0876-0eea-d5c4-d7f7-de3633187ac7@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.