From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/guc: Fix return from guc_log_relay_file_create
Date: Wed, 31 Jan 2018 15:19:20 +0530 [thread overview]
Message-ID: <b931d837-afcd-2b29-2a65-1503c14656d5@intel.com> (raw)
In-Reply-To: <151739138265.10214.12853003441023421738@mail.alporthouse.com>
On 1/31/2018 3:06 PM, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2018-01-31 06:14:37)
>> guc_log_relay_file_create will return -EEXIST if we invoke
>> relay_late_setup_files multiple times as part of i915_guc_log_control.
>> However this is to be not cosidered as fail and need to return 0.
>> This was mistakenly introduced in the below commit. Fix it.
>>
>> Fixes: 70deeaddc6e6 "drm/i915/guc: Fix lockdep due to log relay channel handling under struct_mutex"
>> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Testcase?
Yes. will include.
Thanks for the review.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Thanks,
Sagar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-31 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 6:14 [PATCH 1/3] drm/i915/guc: Fix return from guc_log_relay_file_create Sagar Arun Kamble
2018-01-31 6:14 ` [PATCH 2/3] drm/i915/guc: Handle interrupt based logging with lack of SSE4.1, relay and other setup Sagar Arun Kamble
2018-01-31 9:38 ` Chris Wilson
2018-01-31 9:54 ` Sagar Arun Kamble
2018-01-31 10:37 ` Michał Winiarski
2018-01-31 10:45 ` Chris Wilson
2018-01-31 11:20 ` Sagar Arun Kamble
2018-01-31 6:14 ` [PATCH 3/3] [HAX] drm/i915/guc: Enable GuC and logging for CI Sagar Arun Kamble
2018-01-31 6:39 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/guc: Fix return from guc_log_relay_file_create Patchwork
2018-01-31 9:36 ` [PATCH 1/3] " Chris Wilson
2018-01-31 9:49 ` Sagar Arun Kamble [this message]
2018-01-31 11:39 ` ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b931d837-afcd-2b29-2a65-1503c14656d5@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.